Bug 1071657 - Adding Custom Errata to Custom Channel feature on WebUI offers Red Hat Erratas as well.
Summary: Adding Custom Errata to Custom Channel feature on WebUI offers Red Hat Errata...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite 5
Classification: Red Hat
Component: WebUI
Version: 560
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Stephen Herr
QA Contact: Dimitar Yordanov
URL:
Whiteboard:
Depends On:
Blocks: sat570-lowbug
TreeView+ depends on / blocked
 
Reported: 2014-03-02 17:37 UTC by Dimitar Yordanov
Modified: 2015-01-13 09:54 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-13 09:54:57 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch (1.25 KB, patch)
2014-03-05 13:55 UTC, Dimitar Yordanov
no flags Details | Diff

Description Dimitar Yordanov 2014-03-02 17:37:28 UTC
Description of problem:
Adding Custom Errata to Custom Channel feature on WebUI offers Red Hat Erratas as well.

Version-Release number of selected component (if applicable):
spacewalk-java-2.0.2-62

How reproducible:
100%

Steps to Reproduce:
1. satellite-sync -c  rhel-x86_64-server-6
2. Clone this channel as "Original state of the channel (no errata)"
    Manage Software Channels -> Clone Channel -> rhel-x86_64-server-6 as "Original state of the channel (no errata)"
3. Manage Software Channels -> "Clone of Red Hat Enterprise Linux Server (v. 6 for 64-bit x86_64)" -> Errata -> Add Errata -> Add Custom Errata 

Actual results:
The Red Hat Erratas from  channel rhel-x86_64-server-6  are listed.

Expected results:
Only Erratas from custom channels can be listed.

Additional info:

See: java/code/src/com/redhat/rhn/frontend/action/channel/manage/AddCustomErrataAction.java

        //If this is a clone, go ahead and pre-select the original Channel
        Channel original = ChannelFactory.lookupOriginalChannel(currentChan);
        if (!requestContext.isSubmitted() && original != null) {
            selectedChannel = original;
            selectedChannelStr = selectedChannel.getId().toString();
        }

        request.setAttribute(SELECTED_CHANNEL, selectedChannelStr);

Comment 1 Tomas Lestach 2014-03-03 10:35:54 UTC
Hey Dimitar, is this a regression?

Comment 2 Dimitar Yordanov 2014-03-05 13:55:40 UTC
Created attachment 870979 [details]
Patch

Comment 3 Dimitar Yordanov 2014-03-05 13:58:24 UTC
Hi Tomas, 
  It is not a regression but seems easy fixable.
  Please see attachment.
Dimi

Comment 4 Stephen Herr 2014-03-14 19:06:15 UTC
Hi Dimitar,

I've reviewed and accepted your patch. Committed as 99758981d8471e38a1dc6c712265f62d3899000d

It seems that when I used github to automerge your commit it made me the author as well as messing up our straight-line git history. Sorry, I'm still learning how to use github apparently.

Comment 6 Tomas Lestach 2014-03-17 09:07:04 UTC
The correct commit is ...

spacewalk.git: 37197fa02d1237be63a1e2b868762a40fe7dace3

Comment 8 psmatana 2014-12-01 19:39:46 UTC
I am so sorry. I prepared text for this bug but by mistake I paste wrong one. This is correct:


Verification.

spacewalk-java-2.3.8-75.el6sat

I precisely followed the Description. In my clone channel there are no errata any more. When I set Channels -> Manage Software Channels -> Select my clone Channel -> Errata -> Add Errata -> Add Custom Errata.

There is no Errata so this is correct behaviour.



Reproduction.

spacewalk-java-2.0.2-62.el6sat

I precisely followed the Description. In my clone channel there are no errata any more. When I set Channels -> Manage Software Channels -> Select my clone Channel -> Errata -> Add Errata -> Add Custom Errata.

There are about 2,500 erratas which is uncorrect.

Comment 10 Clifford Perry 2015-01-13 09:54:57 UTC
With the release of Red Hat Satellite 5.7 on January 12th 2015 this bug is
being moved to a Closed Current Release state. 

The Satellite 5.7 GA Errata:
 - https://rhn.redhat.com/errata/RHSA-2015-0033.html 

Satellite 5.7 Release Notes:
 -
https://access.redhat.com/documentation/en-US/Red_Hat_Satellite/5.7/html-single/Release_Notes/index.html

Satellite Customer Portal Blog announcement for release:
 - https://access.redhat.com/blogs/1169563/posts/1315743 

Cliff


Note You need to log in before you can comment on or make changes to this bug.