Created attachment 870445 [details] patch Description of problem: This patch against the spec file provides an empty %check section explaining why test suite is not executed there. For more info see: https://fedoraproject.org/wiki/QA/Testing_in_check
Java packages which are built using Apache Maven run their unit and integration tests in %build as part of upstream build. This is a well known fact among Java SIG and doesn't need any explaination. Moreover my position on that matter was previously stated on devel mailing list: https://lists.fedoraproject.org/pipermail/devel/2014-February/195918.html Because of the above I am closing this request as WONTFIX. PS. If you intend to submit any further patches to packages I own, please follow these instructions: https://fedoraproject.org/wiki/User:Mizdebsk/HowToSubmitPatches
(In reply to Mikolaj Izdebski from comment #1) > Java packages which are built using Apache Maven run their unit and > integration tests in %build as part of upstream build. This is a well > known fact among Java SIG and doesn't need any explaination. > > Moreover my position on that matter was previously stated on devel mailing > list: > https://lists.fedoraproject.org/pipermail/devel/2014-February/195918.html > > Because of the above I am closing this request as WONTFIX. > Either way, what is stopping you from accepting a patch (provided it follows the guidelines below) ? > PS. If you intend to submit any further patches to packages I own, > please follow these instructions: > https://fedoraproject.org/wiki/User:Mizdebsk/HowToSubmitPatches <quote> The patch should be created against current master branch in git repository, even if the bug is reported against a stable release. Don't submit patches against stable releases, I will rebase your patch if needed. This is because all development should be done in rawhide. </quote> Question: where do I find the git repos containing the spec files for your packages?
(In reply to Alexander Todorov from comment #2) > Either way, what is stopping you from accepting a patch (provided it follows > the guidelines below) ? Because your patch has negative value for the package -- it only adds a comment stating an obvious thing. In Fedora we have about 800 packages built with Maven, most of which run their tests in %build. Should we add empty %check sections to all of them? If not then why only some of them? What stops you from excluding Maven packages in your checks? Is 800 packages (and still growing) not big group enough to implement exclusion for them? > Question: where do I find the git repos containing the spec files for your > packages? http://pkgs.fedoraproject.org/
(In reply to Mikolaj Izdebski from comment #3) > (In reply to Alexander Todorov from comment #2) > > Either way, what is stopping you from accepting a patch (provided it follows > > the guidelines below) ? > > Because your patch has negative value for the package -- it only adds a > comment stating an obvious thing. > This is only obvious to those who are familiar with Java packaging and not everyone else. A comment makes things clear to the rest of the world. > In Fedora we have about 800 packages built with Maven, most of which run > their tests in %build. Should we add empty %check sections to all of them? > If not then why only some of them? Patches are coming one by one as I'm sure you already saw. > What stops you from excluding Maven > packages in your checks? Is 800 packages (and still growing) not big group > enough to implement exclusion for them? > I tried http://mizdebsk.fedorapeople.org/scripts/wr-testsuitecheck but I'm not convinced it works reliably on a global scale. It reported some false positives for me. The best way is to have a %check section in each spec file, thus I'm sending you patches.