Bug 1072629

How to add second attachment?

Second attachment is in https://mojo.redhat.com/docs/DOC-940004

Created attachment 870705 [details]
2nd attachment

We will investigate this. Can you clarify if this is a customer support case or a regular ticket caught on internal tests?

Customer want to use inheritance in decision table.  Inheritance works with drl.  We may be able to use template in the mean time and lower the priority.

The provided test case is quite huge and then it is a bit difficult to figure out what's going wrong. Anyway my current understanding is the following: in the amentra-cdi-inheritance test AllocatedCashflow extends TypedCashflow that in turn extends Cashflow. In this way, since AllocatedCashflow is both a TypedCashflow and a Cashflow, ALL the rules defined in CashflowDT, TypedCashflowDT and AllocatedTypedCashflowDT fire on the same AllocatedCashflow instances inserted in the session. Even worse they do so in an unpredictable order modifying the same AllocatedCashflow instance multiple times, so at the end of this process it is virtually impossible to say what is the actual amount of a given cashflow. This is why the test is failing and indeed excluding CashflowDT and TypedCashflowDT makes it to succeed. 

To recap I think the test case is flawed because it doesn't take into account that if B extends A, BOTH rules constraining A and B are eligible to be fired and not only the ones related to B.

If my analysis is correct please close this ticket as invalid, otherwise feel free to explain in a bit more details how this test case is supposed to work or even better to provide a bit more isolated test case demonstrating this issue.

Your analysis is incorrect.  BRMS6 is up classing sub class to super class.

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.947 sec <<< FAILURE! - in com.amentra.brms.cdi.SimpleDateTest
test1(com.amentra.brms.cdi.SimpleDateTest)  Time elapsed: 3.902 sec  <<< ERROR!
java.lang.RuntimeException: Error while creating KieBase[Message [id=1, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=167, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=2, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=50, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=3, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=32, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=4, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=14, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=5, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=77, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=6, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=95, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=7, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=149, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=8, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=158, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=9, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=113, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=10, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=5, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=11, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=131, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=12, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=23, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=13, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=68, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=14, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=86, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=15, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=41, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=16, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=140, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=17, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=176, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=18, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=104, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=19, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=59, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date], Message [id=20, level=ERROR, path=com/amentra/brms/fact/SimpleDateDT.xls, line=122, column=0
   text=Rule Compilation error The method setStatus(String) is undefined for the type Date
The method setDateString(String) is undefined for the type Date]]
	at org.drools.compiler.kie.builder.impl.KieContainerImpl.getKieBase(KieContainerImpl.java:336)
	at org.drools.compiler.kie.builder.impl.KieContainerImpl.newKieSession(KieContainerImpl.java:481)
	at org.drools.compiler.kie.builder.impl.KieContainerImpl.newKieSession(KieContainerImpl.java:456)
	at org.drools.compiler.cdi.KieCDIExtension$StatefulKSessionBean.create(KieCDIExtension.java:825)
	at org.drools.compiler.cdi.KieCDIExtension$StatefulKSessionBean.create(KieCDIExtension.java:768)
	at org.jboss.weld.context.AbstractContext.get(AbstractContext.java:103)
	at org.jboss.weld.bean.proxy.ContextBeanInstance.getInstance(ContextBeanInstance.java:90)
	at org.jboss.weld.bean.proxy.ProxyMethodHandler.invoke(ProxyMethodHandler.java:104)
	at org.jboss.weld.proxies.KieSession$1366014918$Proxy$_$$_WeldClientProxy.setGlobal(KieSession$1366014918$Proxy$_$$_WeldClientProxy.java)
	at com.amentra.brms.cdi.AmentraCDI.execute(AmentraCDI.java:21)
	at com.amentra.brms.cdi.SimpleDateTest.test1(SimpleDateTest.java:30)

I will attach a second archive and you take a second look at the issues

Created attachment 879120 [details]
Compilation issues in BRMS6 associated with using inheritance

The BRMS6 is up-classing sub-class to its super-class.  See SimpleDateDT and SimpleDate.java.

I can confirm that I reproduced this issue. Oddly enough, the build fails only when the fact class (SimpleDate) is a subclass of java.util.Date; when I created the following wrapper class:

import java.io.Serializable;
import java.util.Date;

public class MyDate implements Serializable {

    private final Date wrappedDate;

    public MyDate() {
        this.wrappedDate = new Date();
    }

    public void setTime(final long millis) {
        this.wrappedDate.setTime(millis);
    }
}

and made SimpleDate from the reproducer extend MyDate, instead of java.util.Date, the compilation succeeded.

Created attachment 879352 [details]
jUnit reproducer with plain DRL

I reproduced the problem without decision tables using DRL only. Attaching reproducer.

Marek reproduced the compilation problem reported by David in his comment #7 in pure DRL, without using any dtable, and I fixed it with this commit https://github.com/droolsjbpm/drools/commit/36c5478d3 

However this fix only applies to a very specific case, i.e. the extension of the java.util.Date class. This together with 2 other evidences:

1. the bug was reproducible also with plain DRL
2. the bug caused a compilation error and not a silent misbehaviour 

makes me think that the issue I fixed is totally unrelated with the originally reported problem. For that regard I strongly believe that what I wrote in my comment #6 is still perfectly valid.

Cherry-picked to 6.0.x with https://github.com/droolsjbpm/drools/commit/b4260e6e3

Created attachment 879389 [details]
Decision tables modified to exclude undesired facts

I have modified the decision tables from David's test from comment #2 to exclude subclasses from the rules which probably should not apply to them (as explained by Mario in comment #6), for example:

 index == $param && !(this instanceof com.amentra.brms.fact.AllocatedCashflow)

With the modified decision tables, the tests pass now:

QATest2.txt:
6	 success
5	 success
4	 success
3	 success
2	 success
1	 success

I believe this confirms Mario's original comment. I am attaching the modified decision tables. David, could you please validate that it works for you?

Mario, Marek.  Thanks. The solution works.

The bug with extending java.util.Date is gone (verified with 6.0.2 ER2).
The original bug was solved as well. Therefore I mark this as VERIFIED.