Bug 1072878 - [RFE] - provisioning with existing database 'engine' should alert user
Summary: [RFE] - provisioning with existing database 'engine' should alert user
Keywords:
Status: CLOSED DUPLICATE of bug 1259782
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Setup.Engine
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Yedidyah Bar David
QA Contact: Pavel Stehlik
URL:
Whiteboard: integration
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-05 10:27 UTC by Yedidyah Bar David
Modified: 2016-01-27 08:57 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-01-27 08:57:41 UTC
oVirt Team: Integration
Embargoed:
ylavi: ovirt-future?
ylavi: planning_ack?
sbonazzo: devel_ack+
ylavi: testing_ack?


Attachments (Terms of Use)

Description Yedidyah Bar David 2014-03-05 10:27:09 UTC
Description of problem:

Provisioning checks if db 'engine' exists only rather late.

If possible, it should check that at validation, and show the new chosen name at the preview. Otherwise it should warn (or at least info?) that it's creating a new db/user.

Comment 1 Alon Bar-Lev 2014-03-05 10:31:25 UTC
(In reply to Yedidyah Bar David from comment #0)
> Description of problem:
> 
> Provisioning checks if db 'engine' exists only rather late.
> 
> If possible, it should check that at validation, and show the new chosen
> name at the preview. Otherwise it should warn (or at least info?) that it's
> creating a new db/user.

If user/database are renamed they are displayed in the summary.

Comment 2 Yedidyah Bar David 2014-03-05 10:49:36 UTC
(In reply to Alon Bar-Lev from comment #1)
> (In reply to Yedidyah Bar David from comment #0)
> > Description of problem:
> > 
> > Provisioning checks if db 'engine' exists only rather late.
> > 
> > If possible, it should check that at validation, and show the new chosen
> > name at the preview. Otherwise it should warn (or at least info?) that it's
> > creating a new db/user.
> 
> If user/database are renamed they are displayed in the summary.

I didn't notice that, perhaps that's the problem :-)

Anyway, why not check at validation? I think it's quite misleading to say there 'engine' if we can check and know that it will be different.

Comment 3 Alon Bar-Lev 2014-03-05 10:55:57 UTC
(In reply to Yedidyah Bar David from comment #2)
> Anyway, why not check at validation? I think it's quite misleading to say
> there 'engine' if we can check and know that it will be different.

I do not like we access database at all before misc... and in provisioning it is worse as we need to modify user password before we can check if database is empty, so we actually change system state, which belongs to misc.

Comment 4 Yedidyah Bar David 2014-03-05 11:05:50 UTC
(In reply to Alon Bar-Lev from comment #3)
> (In reply to Yedidyah Bar David from comment #2)
> > Anyway, why not check at validation? I think it's quite misleading to say
> > there 'engine' if we can check and know that it will be different.
> 
> I do not like we access database at all before misc... and in provisioning
> it is worse as we need to modify user password before we can check if
> database is empty, so we actually change system state, which belongs to misc.

Very well, so warn when possible.

IMO, in most if not all cases, this is an indication of a problem from the user's pov.

Comment 5 Alon Bar-Lev 2014-03-05 11:12:22 UTC
(In reply to Yedidyah Bar David from comment #4)
> (In reply to Alon Bar-Lev from comment #3)
> > (In reply to Yedidyah Bar David from comment #2)
> > > Anyway, why not check at validation? I think it's quite misleading to say
> > > there 'engine' if we can check and know that it will be different.
> > 
> > I do not like we access database at all before misc... and in provisioning
> > it is worse as we need to modify user password before we can check if
> > database is empty, so we actually change system state, which belongs to misc.
> 
> Very well, so warn when possible.
> 
> IMO, in most if not all cases, this is an indication of a problem from the
> user's pov.

this people who use provisioning do not care what database is created, you can as well condition the summary print.

what will a warning serve in this case? what is the action item?

not sure these kind of discussions belongs to bugzilla.

Comment 6 Alon Bar-Lev 2014-03-09 01:13:41 UTC
OK, I was wrong, we connect using postgres user, so we do not need to alter state when checking if database is empty.

So this can be done at validation stage if introducing complexity for the provisioning module that is now an autonomic stage.

If this is to be done, it should be synced in dwh and reports.

I still think that just dropping the user and database names from summary if provisioning is the simplest solution if indeed there is a problem.

Comment 7 Sandro Bonazzola 2015-10-01 07:33:27 UTC
Postponing to 3.6.1 not being a blocker for 3.6.0

Comment 8 Red Hat Bugzilla Rules Engine 2015-10-19 10:58:30 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 9 Yedidyah Bar David 2016-01-27 08:57:41 UTC

*** This bug has been marked as a duplicate of bug 1259782 ***


Note You need to log in before you can comment on or make changes to this bug.