Bug 1073922
| Summary: | [engine-setup] Proxying Red Hat Support Plugin requires password | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Jiri Belka <jbelka> | ||||
| Component: | rhevm-setup-plugins | Assignee: | Sandro Bonazzola <sbonazzo> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Jiri Belka <jbelka> | ||||
| Severity: | high | Docs Contact: | Jodi Biddle <jbiddle> | ||||
| Priority: | high | ||||||
| Version: | 3.4.0 | CC: | acathrow, bazulay, eedri, gklein, iheim, kroberts, lbopf, Rhev-m-bugs, sbonazzo, scohen, sfolkwil, sshumake, yeylon | ||||
| Target Milestone: | --- | ||||||
| Target Release: | 3.4.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | subeng | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Previously, when opting during engine-setup to broker transactions from the Red Hat Access Plugin through a proxy server, a password was requested, even if the 'username' field was left blank. Now, hitting enter without entering a user name defaults to empty string, and setup continues without a password.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-06-09 13:31:35 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Jiri Belka
2014-03-07 13:44:20 UTC
There are two basic types or proxies. They are proxies that are passworded and password-less proxies. The proxy setup flow is clearly not allowing a user to elect a non-passworded proxy (i.e. just a URL). A relatively easy way to fix this would be to gate the prompts for proxy user and pass with a [Yes/No] question[see 1]. Alex, IIRC you wrote this do you agree? [1] Does your proxy server require a user name and password [Yes/No]? Alex is not working for Red Hat anymore. I can add the additional questions. Please note that the new questions will require new keys in answer file for automation testing. (In reply to Sandro Bonazzola from comment #2) > Alex is not working for Red Hat anymore. > I can add the additional questions. Please note that the new questions will > require new keys in answer file for automation testing. Here is what I recommend. After the following 2 questions... - Please enter your proxy server so that the Red Hat Access Plug-in can reach access.redhat.com.[http://localhost]: - Please enter the port of your proxy server. [3128]: Ask the following question... - Does your proxy server require a user name and password [No]? <-- This is rare If the user selects 'No' do not ask them to provide a proxy user/password and, do not insert proxyuser and proxypass into the property file. If the user selects 'Yes' then prompt the user, do not accept null values, and set the values in the property file. IMHO this overcomplexity is funny - if username is empty, just accept there's no username. Why would you need another question? Please KISS! Thx. (In reply to Jiri Belka from comment #4) > IMHO this overcomplexity is funny - if username is empty, just accept > there's no username. Why would you need another question? Please KISS! Thx. I agree. If your proxy server requires a user name, please enter it now [username]: should just be: If your proxy server requires a user name, please enter it now: hitting enter here should take default as empty string and avoid to use credentials. (In reply to Jiri Belka from comment #4) > IMHO this overcomplexity is funny - if username is empty, just accept > there's no username. Why would you need another question? Please KISS! Thx. Have no problem with this approach. The both arrive at the same result. (In reply to Keith Robertson from comment #3) > If the user selects 'No' do not ask them to provide a proxy user/password > and, do not insert proxyuser and proxypass into the property file. If the > user selects 'Yes' then prompt the user, do not accept null values, and set > the values in the property file. Currently if not set, proxyUser and proxyPassword are set to empty string. Do you want them like that or really not written into the file? ok, rhevm-setup-plugins-3.4.0-0.7.beta3.el6ev.noarch # rpm -q rhevm-setup-plugins rhevm-setup-plugins-3.4.0-0.7.beta3.el6ev.noarch # cat /etc/ovirt-engine/redhatsupportplugin.conf isProxy=true proxyURL=http://localhost proxyPort=3128 proxyUser= proxyPassword= Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0653.html |