Bug 1073935

"be careful, this is going to change the current answer files in CI, and as this is post release of 3.3 then there should be some conversion code."[1]

We should add this.

[1] https://gerrit.eng.lab.tlv.redhat.com/#/c/10843/1

Alon, what do you mean? Add conversion code?

(In reply to Sandro Bonazzola from comment #2)
> Alon, what do you mean? Add conversion code?

Look into the previous variables and set the new ones.
In 3.4 you can break backward compatibility for answer files of 3.3.
If I remember correctly this was done in 3.3?

(In reply to Jiri Belka from comment #0)
> # cat /var/lib/ovirt-engine/setup/answers/20140307145931-setup.conf | sort |
> uniq -d
> OVESETUP_RHEVM_SUPPORT/configureRedhatSupportPlugin=bool:False
> OVESETUP_RHEVM_SUPPORT/redhatSupportProxyEnabled=bool:True
> OVESETUP_RHEVM_SUPPORT/redhatSupportProxyPassword=str:somepass
> OVESETUP_RHEVM_SUPPORT/redhatSupportProxyPort=str:8080
> OVESETUP_RHEVM_SUPPORT/redhatSupportProxy=str:http://127.0.0.1
> OVESETUP_RHEVM_SUPPORT/redhatSupportProxyUser=str:someuser
> 
> ^^^ huh, duplicated lines!

Right, that's a bug :-)

> 
> # cat /etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf               
> 
> [environment:default]
> OVESETUP_CORE/generatedByVersion=str:3.4.0_master
> OVESETUP_SYSTEM/nfsConfigEnabled=bool:False
> OVESETUP_CONFIG/isoDomainName=none:None
> OVESETUP_CONFIG/isoDomainSdUuid=none:None
> OVESETUP_CONFIG/firewallManager=str:iptables
> OVESETUP_CONFIG/websocketProxyConfig=bool:True
> OVESETUP_CONFIG/fqdn=str:jb-rhevm34.rhev.lab.eng.brq.redhat.com
> OVESETUP_CONFIG/isoDomainMountPoint=none:None
> OVESETUP_CONFIG/isoDomainExists=bool:False
> OVESETUP_CONFIG/isoDomainStorageDir=none:None
> OVESETUP_APACHE/configured=bool:True
> OVESETUP_RHEVM_SUPPORT/configureRedhatSupportPlugin=bool:False
> OVESETUP_RHEVM_SUPPORT/configureRedhatSupportPlugin=bool:False
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - why twice?

Also this. Actually the same one.

> where are
> other options?
> - redhatSupportProxyEnabled
> - redhatSupportProxyPassword
> - redhatSupportProxyPort
> - redhatSupportProxy
> - redhatSupportProxyUser

That's not a bug. One the support plugin is configured, and postinstall sets 'configure=False' to prevent configuring it again, we do not need these answers in future upgrades.

Now pushed a fix.

(In reply to Alon Bar-Lev from comment #1)
> "be careful, this is going to change the current answer files in CI, and as
> this is post release of 3.3 then there should be some conversion code."[1]
> 
> We should add this.
> 
> [1] https://gerrit.eng.lab.tlv.redhat.com/#/c/10843/1

That's unrelated to this bug.

Jiri - not sure if you understood Alon's comment. Answer files for 3.3 have a different prefix in their keys than for 3.4+ - e.g.
3.3:
OVESETUP_SYSTEM/configureRedhatSupportPlugin
OVESETUP_SYSTEM/redhatSupportProxyPort
3.4:
OVESETUP_RHEVM_SUPPORT/configureRedhatSupportPlugin
OVESETUP_RHEVM_SUPPORT/redhatSupportProxyPort

Not sure this is a problem, just note. If it is, open a bug :-)

ok, av7.

# cat /var/lib/ovirt-engine/setup/answers/20140430090102-setup.conf | sort | uniq -d
#

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0653.html