Spec URL: http://ddick.fedorapeople.org/packages/perl-X11-GUITest.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-X11-GUITest-0.27-1.fc20.src.rpm Description: Provides GUI testing/interaction routines Fedora Account System Username: ddick
koji build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6614419
Upstream have released another version Spec URL: http://ddick.fedorapeople.org/packages/perl-X11-GUITest.spec SRPM URL: http://ddick.fedorapeople.org/packages/perl-X11-GUITest-0.28-1.fc20.src.rpm
koji build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6643844
TODO: Add the missing perl(Config) BR, Makefile.PL:6 TODO: Substitute PERL_INSTALL_ROOT with DESTDIR TIP: How about packaging the `eg' directory, too? FIX: Given the copyright headers in all the source files, I think the License tag should be corrected to `GPLv2+'. Also, is libXi-devel really required? I don't see its headers used anywhere.
TODO: Add the missing perl(Config) BR, Makefile.PL:6 Done. TODO: Substitute PERL_INSTALL_ROOT with DESTDIR Done. TIP: How about packaging the `eg' directory, too? The eg directory contains a dependency on perl-Image-SubImageFind. I have prepared this package at https://bugzilla.redhat.com/show_bug.cgi?id=1077956, made it ready for review, and marked it as blocking this review. FIX: Given the copyright headers in all the source files, I think the License tag should be corrected to `GPLv2+'. Done Also, is libXi-devel really required? I don't see its headers used anywhere. This is where X11/extensions/XInput.h exists in EL6. Note the successful koji build at http://koji.fedoraproject.org/koji/taskinfo?taskID=6648210 vs the one with libXi-devel not present at http://koji.fedoraproject.org/koji/taskinfo?taskID=6648242 I have added a comment explaining this into the spec file
(In reply to David Dick from comment #5) > TODO: Add the missing perl(Config) BR, Makefile.PL:6 > > Done. Check. > TODO: Substitute PERL_INSTALL_ROOT with DESTDIR > > Done. Check. > TIP: How about packaging the `eg' directory, too? > > The eg directory contains a dependency on perl-Image-SubImageFind. I have > prepared this package at > https://bugzilla.redhat.com/show_bug.cgi?id=1077956, made it ready for > review, and marked it as blocking this review. You generally don't have to care about dependencies of scripts packages in the docs. Of course it's nice when you can actually run them on Fedora, they're still just examples/documentation. I've removed the blocker. > FIX: Given the copyright headers in all the source files, I think the > License tag should be corrected to `GPLv2+'. > > Done Check. > Also, is libXi-devel really required? I don't see its headers used anywhere. > > This is where X11/extensions/XInput.h exists in EL6. Note the successful > koji build at > > http://koji.fedoraproject.org/koji/taskinfo?taskID=6648210 > > vs the one with libXi-devel not present at > > http://koji.fedoraproject.org/koji/taskinfo?taskID=6648242 > > I have added a comment explaining this into the spec file Oh yes, I grep'd the sources for XInput but couldn't see it used anywhere. Apparently it's pulled in via XTest.h. I think libXtst-devel should require that. Feel free to report a bug :) Of course we'll need the dependency for now... I'm approving the package now.
New Package SCM Request ======================= Package Name: perl-X11-GUITest Short Description: Provides GUI testing/interaction routines Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig
Git done (by process-git-requests).
perl-X11-GUITest-0.28-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-X11-GUITest-0.28-1.el6
perl-X11-GUITest-0.28-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-X11-GUITest-0.28-1.fc20
perl-X11-GUITest-0.28-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
perl-X11-GUITest-0.28-1.fc20 has been pushed to the Fedora 20 stable repository.
perl-X11-GUITest-0.28-1.el6 has been pushed to the Fedora EPEL 6 stable repository.