Bug 1074268 - Review Request: perl-Hijk - Specialized HTTP client
Summary: Review Request: perl-Hijk - Specialized HTTP client
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-09 10:40 UTC by Emmanuel Seyman
Modified: 2014-03-22 14:55 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-22 14:55:26 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2014-03-09 10:40:06 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk-0.12-1.fc20.src.rpm

Description:
Hijk is a specialized HTTP Client that does nothing but transport the
response body back. It does not feature as a "user agent", but as a dumb
client. It is suitable for connecting to data servers transporting via HTTP
rather then web servers.

Fedora Account System Username: eseyman

Comment 1 David Dick 2014-03-14 09:48:43 UTC
Items marked as TODO are optional but recommended fixes; FIX are review blockers.

TODO: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines notes that the MIT license requires the license file itself to be included in a distribution of the package.  The MIT license file is not included in the package.  Please co-ordinate with upstream to correct this.
TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 34.
TODO: Remove META.json and cpanfile from %doc; these files are of no use to the end users, line 45

Dependencies:
You'll need to BuildRequire all the use'd and require'd modules to prevent possible future build failures caused by buildroot change

FIX: BR perl
FIX: BR perl(File::Temp)
FIX: BR perl(strict)
FIX: BR perl(warnings)
FIX: BR perl(FindBin)
FIX: BR perl(Fcntl)
FIX: BR perl(Socket)
FIX: BR perl(POSIX)
FIX: BR perl(URI::Escape)
FIX: BR perl(Cwd)
FIX: BR perl(Carp)
FIX: BR perl(vars)
FIX: BR perl(Config)
FIX: BR perl(base)
FIX: BR perl(File::Find)
FIX: BR perl(File::Path)
FIX: BR perl(Plack::Runner)

FIX: Drop the Plack BR, it is not use'd or require'd.

Comment 2 Emmanuel Seyman 2014-03-14 22:50:32 UTC
(In reply to David Dick from comment #1)
>
> TODO: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines notes
> that the MIT license requires the license file itself to be included in a
> distribution of the package.  The MIT license file is not included in the
> package.  Please co-ordinate with upstream to correct this.

Indeed. I've filed bug #93868 on rt.cpan.org, asking the author to include
the text of the MIT license with the tarball.

> TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 34.

Done.

> TODO: Remove META.json and cpanfile from %doc; these files are of no use to
> the end users, line 45

Agreed. Done.

> Dependencies:
> You'll need to BuildRequire all the use'd and require'd modules to prevent
> possible future build failures caused by buildroot change
> 
> FIX: BR perl

I have to admit that putting perl as a BR seems a little strange.
Nevertheless, I've included it.

> FIX: BR perl(File::Temp)
> FIX: BR perl(strict)
> FIX: BR perl(warnings)
> FIX: BR perl(FindBin)
> FIX: BR perl(Fcntl)
> FIX: BR perl(Socket)
> FIX: BR perl(POSIX)
> FIX: BR perl(URI::Escape)
> FIX: BR perl(Cwd)
> FIX: BR perl(Carp)
> FIX: BR perl(vars)
> FIX: BR perl(Config)
> FIX: BR perl(base)
> FIX: BR perl(File::Find)
> FIX: BR perl(File::Path)
> FIX: BR perl(Plack::Runner)

Added.

> FIX: Drop the Plack BR, it is not use'd or require'd.

Removed.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Hijk/perl-Hijk-0.12-2.fc20.src.rpm

Comment 3 David Dick 2014-03-14 23:15:28 UTC
Missing BR perl.

Comment 5 David Dick 2014-03-14 23:53:25 UTC
Looks fine apart from the missing license.  As per https://fedoraproject.org/wiki/Packaging:LicensingGuidelines, we'll give upstream a chance to provide the full text of the license.  The package looks to be in a maintained state, so hopefully the bug will be fixed soon.  It might be worth mentioning in the rt bug that the reason for the licensing bug is to package the module for Fedora.  This could encourage the maintainer to fix the bug quickly.

Comment 6 Emmanuel Seyman 2014-03-16 11:27:34 UTC
Thanks, David.

New Package SCM Request
=======================
Package Name: perl-Hijk
Short Description: Specialized HTTP client
Owners: eseyman
Branches: f20
InitialCC: perl-sig

Comment 7 Emmanuel Seyman 2014-03-16 11:29:13 UTC
David, is there a reason you cleared the fedora-review flag?

Comment 8 David Dick 2014-03-17 06:33:17 UTC
yeah,  this is my first review. :)

i've thought about the licensing issue.  I think it's safe to use the license link on  http://search.cpan.org/~avar/Hijk-0.12/, which points to http://www.opensource.org/licenses/mit-license.php as the "source file" for the license.

to finish the review, put the content of this file, namely 

-------------
The MIT License (MIT)

Copyright (c) <year> <copyright holders>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
--------------

into a file called LICENSE.txt (or equivalent) and then you can release it.

package APPROVED!

Comment 9 Gwyn Ciesla 2014-03-17 11:51:24 UTC
Git done (by process-git-requests).

Comment 10 Emmanuel Seyman 2014-03-22 14:55:26 UTC
Included in rawhide, released as an update for F20.


Note You need to log in before you can comment on or make changes to this bug.