Spec URL: http://jamielinux.fedorapeople.org/supertest/nodejs-supertest.spec SRPM URL: http://jamielinux.fedorapeople.org/supertest/SRPMS/nodejs-supertest-0.9.0-1.fc21.src.rpm Fedora Account System Username: jamielinux Description: This module provides a high-level abstraction for testing HTTP servers, while still allowing you to drop down to the lower-level API provided by superagent.
All tests pass with npm installed express.0.
I will take(attempt) this.
(In reply to Mukundan Ragavan from comment #2) > I will take(attempt) this. Thanks! Bear in mind that this review cannot be completed until all of it's dependencies have also been reviewed.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ---> Dependency problem. I will check this manually. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. ---> License is mentioned in the last sentence in Readme.md [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. ---> Checking after installing dependencies manually. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint ---> Checking this manually. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.1.36 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.36 INFO: Mock Version: 1.1.36 Start: lock buildroot INFO: installing package(s): /home/mukundan/personal/pkgs/reviews/1074420-nodejs-supertest/results/nodejs-supertest-0.9.0-1.fc21.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '21', 'install', '/home/mukundan/personal/pkgs/reviews/1074420-nodejs-supertest/results/nodejs-supertest-0.9.0-1.fc21.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: nodejs-supertest-0.9.0-1.fc21.noarch (/nodejs-supertest-0.9.0-1.fc21.noarch) Requires: npm(superagent) >= 0.17.0 You could try using --skip-broken to work around the problem Error: Package: nodejs-supertest-0.9.0-1.fc21.noarch (/nodejs-supertest-0.9.0-1.fc21.noarch) Requires: npm(superagent) < 0.18 You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: nodejs-supertest-0.9.0-1.fc21.noarch.rpm nodejs-supertest-0.9.0-1.fc21.src.rpm nodejs-supertest.noarch: W: only-non-binary-in-usr-lib nodejs-supertest.noarch: W: dangling-symlink /usr/lib/node_modules/supertest/node_modules/methods /usr/lib/node_modules/methods nodejs-supertest.noarch: W: dangling-symlink /usr/lib/node_modules/supertest/node_modules/superagent /usr/lib/node_modules/superagent nodejs-supertest.src: W: spelling-error Summary(en_US) superagent -> super agent, super-agent, superannuate nodejs-supertest.src: W: spelling-error %description -l en_US superagent -> super agent, super-agent, superannuate 2 packages and 0 specfiles checked; 0 errors, 5 warnings. ---> All fine here Requires -------- nodejs-supertest (rpmlib, GLIBC filtered): nodejs(engine) npm(methods) npm(superagent) Provides -------- nodejs-supertest: nodejs-supertest npm(supertest) Source checksums ---------------- http://registry.npmjs.org/supertest/-/supertest-0.9.0.tgz : CHECKSUM(SHA256) this package : 0adb38dc3faeb5f433aff47541edaf54fcc07a329f036601792df1f20136e8bb CHECKSUM(SHA256) upstream package : 0adb38dc3faeb5f433aff47541edaf54fcc07a329f036601792df1f20136e8bb https://raw.github.com/visionmedia/supertest/3768ac43bf9c25c38caac6f3c3d0f460862da003/LICENSE : CHECKSUM(SHA256) this package : d884d6b756d6b2b43c9d0dfa00c330703b268ab10d8416877ecf5758556ef058 CHECKSUM(SHA256) upstream package : d884d6b756d6b2b43c9d0dfa00c330703b268ab10d8416877ecf5758556ef058 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1074420 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
$ rpm -qa nodejs* | sort nodejs-0.10.26-1.fc21.x86_64 nodejs-component-emitter-1.1.2-1.fc21.noarch nodejs-cookiejar-1.3.1-1.fc21.noarch nodejs-debug-0.7.4-2.fc21.noarch nodejs-formidable-1.0.14-3.fc20.noarch nodejs-methods-0.1.0-1.fc21.noarch nodejs-mime-1.2.11-1.fc21.noarch nodejs-qs-0.6.6-1.fc21.noarch nodejs-reduce-component-1.0.1-1.fc21.noarch nodejs-superagent-0.17.0-4.fc21.noarch nodejs-supertest-0.9.0-1.fc21.noarch Looks good to me here. $ rpmlint nodejs-supertest nodejs-supertest.noarch: W: only-non-binary-in-usr-lib nodejs-supertest.noarch: W: dangling-symlink /usr/lib/node_modules/supertest/node_modules/methods /usr/lib/node_modules/methods nodejs-supertest.noarch: W: dangling-symlink /usr/lib/node_modules/supertest/node_modules/superagent /usr/lib/node_modules/superagent 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Everything looks fine to me. Package APPROVED.
New Package SCM Request ======================= Package Name: nodejs-supertest Short Description: A superagent driven library for testing HTTP servers Owners: jamielinux patches Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).
http://koji.fedoraproject.org/koji/buildinfo?buildID=505685