Bug 1074488 - enable tokudb for x86_64
Summary: enable tokudb for x86_64
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: mariadb
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Honza Horak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1149660
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-10 11:15 UTC by Fabrice Bellet
Modified: 2015-06-30 00:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-30 00:56:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Correctly compile TokuDB support for MariaDB (1.24 KB, patch)
2015-02-24 04:57 UTC, Michael Hampton
no flags Details | Diff
Correctly compile TokuDB support for MariaDB (1.23 KB, patch)
2015-02-24 05:08 UTC, Michael Hampton
no flags Details | Diff
Correctly compile TokuDB support for MariaDB (1.20 KB, patch)
2015-04-26 08:12 UTC, Michael Hampton
no flags Details | Diff

Description Fabrice Bellet 2014-03-10 11:15:01 UTC
Would it be possible to enable tokudb for the x86_64 build ?

Comment 1 Honza Horak 2014-03-10 13:24:48 UTC
Well, I think it should be possible, since it shouldn't influence another functionality. Will try to do in the next update.

Comment 2 Fabrice Bellet 2014-03-10 14:23:20 UTC
Great, thanks! In my own local build of 5.5.36 with tokudb enabled, in rawhide, I also have to remove -Werror from cmake c/c++ flags in mariadb-5.5.36/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake, because of a deprecation warning, and in F-20, the build completes successfully, but I have disabled the selftest suite.

Comment 3 Honza Horak 2014-07-17 11:36:37 UTC
The plan was to enable it for mariadb-10.0.x in Fedora 21, but it doesn't build fine, even on x86_64 -- I've reported the FTBFS issue to upstream:
https://mariadb.atlassian.net/browse/MDEV-6446

However, I don't give this issue much priority, so feel free to elaborate more. Otherwise, we will enable TokuDB later, as soon as it builds fine.

Comment 4 Peter Laursen 2014-12-09 13:50:10 UTC
Should build now according to https://bugzilla.redhat.com/show_bug.cgi?id=1149660

Comment 5 Michael Hampton 2015-02-23 22:49:45 UTC
It appears the necessary patch for binutils has landed in F21. Can this be completed now? If not, what else remains to be done?

Comment 6 Michael Hampton 2015-02-24 04:57:14 UTC
Created attachment 994573 [details]
Correctly compile TokuDB support for MariaDB

After poking around on Koji I found that a build of mariadb had been done with TokuDB support, but it was broken. That server (10.0.16-4) failed to start with the error message:

150223 23:01:26 [ERROR] TokuDB is not initialized because jemalloc is not loaded

While TokuDB requires jemalloc to function, it appears that somehow the build (10.0.16-4) had been done without jemalloc. This should not have happened; upstream should have refused to finish compilation, or better yet, configuration without a required component.

The attached patch corrects the spec and includes jemalloc when tokudb support is requested with with_tokudb.

I've run a test build of this locally and deployed it, and TokuDB appears to be working properly.

Comment 7 Michael Hampton 2015-02-24 05:08:11 UTC
Created attachment 994574 [details]
Correctly compile TokuDB support for MariaDB

Oops, there was a stray } character left in the previous version of this patch (that affected builds without TokuDB). This patch corrects the issue.

Comment 8 Michael Hampton 2015-04-26 08:12:38 UTC
Created attachment 1018953 [details]
Correctly compile TokuDB support for MariaDB

Another somewhat cleaner version of this patch, against 10.0.0.17-2.

I'm not sure why this hasn't been fixed yet. I just upgraded from my fixed 10.0.0.16 build (see above comments) and was shocked to discover MariaDB not starting, again.

Comment 9 Fedora End Of Life 2015-05-29 11:12:47 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Michael Hampton 2015-05-29 14:25:58 UTC
Nope nope nope. This remains a problem in F22. And I don't understand why this isn't fixed yet since a working patch has been available right here on this bug for months now.

Comment 11 Fedora End Of Life 2015-06-30 00:56:24 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 12 Michael Hampton 2015-06-30 00:57:51 UTC
I don't think so! This is still unfixed in F21 and F22 (despite a patch being available right above!)


Note You need to log in before you can comment on or make changes to this bug.