Bug 1074919 - set version based on git tag or specific
Summary: set version based on git tag or specific
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Bala.FA
QA Contact:
URL:
Whiteboard:
Depends On: 1086985
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-11 08:59 UTC by Bala.FA
Modified: 2015-11-23 02:58 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of:
Environment:
Last Closed: 2014-11-11 08:28:32 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Bala.FA 2014-03-11 08:59:05 UTC
Cureently glusterfs sets fixed version/release number for any branch.  When working with upstream/master, we get fixed version/release numbers for each build which confuses when look back from build to source.

We would need

1) using 'git describe' to find out version dynamically
2) by providing ability to have fixed version/release which helps for release branch.

Comment 1 Anand Avati 2014-03-11 09:34:34 UTC
REVIEW: http://review.gluster.org/7164 (build: set version based on git tag or specific) posted (#4) for review on master by Bala FA (barumuga)

Comment 2 Anand Avati 2014-03-18 11:12:14 UTC
REVIEW: http://review.gluster.org/7164 (build: set version based on git tag or specific) posted (#5) for review on master by Bala FA (barumuga)

Comment 3 Anand Avati 2014-03-26 05:53:55 UTC
REVIEW: http://review.gluster.org/7164 (build: set version based on git tag or specific) posted (#6) for review on master by Bala FA (barumuga)

Comment 4 Anand Avati 2014-04-02 05:30:36 UTC
REVIEW: http://review.gluster.org/7164 (build: set version based on git tag or specific) posted (#7) for review on master by Bala FA (barumuga)

Comment 5 Anand Avati 2014-04-07 05:25:06 UTC
REVIEW: http://review.gluster.org/7164 (build: set version based on git tag or specific) posted (#8) for review on master by Bala FA (barumuga)

Comment 6 Anand Avati 2014-04-10 11:52:35 UTC
COMMIT: http://review.gluster.org/7164 committed in master by Vijay Bellur (vbellur) 
------
commit 4bacb40fc898ee9519cfe4e9ee50401ec466168c
Author: Bala.FA <barumuga>
Date:   Thu Feb 27 12:39:43 2014 +0530

    build: set version based on git tag or specific
    
    This patch brings version and release number generated at build time
    using git tags or fixed content from VERSION file.
    
    With git tag, version/release number are got from output of
    'git describe --tags --match "v[0-9]*"' command.
    
    This behavior can be overriden by having VERSION file with fixed
    version/release.  The VERSION file should have text describing version
    and release for example something like 'v3.4.0-1'
    
    For testing this patch, its required to remove autom4te.cache
    directory to avoid seeing previously set version.
    
    BUG: 1074919
    Change-Id: I8f68172e8b389b0ba0846e9adb4b597e67a909aa
    Signed-off-by: Bala.FA <barumuga>
    Reviewed-on: http://review.gluster.org/7164
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 7 Anand Avati 2014-04-10 17:57:12 UTC
REVIEW: http://review.gluster.org/7439 (pkg-version: Use /bin/bash instead of /bin/sh) posted (#1) for review on master by Harshavardhana (harsha)

Comment 8 Anand Avati 2014-04-12 14:59:38 UTC
COMMIT: http://review.gluster.org/7439 committed in master by Vijay Bellur (vbellur) 
------
commit 493e7c1934e65f5b7de5e710528f503e083c49e4
Author: Harshavardhana <harsha>
Date:   Thu Apr 10 10:54:01 2014 -0700

    pkg-version: Use /bin/bash instead of /bin/sh
    
    `function` is reserved word only available in /bin/bash,
    Using `/bin/sh` with `function` keyword fails on Ubuntu.
    
    Change-Id: Ia0fff8f13ace2a0eb1dac50093ff42294d960814
    BUG: 1074919
    Reviewed-on: http://review.gluster.org/7439
    Reviewed-by: Bala FA <barumuga>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 9 Niels de Vos 2014-09-22 12:36:40 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 10 Niels de Vos 2014-11-11 08:28:32 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.