Bug 1074982 - Review Request: erlang-jiffy - Erlang JSON parser
Summary: Review Request: erlang-jiffy - Erlang JSON parser
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-11 10:22 UTC by Lubomir Rintel (GoodData, inactive)
Modified: 2014-03-13 15:40 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-13 14:44:02 UTC
Type: Bug
Embargoed:
filip: fedora-review+


Attachments (Terms of Use)

Description Lubomir Rintel (GoodData, inactive) 2014-03-11 10:22:09 UTC
SPECS: http://v3.sk/~lkundrak/SPECS/jiffy.spec
SRPMS: http://v3.sk/~lkundrak/SRPMS/jiffy-0.8.5-1.el7.src.rpm

Description:

A JSON parser for Erlang implemented as a NIF.

Comment 1 Filip Andres 2014-03-12 13:08:05 UTC
Terrific job, I would just propose some minor tweaks:
* please rename to erlang-jiffy
* please replace libstdc++-devel with gcc-c++
* please replace the git version src/jiffy.app.src with a hardcoded one:

From bcbd50f07a557865a319a161bd1471213fd681f9 Mon Sep 17 00:00:00 2001
From: Maminka <maminka.gooddata.sexy>
Date: Wed, 12 Mar 2014 09:32:04 +0100
Subject: [PATCH] set fix version

---
src/jiffy.app.src |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/jiffy.app.src b/src/jiffy.app.src
index 4ea304a..03cca85 100644
--- a/src/jiffy.app.src
+++ b/src/jiffy.app.src
@@ -1,6 +1,6 @@
{application, jiffy, [
    {description, "JSON Decoder/Encoder."},
-    {vsn, git},
+    {vsn, "0.8.5"},
    {registered, []},
    {applications, [kernel]}
]}.
--
1.7.1

Comment 2 Lubomir Rintel 2014-03-12 14:13:21 UTC
Thank you for your kind review, sir! It's my pleasure to provide you with an improved, updated version, better than ever!

SPECS: http://v3.sk/~lkundrak/SPECS/erlang-jiffy.spec
SRPMS: http://v3.sk/~lkundrak/SRPMS/erlang-jiffy-0.8.5-2.el7.src.rpm

Comment 3 Filip Andres 2014-03-12 14:37:00 UTC
Almost perfect but please set the version in the patch to "0.8.5" so that is matches the package version.

Comment 5 Filip Andres 2014-03-12 14:55:16 UTC
My nipples explode with delight.

Comment 6 Lubomir Rintel 2014-03-12 15:15:10 UTC
New Package SCM Request
=======================
Package Name: erlang-jiffy
Short Description: Erlang JSON parser
Owners: filabrazilska lkundrak
Branches: f19 f20 el6 epel7

Comment 7 Gwyn Ciesla 2014-03-12 17:28:47 UTC
Git done (by process-git-requests).

Comment 8 Peter Lemenkov 2014-03-13 14:31:58 UTC
(In reply to Lubomir Rintel from comment #6)
> New Package SCM Request
> =======================
> Package Name: erlang-jiffy
> Short Description: Erlang JSON parser
> Owners: filabrazilska lkundrak
> Branches: f19 f20 el6 epel7

Lubo, could you please raise fedora-cvs again and add this address to CC list - erlang-sig ?

Comment 9 Lubomir Rintel 2014-03-13 14:44:02 UTC
Package Change Request
======================
Package Name: erlang-jiffy
InitialCC: erlang-sig

Comment 10 Gwyn Ciesla 2014-03-13 15:40:29 UTC
Complete.


Note You need to log in before you can comment on or make changes to this bug.