RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1074992 - qcow2 loses driver-specific options during migration
Summary: qcow2 loses driver-specific options during migration
Keywords:
Status: CLOSED DUPLICATE of bug 1048575
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: qemu-kvm
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Kevin Wolf
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-11 10:41 UTC by Kevin Wolf
Modified: 2014-07-15 13:31 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-15 13:31:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Kevin Wolf 2014-03-11 10:41:46 UTC
qemu does correctly parse the given options when adding a new block device or on
startup (i.e. during bdrv_open). However, after a migration is completed, the
qcow2 layer is reopened in order to refresh stale metadata, and on this occasion
we're losing most driver-specific options.

Most of the options are hard to directly observe, so I used gdb to verify this
behaviour.

$ gdb --args x86_64-softmmu/qemu-system-x86_64 -drive file=/tmp/test.qcow2,overlap-check=none
(gdb) run
<press ctrl-c>
(gdb) p ({struct BDRVQcow2State}bdrv_states .tqh_first .opaque).overlap_check 
$1 = 0

So we get no overlap checks indeed. Start up another instance with the same
options, but additionally with -incoming. You can do the same check, and it
will return 0 again.

Now migrate to the second instance and after migration has completed, press
ctrl-c and do the check another time:

(gdb) p ({struct BDRVQcow2State}bdrv_states .tqh_first .opaque).overlap_check
$2 = 127

This is wrong, it should still be 0 instead of the default value of 127.


Options affected in qcow2 are (from source inspection):
* pass-discard-request
* pass-discard-snapshot
* pass-discard-other
* overlap-check
* overlap-check.main-header
* overlap-check.active-l1
* overlap-check.active-l2
* overlap-check.refcount-table
* overlap-check.refcount-block
* overlap-check.snapshot-table
* overlap-check.inactive-l1
* overlap-check.inactive-l2

Comment 2 RHEL Program Management 2014-03-22 05:49:17 UTC
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

Comment 3 Kevin Wolf 2014-07-15 13:31:46 UTC
This was already fixed as part of the solution for bug 1048575. Committed as
ac25e461 in qemu-kvm-rhel7 ('qcow2: Keep option in qcow2_invalidate_cache()').

*** This bug has been marked as a duplicate of bug 1048575 ***


Note You need to log in before you can comment on or make changes to this bug.