Spec URL: http://jamielinux.fedorapeople.org/connect/nodejs-compressible.spec SRPM URL: http://jamielinux.fedorapeople.org/connect/SRPMS/nodejs-compressible-1.0.0-1.fc21.src.rpm Fedora Account System Username: jamielinux Description: Compressible Content-Type/MIME checking for Node.js.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-compressible-1.0.0-1.fc21.noarch.rpm nodejs-compressible-1.0.0-1.fc21.src.rpm nodejs-compressible.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-compressible.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-compressible.noarch: W: only-non-binary-in-usr-lib nodejs-compressible.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-compressible.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-compressible nodejs-compressible.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-compressible.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-compressible.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-compressible (rpmlib, GLIBC filtered): nodejs(engine) Provides -------- nodejs-compressible: nodejs-compressible npm(compressible) Source checksums ---------------- http://registry.npmjs.org/compressible/-/compressible-1.0.0.tgz : CHECKSUM(SHA256) this package : 0b82fb386e3811f93a59e1f57acf309c15f120dec5cc65c3dc29f7172e59007a CHECKSUM(SHA256) upstream package : 0b82fb386e3811f93a59e1f57acf309c15f120dec5cc65c3dc29f7172e59007a Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1075017 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
The only thing I can see is that I wonder if specification.json should be in %{_datadir} or not?
(In reply to Tom Hughes from comment #2) > The only thing I can see is that I wonder if specification.json should be in > %{_datadir} or not? Hmmm. I suppose if you take the Node.js guidelines in the most literal way then it should go in %{_datadir} since it's not technically JavaScript code (though pretty darn close). I'll move it to datadir until I get clarification from T.C. Spec URL: http://jamielinux.fedorapeople.org/connect/nodejs-compressible.spec SRPM URL: http://jamielinux.fedorapeople.org/connect/SRPMS/nodejs-compressible-1.0.0-2.fc21.src.rpm * Wed Mar 12 2014 Jamie Nguyen <jamielinux> - 1.0.0-2 - move specifications.json to {_datadir}
Great. Pacage approved then.
New Package SCM Request ======================= Package Name: nodejs-compressible Short Description: Compressible Content-Type/MIME checking for Node.js Owners: jamielinux patches Branches: f19 f20 el6 InitialCC:
Git done (by process-git-requests).