Bug 1075070 - [ PATCH ] - Enable tests in %check
Summary: [ PATCH ] - Enable tests in %check
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-lxml
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-11 12:28 UTC by Alexander Todorov
Modified: 2018-11-19 17:21 UTC (History)
2 users (show)

Fixed In Version: python-lxml-3.3.3-4.fc20
Clone Of:
Environment:
Last Closed: 2014-03-21 09:33:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
PATCH (720 bytes, patch)
2014-03-11 12:28 UTC, Alexander Todorov
no flags Details | Diff
Adds BuildRequires: python-cssselect (443 bytes, patch)
2014-03-12 10:31 UTC, Alexander Todorov
no flags Details | Diff

Description Alexander Todorov 2014-03-11 12:28:12 UTC
Created attachment 873100 [details]
PATCH

Description of problem:
Enable running of the test suite in %check

Version-Release number of selected component (if applicable):
python-lxml-3.3.2-1.fc21.src.rpm


Additional info:

NB: The test suite modifies Python's sys.path and for some reason it is not possible to execute (can't find etree module) unless the .so files are copied under src/lxml which is what we do.

Comment 1 Fedora Update System 2014-03-11 15:44:14 UTC
python-lxml-3.3.3-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-lxml-3.3.3-1.fc20

Comment 2 Fedora Update System 2014-03-11 15:44:47 UTC
python-lxml-3.3.3-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-lxml-3.3.3-1.fc19

Comment 3 Alexander Todorov 2014-03-12 10:31:19 UTC
Created attachment 873425 [details]
Adds BuildRequires:  python-cssselect

From 
http://kojipkgs.fedoraproject.org//packages/python-lxml/3.3.3/1.fc21/data/logs/i686/build.log

Skipping tests in lxml.cssselect - external cssselect package is not installed


The attached patch adds BuildRequires:  python-cssselect for both Python 2 and 3 which unlocks a few more tests to be run. 

apply it on top of python-lxml-3.3.3-1.fc21

Comment 4 Alexander Todorov 2014-03-12 10:32:58 UTC
Jeffrey,
I see that the spec file has Requires: python-cssselect only for Python2 and not for Python3. Is this intentional? 

I think it needs to add Requires: python3-cssselect as well. How do you want to handle it?

Comment 5 Fedora Update System 2014-03-12 12:21:05 UTC
Package python-lxml-3.3.3-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-lxml-3.3.3-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-3745/python-lxml-3.3.3-1.fc19
then log in and leave karma (feedback).

Comment 6 Alexander Todorov 2014-03-13 14:36:35 UTC
(In reply to Fedora Update System from comment #5)
> Package python-lxml-3.3.3-1.fc19:


NB: ^^^ doesn't take into account comment #3 and comment #4.

Comment 7 Fedora Update System 2014-03-21 09:33:21 UTC
python-lxml-3.3.3-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2014-03-21 09:36:48 UTC
python-lxml-3.3.3-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2014-03-24 15:58:01 UTC
python-lxml-3.3.3-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-lxml-3.3.3-2.fc20

Comment 10 Fedora Update System 2014-03-27 18:18:51 UTC
python-lxml-3.3.3-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-lxml-3.3.3-4.fc20

Comment 11 Fedora Update System 2014-04-15 15:28:03 UTC
python-lxml-3.3.3-4.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.