Bug 1075211

Description of problem:

There is a problem in setting the custom values for baselines in Resource Measurements. If user tries to change the value of "Baseline - Max" in the measurement graph, the value is not changed and the error message "Custom user baseline high was not saved." is logged in Message center with no further explanation.

I can only see this problem in measurements for metrics regarding "data unit" on y-axis (GB, MB, etc) e.g. "Actual Free Memory", "Actual Used Memory" etc. For other measurements like "System Load" or "User Load" which use different unit for y-axis this bug does not apply.

Version-Release number of selected component (if applicable):
JON 3.2.1 DR2 (Build Number : d18651a:f535707)


How reproducible:
always

Steps to Reproduce:
1. Install JON server
2. Go to Inventory -> Platforms and select server platform
3. In Summary tab choose some measurement in "Resources: Measurements" section, for instance "Free Memory"
4. Try to change the value of "Baseline - High"

Actual results:
the value is not changed end error message is logged in Message center

Expected results:
No error message is logged and the value is changed

Additional info:

If you first change the value of "Baslines - Min" and then "Baselines - Max", it works.

Issue still visible in JON 3.2.3 ER and JON 3.3.0 ER. When trying to change the baseline (max) value the server logs either 'java.lang.IllegalArgumentException: One of the params to MeasurementDataGWTServiceImpl.setUserBaselineMax is null' exception (http://pastebin.test.redhat.com/228232) or java.lang.NullPointerException (http://pastebin.test.redhat.com/228231).

This only happens when there is no baseline for the metric schedule, just after import generally.  It's rare because an initial baseline should be generated the next time the DataCalcJob runs, typically at the top of the hour.

So I don't think the priority is super high.  Still, let me look to see if it's an easy fix...

master commit 0283ae950adb75367834266378b18006ce47bb51
Author: Jay Shaughnessy <jshaughn>
Date:   Wed Aug 20 12:38:09 2014 -0400

    This really only is a problem when there is not yet a baseline.  Which is
    rare and typically just between import and the next run of the DataCalcJob
    It's not really easy to generate a manually set baseline from scratch, so
    I'm just taking the approach of better messaging and error handling:
    - Fix error handling such that the root cause of the issue is displayed
      when the save fails.
    - provide better error handling and provide more specific messaging
    - remove the confusing refresh icon (which was sort of acting like a save
      option. So, just hitting return is the way to save.
    - Hide the edit box when saving.
    - protect against GeneralUnhandledException when saving without setting a
      value.



release/jon3.3.x commit 310eccc41fc23247e6fd2f458fb888c88e84d20a
Author: Jay Shaughnessy <jshaughn>
Date:   Wed Aug 20 12:40:21 2014 -0400

    Cherry-Pick master 351ab615a83988fda4780df4461d621372eb135a

Moving to ON_QA as available for test with the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=381194

Moving to VERIFIED.

If there is no a baseline generated yet and I attempt to set the baseline manually, the exception wit error message "A baseline has not yet been generated for this metric..." is logged.

If there are baslines already generated, it is possible to change all high, low and mean values.

However the issue described here: BZ 1075217 is still visible and makes it really confusing to insert a proper value because the numeric value in 'change value' text field does not reflect on the current data unit (B, kB, MB, etc).

Version:3.3.0.ER02
Build Number:4fbb183:7da54e2