RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1075299 - Failed to get the vol-name by giving volume path in gluster pool.
Summary: Failed to get the vol-name by giving volume path in gluster pool.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.0
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-12 03:29 UTC by chhu
Modified: 2015-03-05 07:31 UTC (History)
9 users (show)

Fixed In Version: libvirt-1.2.7-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 07:31:20 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description chhu 2014-03-12 03:29:03 UTC 
Description of problem:
Failed to get the vol-name by giving volume path in gluster pool

Version-Release number of selected component (if applicable):
libvirt-1.1.1-26.el7.x86_64
qemu-kvm-rhev-1.5.3-50.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. start a gluster pool with xml below:
# more pool-gluster.xml
<pool type='gluster'>
  <source>
    <host name='10.66.84.12'/>
    <name>gluster-vol1</name>
    <dir path='/'/>
  </source>
  <name>gluster-vol1</name>
</pool>

# virsh pool-create pool-gluster.xml
Pool gluster-vol1 created from pool-gluster.xml

2. list the volumes in the gluster pool
# virsh vol-list gluster-vol1
Name                 Path                                    
-----------------------------------------
r7g-qcow2.img        gluster://10.66.84.12/gluster-vol1/r7g-qcow2.img
......

3. get the vol-path, vol-key
# virsh vol-path r7g-qcow2.img --pool gluster-vol1
gluster://10.66.84.12/gluster-vol1/r7g-qcow2.img

# virsh vol-key r7g-qcow2.img --pool gluster-vol1
gluster-vol1/r7g-qcow2.img

4. get the vol-name by giving the vol-path failed.
# virsh vol-name gluster://10.66.84.12/gluster-vol1/r7g-qcow2.img
error: failed to get vol 'gluster://10.66.84.12/gluster-vol1/r7g-qcow2.img'
error: Storage volume not found: no storage vol with matching path gluster://10.66.84.12/gluster-vol1/r7g-qcow2.img

5. get the vol-name by giving the vol-key succeed.
# virsh vol-name gluster-vol1/r7g-qcow2.img
r7g-qcow2.img

Actual results:
In step4, failed to get the vol-name by giving the vol-path.

Expected results:
In step4, succeed to get the vol-name by giving the vol-path.
Comment 1 Peter Krempa 2014-03-12 07:48:38 UTC 
Already fixed upstream:

commit 7fb3902b0f6649c6d919566bff2c8ec0dd83d2d6
Author: Peter Krempa <pkrempa>
Date:   Tue Feb 25 15:51:15 2014 +0100

    storage: Avoid mangling paths of non-local filesystems when looking up
    
    When looking up a volume by path on a non-local filesystem don't use the
    "cleaned" path that might be mangled in such a way that it will differ
    from a path provided by a storage backend.
    
    Skip the cleanup step for gluster, sheepdog and RBD.
Comment 2 Yang Yang 2014-05-07 03:28:33 UTC 
The same issue was hit by virsh command vol-pool. Failed to get the pool name by virsh cmd vol-pool passing a volume path in glusterfs pool.

# virsh vol-name gluster://10.66.84.12/gluster-vol1/r7g-qcow2.img
error: failed to get vol 'luster://10.66.84.12/gluster-vol1/r7g-qcow2.img'
error: Storage volume not found: no storage vol with matching path luster://10.66.84.12/gluster-vol1/r7g-qcow2.img
Comment 5 Pei Zhang 2014-12-01 03:49:23 UTC 
verify version:
libvirt-1.2.8-9.el7.x86_64
qemu-kvm-rhev-2.1.2-13.el7.x86_64
kernel-3.10.0-211.el7.x86_64

steps:

There are several patches in the bug, will verify this bug with each patch.

1>Verify patch "virsh: volume: Fix lookup of volumes to provide better error messages"

1.1 test for exsit inactive pool
# virsh vol-upload --pool disk-pool --vol somevol local-file
error: pool 'disk-pool' is not active

1.2 test for non-exsit pool
# virsh vol-upload --pool upload-pool --vol somevol local-file
error: failed to get pool 'upload-pool'
error: Storage pool not found: no storage pool with matching name 'upload-pool'

2>Verify patch "Error out when attempting to vol-upload into a remote pool"

2.1 prepare a gluster pool and create a volume in the gluster type pool
# virsh pool-list gluster
 Name                 State      Autostart
-------------------------------------------
 gluster-pool         active     no        

# virsh vol-list gluster-pool
 Name                 Path                                    
------------------------------------------------------------------------------
 gluster.img          gluster://server-ip/gluster-vol1/gluster.img

2.2 vol-upload gluster type pool
# virsh vol-upload --pool gluster-pool --vol gluster.img volume-as-disk.xml
error: cannot upload to volume gluster.img
error: this function is not supported by the connection driver: storage pool doesn't support volume upload

2.3 vol-upload netfs type pool , upload successfully.
# virsh pool-list netfs
 Name                 State      Autostart 
-------------------------------------------
 netfs-nfs-pool       active     no  

upload local file disk-pool.xml contents to vol disk.xml in the netfs pool.

# virsh vol-upload --pool netfs-nfs-pool --vol disk.xml  disk-pool.xml 

# virsh vol-list netfs-nfs-pool
 Name                 Path                                    
------------------------------------------------------------------------------
 disk.xml             /var/lib/libvirt/images/netfs-nfs/disk.xml

upload successfully ,in the netfs-nfs-pool , check the uploaded file
# cat disk.xml 
<pool type='disk'>
<name>disk-pool</name>
<capacity unit='bytes'>211244736512</capacity>
<allocation unit='bytes'>35093630976</allocation>
<available unit='bytes'>176151105536</available>
<source>
<device path='/dev/sdb'/>
<format type='12345'/>
</source>
<target>
<path>/var/lib/libvirt/images/disk-pool</path>
<permissions>
<mode>0755</mode>
<owner>0</owner>
<group>0</group>
</permissions>
</target>
</pool>
   <owner>-1</owner>
      <group>-1</group>
    </permissions>
  </target>
</pool>
...........

3>Verify patch "storage: Avoid mangling paths of non-local filesystems when looking up"
get vol-name form vol-path from a gluster pool :

3.1 get vol-path /vol-key from a gluster pool
# virsh vol-path gluster.img --pool gluster-pool
gluster://server-ip/gluster-vol1/gluster.img

# virsh vol-key gluster.img --pool gluster-pool
gluster://server-ip/gluster-vol1/gluster.img

3.2 get vol-name from vol-path , get successfully
# virsh vol-name gluster://server-ip/gluster-vol1/gluster.img
gluster.img

3.3 using invalid volume path
# virsh vol-name gluster://server-ip/gluster-vol1/gluster2.img
error: failed to get vol 'gluster://server-ip/gluster-vol1/gluster2.img'
error: Storage volume not found: no storage vol with matching path 'gluster://server-ip/gluster-vol1/gluster2.img' (gluster:/server-ip/gluster-vol1/gluster2.img)

3.4 for comment2  test vol-pool, successfully get pool name form volume path
# virsh vol-pool gluster://server-ip/gluster-vol1/gluster.img
gluster-pool

4>Verify patch “storage: Don't lie about path used to lookup in error message”
the volume path will not be sanitized.it will be shown in error message as it was .
# virsh vol-name ////dev/disk/by-path/ip-3ffe::104:3260-iscsi-iqn.2008-09.5.165:server.target1-lun-2
error: failed to get vol '////dev/disk/by-path/ip-3ffe::104:3260-iscsi-iqn.2008-09.5.165:server.target1-lun-2'
error: Storage volume not found: no storage vol with matching path '////dev/disk/by-path/ip-3ffe::104:3260-iscsi-iqn.2008-09.5.165:server.target1-lun-2' (/dev/disk/by-path/ip-3ffe::104:3260-iscsi-iqn.2008-09.5.165:server.target1-lun-2)

5>Verify patch doc: storage: Explicitly state that it's possible to have non-unique key

check http://libvirt.org/formatstorage.html
......
key
    Providing an identifier for the volume which identifies a single volume. In some cases it's possible to have two distinct keys identifying a single volume. This field cannot be set when creating a volume: it is always generated.
...... 

6>Verify patch "gluster: Fix "key" attribute for gluster volumes"
the key is as same as the path for gluster volumes

# virsh vol-path gluster.img --pool gluster-pool
gluster://server-ip/gluster-vol1/gluster.img

# virsh vol-key gluster.img --pool gluster-pool
gluster://server-ip/gluster-vol1/gluster.img

# virsh vol-dumpxml gluster.img --pool gluster-pool
<volume type='network'>
  <name>gluster.img</name>
  <key>gluster://server-ip/gluster-vol1/gluster.img</key>
........
  <target>
    <path>gluster://server-ip/gluster-vol1/gluster.img</path>
    <format type='qcow2'/>
........
  </target>
</volume>

all the patches can be verified . move this bug to verified.
Comment 7 errata-xmlrpc 2015-03-05 07:31:20 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html
Note You need to log in before you can comment on or make changes to this bug.