Bug 1075417 - Spelling mistakes and typos in the glusterfs source
Summary: Spelling mistakes and typos in the glusterfs source
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: GlusterFS
Classification: Community
Component: unclassified
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL: http://titanpad.com/gluster-misspellings
Whiteboard:
: 1173953 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-12 05:20 UTC by Kaushal
Modified: 2016-01-19 12:20 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-01-19 12:20:11 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
Changing from existant to existent (1.49 KB, patch)
2014-03-15 18:04 UTC, akshata
no flags Details | Diff
spelling changes (21.65 KB, patch)
2014-03-15 18:13 UTC, akshata
no flags Details | Diff

Description Kaushal 2014-03-12 05:20:20 UTC
The GlusterFS source contains a lot of spelling mistakes and typos, which need to be fixed. A list of these has been generated Using the misspell-check tool (https://github.com/lyda/misspell-check). This list is available at http://titanpad.com/gluster-misspellings .

Comment 1 akshata 2014-03-15 18:04:50 UTC
Created attachment 874872 [details]
Changing from existant to existent

I have made four changes in the same file. Changed from existant to existent

Comment 2 akshata 2014-03-15 18:13:17 UTC
Created attachment 874873 [details]
spelling changes

made spelling changes to 19 files

Comment 3 Anand Avati 2014-03-16 02:35:01 UTC
REVIEW: http://review.gluster.org/7279 (fixed a few misspellings. no code changes present) posted (#1) for review on master by Arvind Chembarpu (achembarpu)

Comment 4 Anand Avati 2014-03-16 07:02:56 UTC
REVIEW: http://review.gluster.org/7280 (Made spelling changes to 19 files) posted (#1) for review on master by Akshata Mohan (oxta28)

Comment 5 Anand Avati 2014-03-16 18:57:34 UTC
COMMIT: http://review.gluster.org/7280 committed in master by Anand Avati (avati) 
------
commit 9565ac3328dc91bd721a65b6d4e7957929e9ed59
Author: AkshataDM <oxta28>
Date:   Sat Mar 15 23:33:38 2014 +0530

    Made spelling changes to 19 files
    
    Change-Id: If91cf44578fe0b5176ea01ae5c5962e31606f640
    BUG: 1075417
    Signed-off-by: AkshataDM <oxta28>
    Reviewed-on: http://review.gluster.org/7280
    Reviewed-by: Varun Shastry <vshastry>
    Reviewed-by: Anand Avati <avati>
    Tested-by: Anand Avati <avati>

Comment 6 Anand Avati 2014-03-17 15:24:27 UTC
REVIEW: http://review.gluster.org/7283 (fixed unintented newlines.) posted (#1) for review on master by Arvind Chembarpu (achembarpu)

Comment 7 Anand Avati 2014-03-17 16:03:28 UTC
REVIEW: http://review.gluster.org/7284 (fixed a few misspellings. no code changes present) posted (#1) for review on master by Arvind Chembarpu (achembarpu)

Comment 8 Anand Avati 2014-03-17 16:23:09 UTC
REVIEW: http://review.gluster.org/7283 (fixed a few misspellings. no code changes present) posted (#2) for review on master by Arvind Chembarpu (achembarpu)

Comment 9 Justin Clift 2014-03-17 17:14:04 UTC
As a data point, the cmockery2 typos are fixed upstream here:

  https://github.com/lpabon/cmockery2/pull/2

Comment 10 Anand Avati 2014-03-17 23:13:44 UTC
COMMIT: http://review.gluster.org/7283 committed in master by Anand Avati (avati) 
------
commit d4343f0d192862cb378eac13365bcfde31fa1d37
Author: arvindch <achembarpu>
Date:   Mon Mar 17 20:50:39 2014 +0530

    fixed a few misspellings. no code changes present
    
    Change-Id: Ia1a771301e9f1becbbffd8afd7eb68bec9696ef8
    BUG: 1075417
    Signed-off-by: arvindch <achembarpu>
    Reviewed-on: http://review.gluster.org/7283
    Reviewed-by: Justin Clift <justin>
    Tested-by: Anand Avati <avati>

Comment 11 Niels de Vos 2014-06-06 07:03:44 UTC
The updated list with TODOs is here:
- http://titanpad.com/gluster-misspellings

When you file patches with corrections, make sure to update the list.

Thanks!

Comment 12 Anand Avati 2014-07-08 18:51:20 UTC
REVIEW: http://review.gluster.org/8264 (Typo fixing, no code changes present) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 13 Anand Avati 2014-07-08 19:05:16 UTC
REVIEW: http://review.gluster.org/8265 (Typo fixing, no code changes present) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 14 Anand Avati 2014-07-08 19:28:56 UTC
REVIEW: http://review.gluster.org/8266 (libglusterfs: synclock_destory() has been prototyped in syncop.h, how-ever synclock_destroy() is the actual function used in syncop.c. Correcting this function definition along with few typos.) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 15 Anand Avati 2014-07-08 19:30:38 UTC
REVIEW: http://review.gluster.org/8266 (libglusterfs: wrong function definition of synclock_destory()) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 16 Anand Avati 2014-07-08 19:34:20 UTC
REVIEW: http://review.gluster.org/8265 (Fix typos in nfs server source, no code changes present) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 17 Anand Avati 2014-07-08 19:35:51 UTC
REVIEW: http://review.gluster.org/8264 (doc: Fix typo in stripe xlator src, no code changes present) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 18 Anand Avati 2014-07-08 19:49:25 UTC
REVIEW: http://review.gluster.org/8267 (changelog: variable 'writen' is changed) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 19 Anand Avati 2014-07-08 19:57:05 UTC
REVIEW: http://review.gluster.org/8268 (compress: Change variable name) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 20 Anand Avati 2014-07-09 06:10:13 UTC
REVIEW: http://review.gluster.org/8266 (libglusterfs: wrong function definition of synclock_destory().) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 21 Anand Avati 2014-07-09 06:11:22 UTC
REVIEW: http://review.gluster.org/8264 (doc: Fix typos in stripe xlator src, no code changes present) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 22 Anand Avati 2014-07-09 09:09:20 UTC
REVIEW: http://review.gluster.org/8266 (libglusterfs: wrong function definition of synclock_destory().) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 23 Anand Avati 2014-07-14 14:02:49 UTC
COMMIT: http://review.gluster.org/8267 committed in master by Venky Shankar (vshankar) 
------
commit 25ceba47ffefa8cf9639c4f7ef907d0f2974f7d3
Author: Humble Chirammal <hchiramm>
Date:   Wed Jul 9 01:14:58 2014 +0530

    changelog: variable 'writen' is changed
    
    This patch change the variable name to 'written' in changelog, along
    with few other typo fixing.
    
    Change-Id: I1d3cbea5c89fc0a15233bb6e61b4fbd4bfdd3a67
    BUG: 1075417
    Signed-off-by: Humble Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/8267
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Comment 24 Anand Avati 2014-07-15 11:39:44 UTC
COMMIT: http://review.gluster.org/8268 committed in master by Venky Shankar (vshankar) 
------
commit c74ff569ca40c7484c197d23ec342f8445c09b9c
Author: Humble Chirammal <hchiramm>
Date:   Wed Jul 9 01:22:54 2014 +0530

    compress: Change variable name
    
    'writen' and 'total_writen' variables has been defined in compress
    xlator. This patch replaced those with proper name.
    
    Change-Id: If8e38fae8f997a92686a891d64cbaf6b0b69129a
    BUG: 1075417
    Signed-off-by: Humble Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/8268
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Comment 25 Anand Avati 2014-08-06 08:29:35 UTC
COMMIT: http://review.gluster.org/8266 committed in master by Vijay Bellur (vbellur) 
------
commit 8111756d0f7ff8b7e92cbb4ddb3833f72830e0b3
Author: Humble Chirammal <hchiramm>
Date:   Wed Jul 9 00:54:48 2014 +0530

    libglusterfs: wrong function definition of synclock_destory().
    
    synclock_destory() has been prototyped in syncop.h,
    how-ever synclock_destroy() is the actual function used in syncop.c.
    Correcting this function definition along with few typos.
    
    
    Change-Id: I35a818190c1d37c303279ca7a820f01895751bd9
    BUG: 1075417
    Signed-off-by: Humble Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/8266
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 26 Anand Avati 2014-08-27 05:58:18 UTC
REVIEW: http://review.gluster.org/8265 (gNFS: correct some typos in comments.) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 27 Anand Avati 2014-08-27 07:26:40 UTC
COMMIT: http://review.gluster.org/8265 committed in master by Niels de Vos (ndevos) 
------
commit aa0891b796809e3a932c709e1406298b4d5f0416
Author: Humble Chirammal <hchiramm>
Date:   Wed Jul 9 00:31:57 2014 +0530

    gNFS: correct some typos in comments.
    
    Change-Id: I304c760c2318edd4bab985ca19bf9ce62fd21a3c
    BUG: 1075417
    Signed-off-by: Humble Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/8265
    Reviewed-by: Santosh Pradhan <spradhan>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Niels de Vos <ndevos>

Comment 28 Niels de Vos 2014-11-11 08:28:38 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users

Comment 29 Justin Clift 2014-11-11 17:46:11 UTC
Pretty sure this wasn't completely fixed.  The titanpad list doesn't have everything marked off.

Comment 30 Anand Avati 2014-12-04 16:49:52 UTC
REVIEW: http://review.gluster.org/9238 (Fixed small typo in marker.c) posted (#1) for review on master by Jan-Hendrik Zab (zab)

Comment 31 Anand Avati 2014-12-05 11:24:18 UTC
COMMIT: http://review.gluster.org/9238 committed in master by Vijay Bellur (vbellur) 
------
commit 318df520945a5d618f45a3a3f680e2b39a278375
Author: Jan-Hendrik Zab <zab>
Date:   Thu Dec 4 14:06:15 2014 +0100

    Fixed small typo in marker.c
    
    Change-Id: Iec89e7141f6ff3216355d8a6b971617e16df679b
    BUG: 1075417
    Signed-off-by: Jan-Hendrik Zab <zab>
    Reviewed-on: http://review.gluster.org/9238
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 32 Justin Clift 2014-12-05 13:36:17 UTC
Awesome. :)

Jan-Hendrik, would you be interested in fixing any of the other typos?

We still have some listed here that need fixing:

  https://titanpad.com/gluster-misspellings

:D

Comment 33 Niels de Vos 2014-12-16 12:15:06 UTC
*** Bug 1173953 has been marked as a duplicate of this bug. ***

Comment 34 Anand Avati 2015-01-29 07:57:58 UTC
COMMIT: http://review.gluster.org/8264 committed in master by Niels de Vos (ndevos) 
------
commit e8eff5cf350b24ad628de8092d7927eab1e23c32
Author: Humble Chirammal <hchiramm>
Date:   Wed Jul 9 00:18:13 2014 +0530

    doc: Fix typos in stripe xlator src, no code changes present
    
    Change-Id: Icec4e6b0fe7845667b59e13e261734a5f69eba7e
    BUG: 1075417
    Signed-off-by: Humble Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/8264
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 35 Anand Avati 2015-01-29 11:17:02 UTC
REVIEW: http://review.gluster.org/9502 (geo-rep: Fixing the typo errors) posted (#1) for review on master by Anusha B.Rao (anusha91rao)

Comment 36 Anand Avati 2015-01-30 05:58:00 UTC
REVIEW: http://review.gluster.org/9507 (tests: fixing typo errors) posted (#1) for review on master by Sakshi Bansal (sabansal)

Comment 37 Anand Avati 2015-02-02 06:55:07 UTC
REVIEW: http://review.gluster.org/9529 (Xlators : Fixed typos) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in)

Comment 38 Anand Avati 2015-02-02 06:55:27 UTC
REVIEW: http://review.gluster.org/9502 (geo-rep: Fixing the typo errors) posted (#2) for review on master by Anusha B.Rao (anusha91rao)

Comment 39 Anand Avati 2015-02-02 08:49:33 UTC
REVIEW: http://review.gluster.org/9529 (Xlators : Fixed typos.) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in)

Comment 40 Anand Avati 2015-02-02 13:44:50 UTC
REVIEW: http://review.gluster.org/9507 (tests: fixing typo errors) posted (#2) for review on master by Sakshi Bansal (sabansal)

Comment 41 Anand Avati 2015-02-02 13:53:07 UTC
REVIEW: http://review.gluster.org/9529 (Xlators : Fixed typos) posted (#3) for review on master by Manikandan S Selvaganesh (11bc049.in)

Comment 42 Anand Avati 2015-02-02 20:07:17 UTC
COMMIT: http://review.gluster.org/9507 committed in master by Vijay Bellur (vbellur) 
------
commit 22cb0af7c4074a10450f549b68c56f6da02cbf4d
Author: Sakshi Bansal <sabansal>
Date:   Fri Jan 30 11:26:07 2015 +0530

    tests: fixing typo errors
    
    Change-Id: I8caab03531d74c64dcfa05c35a7daeee646cd2f5
    BUG: 1075417
    Signed-off-by: Sakshi Bansal <sabansal>
    Reviewed-on: http://review.gluster.org/9507
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 43 Anand Avati 2015-02-02 20:27:33 UTC
REVIEW: http://review.gluster.org/9548 (tests: fixing typo errors) posted (#1) for review on master by Vijay Bellur (vbellur)

Comment 44 Anand Avati 2015-02-02 20:28:19 UTC
COMMIT: http://review.gluster.org/9548 committed in master by Vijay Bellur (vbellur) 
------
commit b05b77923903deb26e5b1bae52da46ff6c1c878e
Author: Sakshi Bansal <sabansal>
Date:   Fri Jan 30 11:26:07 2015 +0530

    tests: fixing typo errors
    
    Change-Id: I8caab03531d74c64dcfa05c35a7daeee646cd2fa
    BUG: 1075417
    Signed-off-by: Sakshi Bansal <sabansal>
    Reviewed-on: http://review.gluster.org/9507
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/9548
    Tested-by: Vijay Bellur <vbellur>

Comment 45 Anand Avati 2015-02-03 18:03:51 UTC
COMMIT: http://review.gluster.org/9502 committed in master by Humble Devassy Chirammal (humble.devassy) 
------
commit ea6a31cd7c430768b8dfd3b4944fffde0be3a740
Author: arao <arao>
Date:   Thu Jan 29 16:37:35 2015 +0530

    geo-rep: Fixing the typo errors
    
    Change-Id: Iacc67e4ba9ac45e0858f3befe84ffb8fccf7e1c3
    BUG: 1075417
    Signed-off-by: arao <arao>
    Reviewed-on: http://review.gluster.org/9502
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>

Comment 46 Anand Avati 2015-02-25 14:08:41 UTC
REVIEW: http://review.gluster.org/9749 (spec: correcting GlusterFS string) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 47 Anand Avati 2015-02-25 21:18:49 UTC
COMMIT: http://review.gluster.org/9749 committed in master by Niels de Vos (ndevos) 
------
commit 1fd540c386b3b4a99e3ee1b926a30f0992266983
Author: Humble Devassy Chirammal <hchiramm>
Date:   Wed Feb 25 19:37:22 2015 +0530

    spec: correcting GlusterFS string
    
    Change-Id: Ia39d81f89cf783016700c8059f6a788029ee1b13
    BUG: 1075417
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/9749
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 48 Anand Avati 2015-03-12 18:38:51 UTC
REVIEW: http://review.gluster.org/9869 (doc: correct component name in manage volumes.) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 49 Anand Avati 2015-03-18 11:11:45 UTC
COMMIT: http://review.gluster.org/9869 committed in master by Lalatendu Mohanty (lmohanty) 
------
commit c73825b4bdb459219f06ec34706c0f2551cb9b0c
Author: Humble Devassy Chirammal <hchiramm>
Date:   Thu Mar 12 23:51:41 2015 +0530

    doc: correct component name in manage volumes.
    
    Change-Id: I12cb0cdacace755d6c545c8697a4e18d6035954b
    BUG: 1075417
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/9869
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Tested-by: Lalatendu Mohanty <lmohanty>

Comment 50 Anand Avati 2015-04-01 08:08:11 UTC
REVIEW: http://review.gluster.org/9529 (Xlators : Fixed typos) posted (#4) for review on master by Manikandan S Selvaganesh (mselvaga)

Comment 51 Anand Avati 2015-04-02 10:21:13 UTC
COMMIT: http://review.gluster.org/9529 committed in master by Vijay Bellur (vbellur) 
------
commit 1d6cd6bb0f2f5875e8e4ad370cf1ff2c601cbfd4
Author: Manikandan Selvaganesh <mselvaga>
Date:   Mon Feb 2 11:57:54 2015 +0530

    Xlators : Fixed typos
    
    Change-Id: I948f85cb369206ee8ce8b8cd5e48cae9adb971c9
    BUG: 1075417
    Signed-off-by: Manikandan Selvaganesh <mselvaga>
    Reviewed-on: http://review.gluster.org/9529
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>

Comment 52 Jiffin 2016-01-19 12:20:11 UTC
if there are new typos errors please reopen this bug


Note You need to log in before you can comment on or make changes to this bug.