Bug 1075598 (ghc-contravariant) - Review Request: ghc-contravariant - Contravariant functors
Summary: Review Request: ghc-contravariant - Contravariant functors
Alias: ghc-contravariant
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 999011
TreeView+ depends on / blocked
Reported: 2014-03-12 12:53 UTC by Rick Elrod
Modified: 2014-07-17 04:31 UTC (History)
2 users (show)

Fixed In Version: ghc-contravariant-0.5.2-1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-07-17 04:27:41 UTC
Type: ---
petersen: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
contravariant-0.4.4-without-transformers-compat.patch (501 bytes, patch)
2014-03-24 07:21 UTC, Jens Petersen
no flags Details | Diff

Description Rick Elrod 2014-03-12 12:53:10 UTC
Spec URL: http://codeblock.fedorapeople.org/packages/ghc-contravariant/ghc-contravariant.spec
SRPM URL: http://codeblock.fedorapeople.org/packages/ghc-contravariant/ghc-contravariant-0.4.4-1.fc20.src.rpm
Contravariant functors.
This package provides the Haskell contravariant library development files.
This package provides debug information for package ghc-contravariant.
Debug information is useful when developing applications that use this
package or when debugging this package.

Fedora Account System Username: codeblock

Comment 1 Jens Petersen 2014-03-24 07:13:09 UTC
Just for other people: this is needed for lens -> trifecta -> idris.

Comment 2 Jens Petersen 2014-03-24 07:21:29 UTC
Created attachment 877946 [details]

Just for the record, this simple patch would allow avoiding
the dependency on the backwards compat library transformers-compat.

Comment 3 Rick Elrod 2014-04-19 00:45:56 UTC
(In reply to Jens Petersen from comment #2)
> Just for the record, this simple patch would allow avoiding
> the dependency on the backwards compat library transformers-compat.

I have added the patch and uploaded the files at the same URLs.

Scratch build here:


Comment 4 Jens Petersen 2014-05-19 04:18:50 UTC
Basically looks fine but see minor point inline:

Package Review
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 4 files have unknown license. Detailed output of
     licensecheck in /home/petersen/pkgreview/1075598-ghc-
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.

cabal-rpm-0.8.11 now adds:

+# no useful debuginfo for Haskell packages without C sources
+%global debug_package %{nil}
 Name:           ghc-%{pkg_name}

[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 225280 bytes in 23 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.

In the meantime latest is now 0.6.

[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.

A comment explaining the patch would be good.

[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
[x]: Spec file according to URL is the same as in SRPM.

Checking: ghc-contravariant-0.4.4-1.fc21.x86_64.rpm
ghc-contravariant.x86_64: W: spelling-error Summary(en_US) functors -> functions
ghc-contravariant.x86_64: W: spelling-error %description -l en_US functors -> functions
ghc-contravariant.x86_64: W: incoherent-version-in-changelog 0.4.4 ['0.4.4-1.fc21', '0.4.4-1']
ghc-contravariant.src: W: spelling-error Summary(en_US) functors -> functions
ghc-contravariant.src: W: spelling-error %description -l en_US functors -> functions
ghc-contravariant.src: W: strange-permission contravariant-0.4.4.tar.gz 0600L
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

Rpmlint (installed packages)
# rpmlint ghc-contravariant ghc-contravariant-devel
ghc-contravariant.x86_64: W: spelling-error Summary(en_US) functors -> functions
ghc-contravariant.x86_64: W: spelling-error %description -l en_US functors -> functions
ghc-contravariant.x86_64: W: incoherent-version-in-changelog 0.4.4 ['0.4.4-1.fc21', '0.4.4-1']
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'

ghc-contravariant (rpmlib, GLIBC filtered):

ghc-contravariant-devel (rpmlib, GLIBC filtered):



Unversioned so-files
ghc-contravariant: /usr/lib64/ghc-7.6.3/contravariant-0.4.4/libHScontravariant-0.4.4-ghc7.6.3.so

Source checksums
http://hackage.haskell.org/package/contravariant-0.4.4/contravariant-0.4.4.tar.gz :
  CHECKSUM(SHA256) this package     : 441f943f6339a44b2fc9fb04ddd5f4c5210014470ce57c3271797b76b91084ac
  CHECKSUM(SHA256) upstream package : 441f943f6339a44b2fc9fb04ddd5f4c5210014470ce57c3271797b76b91084ac

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1075598
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby

Package is Approved but please
consider addressing the points noted in the review when importing:

- updating to cabal-rpm-0.8.11 will give debuginfo comment
- latest release is 0.6
- add comment above patch

Comment 5 Rick Elrod 2014-06-10 17:50:09 UTC
New Package SCM Request
Package Name: ghc-contravariant
Short Description: Contravariant functors
Upstream URL: https://hackage.haskell.org/package/contravariant
Owners: codeblock petersen
Branches: f19 f20 epel7

Comment 6 Gwyn Ciesla 2014-06-10 20:07:28 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-07-07 02:28:35 UTC
ghc-contravariant-0.5.2-1.fc20 has been submitted as an update for Fedora 20.

Comment 8 Fedora Update System 2014-07-07 02:28:41 UTC
ghc-contravariant-0.5.2-1.fc19 has been submitted as an update for Fedora 19.

Comment 9 Fedora Update System 2014-07-08 00:57:42 UTC
ghc-contravariant-0.5.2-1.fc19 has been pushed to the Fedora 19 testing repository.

Comment 10 Fedora Update System 2014-07-17 04:27:41 UTC
ghc-contravariant-0.5.2-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 11 Fedora Update System 2014-07-17 04:31:57 UTC
ghc-contravariant-0.5.2-1.fc19 has been pushed to the Fedora 19 stable repository.

Note You need to log in before you can comment on or make changes to this bug.