Bug 1075611 - [FEAT] log: enhance gluster log format with message ID and standardize errno reporting
Summary: [FEAT] log: enhance gluster log format with message ID and standardize errno ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: logging
Version: pre-release
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1096565 1234297
TreeView+ depends on / blocked
 
Reported: 2014-03-12 13:13 UTC by Shyamsundar
Modified: 2015-06-23 12:15 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
: 1096565 (view as bug list)
Environment:
Last Closed: 2014-11-11 08:28:42 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Shyamsundar 2014-03-12 13:13:32 UTC 
Description of problem:

Currently there are quite a slew of logs in Gluster that do not
        lend themselves to trivial analysis by various tools that help
        collect and monitor logs, due to the textual nature of the logs.
    
        This FEAT is to make this better by giving logs message IDs so
        that the tools do not have to do complex log parsing to break
        it down to problem areas and suggest troubleshooting options.
    
        With this patch, a new set of logging APIs are introduced that
        take additionally a message ID and an error number, so as to
        print the message ID and the descriptive string for the error.
    
        New APIs:
                - gf_msg, gf_msg_debug/trace, gf_msg_nomem, gf_msg_callingfn
    
        These APIs follow the functionality of the previous gf_log*
        counterparts, and hence are 1:1 replacements, with the delta
        that, gf_msg, gf_msg_callingfn take additional parameters as
        specified above.
    
        Defining the log messages:
        Each invocation of gf_msg/gf_msg_callingfn, should provide an ID
        and an errnum (if available). Towards this, a common message id
        file is provided, which contains defines to various messages and
        their respective strings. As other messages are changed to the
        new infrastructure APIs, it is intended that this file is edited
        to add these messages as well.
    
        Framework enhanced:
        The logging framework is also enhanced to be able to support
        different logging backends in the future. Hence new configuration
        options for logging framework and logging formats are introduced.
    
        Backward compatibility:
        Currently the framework supports logging in the traditional
                - gf_msg, gf_msg_debug/trace, gf_msg_nomem, gf_msg_callingfn
    
        These APIs follow the functionality of the previous gf_log*
        counterparts, and hence are 1:1 replacements, with the delta
        that, gf_msg, gf_msg_callingfn take additional parameters as
        specified above.
    
        Defining the log messages:
        Each invocation of gf_msg/gf_msg_callingfn, should provide an ID
        and an errnum (if available). Towards this, a common message id
        file is provided, which contains defines to various messages and
        their respective strings. As other messages are changed to the
        new infrastructure APIs, it is intended that this file is edited
        to add these messages as well.
    
        Framework enhanced:
        The logging framework is also enhanced to be able to support
        different logging backends in the future. Hence new configuration
        options for logging framework and logging formats are introduced.
    
        Backward compatibility:
        Currently the framework supports logging in the traditional
        format, with the inclusion of an error string based on the errnum
        passed in. Hence the shift to these new APIs would retain the log
        file names, locations, and format with the exception of an
        additional error string where applicable.
Comment 1 Anand Avati 2014-03-12 14:39:50 UTC 
REVIEW: http://review.gluster.org/6547 (log: enhance gluster log format with message ID and standardize errno reporting) posted (#5) for review on master by Shyamsundar Ranganathan (sam.somari)
Comment 2 Shyamsundar 2014-03-12 14:52:17 UTC 
Feature page can be found here: http://www.gluster.org/community/documentation/index.php/Features/better-logging
Comment 3 Anand Avati 2014-03-26 19:11:50 UTC 
REVIEW: http://review.gluster.org/6547 (log: enhance gluster log format with message ID and standardize errno reporting) posted (#6) for review on master by Shyamsundar Ranganathan (sam.somari)
Comment 4 Anand Avati 2014-03-28 11:54:14 UTC 
COMMIT: http://review.gluster.org/6547 committed in master by Vijay Bellur (vbellur) 
------
commit 31e34cfd72712c76c127509d14d50eb008743fd5
Author: ShyamsundarR <srangana>
Date:   Fri Dec 20 13:19:00 2013 +0530

    log: enhance gluster log format with message ID and standardize errno reporting
    
    	Currently there are quite a slew of logs in Gluster that do not
    	lend themselves to trivial analysis by various tools that help
    	collect	and monitor logs, due to the textual nature of the logs.
    
    	This FEAT is to make this better by giving logs message IDs so
    	that the tools do not have to do complex log parsing to break
    	it down to problem areas and suggest troubleshooting options.
    
    	With this patch, a new set of logging APIs are introduced that
    	take additionally a message ID and an error number, so as to
    	print the message ID and the descriptive string for the error.
    
    	New APIs:
    		- gf_msg, gf_msg_debug/trace, gf_msg_nomem, gf_msg_callingfn
    
    	These APIs follow the functionality of the previous gf_log*
    	counterparts, and hence are 1:1 replacements, with the delta
    	that, gf_msg, gf_msg_callingfn take additional parameters as
    	specified above.
    
    	Defining the log messages:
    	Each invocation of gf_msg/gf_msg_callingfn, should provide an ID
    	and an errnum (if available). Towards this, a common message id
    	file is provided, which contains defines to various messages and
    	their respective strings. As other messages are changed to the
    	new infrastructure APIs, it is intended that this file is edited
    	to add these messages as well.
    
    	Framework enhanced:
    	The logging framework is also enhanced to be able to support
    	different logging backends in the future. Hence new configuration
    	options for logging framework and logging formats are introduced.
    
    	Backward compatibility:
    	Currently the framework supports logging in the traditional
    	format, with the inclusion of an error string based on the errnum
    	passed in. Hence the shift to these new APIs would retain the log
    	file names, locations, and format with the exception of an
    	additional error string where applicable.
    
    	Testing done:
    	Tested the new APIs with different messages in normal code paths
    	Tested with configurations set to gluster logs (syslog pending)
    	Tested nomem variants, inducing the message in normal code paths
    	Tested ident generation for normal code paths (other paths
    		pending)
    	Tested with sample gfapi program for gfapi messages
    	Test code is stripped from the commit
    
    	Pending work (not to be addressed in this patch (future)):
    	- Logging framework should be configurable
    	- Logging format should be configurable
    	- Once all messages move to the new APIs deprecate/delete older
    	  APIs to prevent misuse/abuse using the same
    	- Repeated log messages should be suppressed (as a configurable
    	  option)
    	- Logging framework assumes that only one init is possible, but
    	  there is no protection around the same (in existing code)
    	- gf_log_fini is not invoked anywhere and does very little
    	  cleanup (in existing code)
    	- DOxygen comments to message id headers for each message
    
    Change-Id: Ia043fda99a1c6cf7817517ef9e279bfcf35dcc24
    BUG: 1075611
    Signed-off-by: ShyamsundarR <srangana>
    Reviewed-on: http://review.gluster.org/6547
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 6 Anand Avati 2014-03-31 09:58:37 UTC 
REVIEW: http://review.gluster.org/7371 (log: Add missing log message from glusterfsd.c to glusterfsd-messages.h) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
Comment 7 Anand Avati 2014-03-31 09:58:44 UTC 
REVIEW: http://review.gluster.org/7372 (logging: Make logger and log format configurable through cli) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
Comment 8 Anand Avati 2014-04-02 07:38:50 UTC 
REVIEW: http://review.gluster.org/7372 (logging: Make logger and log format configurable through cli) posted (#2) for review on master by Krutika Dhananjay (kdhananj)
Comment 9 Anand Avati 2014-04-02 07:38:55 UTC 
REVIEW: http://review.gluster.org/7371 (log: Add missing log message from glusterfsd.c to glusterfsd-messages.h) posted (#2) for review on master by Krutika Dhananjay (kdhananj)
Comment 10 Anand Avati 2014-04-03 03:59:41 UTC 
REVIEW: http://review.gluster.org/7372 (logging: Make logger and log format configurable through cli) posted (#3) for review on master by Krutika Dhananjay (kdhananj)
Comment 11 Anand Avati 2014-04-03 03:59:48 UTC 
REVIEW: http://review.gluster.org/7371 (log: Add missing log message from glusterfsd.c to glusterfsd-messages.h) posted (#3) for review on master by Krutika Dhananjay (kdhananj)
Comment 12 Anand Avati 2014-04-03 09:33:28 UTC 
REVIEW: http://review.gluster.org/7372 (logging: Make logger and log format configurable through cli) posted (#4) for review on master by Krutika Dhananjay (kdhananj)
Comment 13 Anand Avati 2014-04-05 18:15:43 UTC 
COMMIT: http://review.gluster.org/7371 committed in master by Vijay Bellur (vbellur) 
------
commit d586ecc0a501440436a918ed973fd75facafc455
Author: Krutika Dhananjay <kdhananj>
Date:   Sun Mar 30 08:37:02 2014 +0530

    log: Add missing log message from glusterfsd.c to glusterfsd-messages.h
    
    ... by retaining GLFS_NUM_MESSAGES as 33 which is its correct value.
    
    Also replace all occurrences of gf_log with gf_msg/gf_msg_debug.
    
    Change-Id: Ibfbe1d645de521e8d59ca406f78b1a8eb08aa7e0
    BUG: 1075611
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/7371
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 14 Anand Avati 2014-04-12 01:01:00 UTC 
COMMIT: http://review.gluster.org/7372 committed in master by Vijay Bellur (vbellur) 
------
commit 712541cdefcc9614e5a79f628358f205ceda6e55
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Mar 11 15:05:44 2014 +0530

    logging: Make logger and log format configurable through cli
    
    Change-Id: Ic4b701a6621578848ff67ae4ecb5a10b5f32f93b
    BUG: 1075611
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/7372
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 15 Anand Avati 2014-04-14 13:14:56 UTC 
REVIEW: http://review.gluster.org/7475 (logging: Introduce suppression of repetitive log messages) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
Comment 16 Anand Avati 2014-04-14 15:16:32 UTC 
REVIEW: http://review.gluster.org/7475 (logging: Introduce suppression of repetitive log messages) posted (#2) for review on master by Krutika Dhananjay (kdhananj)
Comment 17 Anand Avati 2014-04-23 12:35:54 UTC 
REVIEW: http://review.gluster.org/7475 (logging: Introduce suppression of repetitive log messages) posted (#3) for review on master by Krutika Dhananjay (kdhananj)
Comment 18 Anand Avati 2014-04-24 10:00:21 UTC 
REVIEW: http://review.gluster.org/7475 (logging: Introduce suppression of repetitive log messages) posted (#4) for review on master by Krutika Dhananjay (kdhananj)
Comment 19 Anand Avati 2014-04-24 10:34:10 UTC 
REVIEW: http://review.gluster.org/7462 (glusterd: port network failure log messages to gf_msg API) posted (#4) for review on master by Krishnan Parthasarathi (kparthas)
Comment 20 Anand Avati 2014-04-24 11:49:55 UTC 
REVIEW: http://review.gluster.org/7471 (glusterd : port glusterd messages to new logging framework) posted (#3) for review on master by Atin Mukherjee (amukherj)
Comment 21 Anand Avati 2014-04-28 04:11:04 UTC 
REVIEW: http://review.gluster.org/7574 (QUTOA: port QUOTA messages to new logging framework) posted (#1) for review on master by susant palai (spalai)
Comment 22 Anand Avati 2014-04-28 04:22:18 UTC 
REVIEW: http://review.gluster.org/7574 (QUTOA: port QUOTA messages to new logging framework) posted (#2) for review on master by susant palai (spalai)
Comment 23 Anand Avati 2014-04-28 04:45:50 UTC 
REVIEW: http://review.gluster.org/7574 (QUTOA: port QUOTA messages to new logging framework) posted (#3) for review on master by susant palai (spalai)
Comment 24 Anand Avati 2014-04-28 04:52:40 UTC 
REVIEW: http://review.gluster.org/7574 (QUTOA: port QUOTA messages to new logging framework) posted (#4) for review on master by susant palai (spalai)
Comment 25 Anand Avati 2014-04-28 04:54:12 UTC 
REVIEW: http://review.gluster.org/7574 (QUTOA: port QUOTA messages to new logging framework) posted (#5) for review on master by susant palai (spalai)
Comment 26 Anand Avati 2014-04-28 07:59:55 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#1) for review on master by Kaushal M (kaushal)
Comment 27 Anand Avati 2014-04-28 09:59:09 UTC 
REVIEW: http://review.gluster.org/7462 (glusterd: port network failure log messages to gf_msg API) posted (#5) for review on master by Krishnan Parthasarathi (kparthas)
Comment 28 Anand Avati 2014-04-28 10:18:10 UTC 
REVIEW: http://review.gluster.org/7471 (glusterd : port glusterd messages to new logging framework) posted (#4) for review on master by Atin Mukherjee (amukherj)
Comment 29 Anand Avati 2014-04-28 10:29:08 UTC 
REVIEW: http://review.gluster.org/7574 (QUTOA: port QUOTA messages to new logging framework) posted (#6) for review on master by susant palai (spalai)
Comment 30 Anand Avati 2014-04-28 11:16:49 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#2) for review on master by Kaushal M (kaushal)
Comment 31 Anand Avati 2014-04-28 11:44:57 UTC 
REVIEW: http://review.gluster.org/7580 (logging: Fix msg-id segment allocation) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
Comment 32 Anand Avati 2014-04-28 11:46:21 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#3) for review on master by Kaushal M (kaushal)
Comment 33 Anand Avati 2014-04-28 12:04:19 UTC 
REVIEW: http://review.gluster.org/7574 (QUTOA: port QUOTA messages to new logging framework) posted (#7) for review on master by susant palai (spalai)
Comment 34 Anand Avati 2014-04-28 12:11:22 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#8) for review on master by susant palai (spalai)
Comment 35 Anand Avati 2014-04-28 13:35:09 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#9) for review on master by susant palai (spalai)
Comment 36 Anand Avati 2014-04-29 05:32:24 UTC 
REVIEW: http://review.gluster.org/7580 (logging: Fix msg-id segment allocation) posted (#2) for review on master by Krutika Dhananjay (kdhananj)
Comment 37 Anand Avati 2014-04-29 06:39:38 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#4) for review on master by Kaushal M (kaushal)
Comment 38 Anand Avati 2014-04-29 11:40:37 UTC 
COMMIT: http://review.gluster.org/7580 committed in master by Vijay Bellur (vbellur) 
------
commit 9dd643dc68bfc22f7244706717d7dcb4ab090f06
Author: Krutika Dhananjay <kdhananj>
Date:   Mon Apr 28 10:59:04 2014 +0530

    logging: Fix msg-id segment allocation
    
    Change-Id: I85efa4b91c263d7374d34dd0d84e9f1032d07ab6
    BUG: 1075611
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/7580
    Reviewed-by: N Balachandran <nbalacha>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 39 Anand Avati 2014-04-29 14:25:16 UTC 
REVIEW: http://review.gluster.org/7475 (logging: Introduce suppression of repetitive log messages) posted (#5) for review on master by Krutika Dhananjay (kdhananj)
Comment 40 Anand Avati 2014-05-01 06:52:34 UTC 
COMMIT: http://review.gluster.org/7475 committed in master by Vijay Bellur (vbellur) 
------
commit 630d46d714a233919664c035f2c5c48c028777e8
Author: Krutika Dhananjay <kdhananj>
Date:   Fri Feb 7 11:02:10 2014 +0530

    logging: Introduce suppression of repetitive log messages
    
    Change-Id: I8efa08cc9832ad509fba65a88bb0cddbaf056404
    BUG: 1075611
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/7475
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 41 Anand Avati 2014-05-02 07:28:32 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#5) for review on master by Kaushal M (kaushal)
Comment 42 Anand Avati 2014-05-02 09:40:38 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#6) for review on master by Krishnan Parthasarathi (kparthas)
Comment 43 Anand Avati 2014-05-02 09:40:43 UTC 
REVIEW: http://review.gluster.org/7644 (glusterd: port network failure log messages to gf_msg API) posted (#1) for review on master by Krishnan Parthasarathi (kparthas)
Comment 44 Anand Avati 2014-05-03 07:27:41 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#7) for review on master by Atin Mukherjee (amukherj)
Comment 45 Anand Avati 2014-05-03 07:27:47 UTC 
REVIEW: http://review.gluster.org/7652 (Port glusterd sync log messages to gf_msg API) posted (#1) for review on master by Atin Mukherjee (amukherj)
Comment 46 Anand Avati 2014-05-03 07:34:27 UTC 
REVIEW: http://review.gluster.org/7652 (Port glusterd sync log messages to gf_msg API) posted (#2) for review on master by Atin Mukherjee (amukherj)
Comment 47 Anand Avati 2014-05-03 07:42:35 UTC 
REVIEW: http://review.gluster.org/7652 (glusterd : Port glusterd sync log messages to gf_msg API) posted (#3) for review on master by Atin Mukherjee (amukherj)
Comment 48 Anand Avati 2014-05-05 07:17:19 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#8) for review on master by Krishnan Parthasarathi (kparthas)
Comment 49 Anand Avati 2014-05-05 07:17:26 UTC 
REVIEW: http://review.gluster.org/7462 (glusterd: port network failure log messages to gf_msg API) posted (#6) for review on master by Krishnan Parthasarathi (kparthas)
Comment 50 Anand Avati 2014-05-05 07:24:32 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#9) for review on master by Kaushal M (kaushal)
Comment 51 Anand Avati 2014-05-06 09:06:59 UTC 
REVIEW: http://review.gluster.org/7681 (logging: Add extra logs to enable testing of log suppression) posted (#1) for review on master by Krutika Dhananjay (kdhananj)
Comment 52 Anand Avati 2014-05-06 09:59:44 UTC 
REVIEW: http://review.gluster.org/7652 (glusterd : Port glusterd sync log messages to gf_msg API) posted (#4) for review on master by Kaushal M (kaushal)
Comment 53 Anand Avati 2014-05-06 09:59:50 UTC 
REVIEW: http://review.gluster.org/7578 (glusterd: Port server quorum messages to the gf_msg API) posted (#10) for review on master by Kaushal M (kaushal)
Comment 54 Anand Avati 2014-05-06 09:59:56 UTC 
REVIEW: http://review.gluster.org/7462 (glusterd: port network failure log messages to gf_msg API) posted (#7) for review on master by Kaushal M (kaushal)
Comment 55 Anand Avati 2014-05-07 04:45:54 UTC 
COMMIT: http://review.gluster.org/7578 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit f9672386ac2e3da2dc5439eb0a3a53dfaa5181dd
Author: Kaushal M <kaushal>
Date:   Mon Apr 28 13:17:22 2014 +0530

    glusterd: Port server quorum messages to the gf_msg API
    
    Change-Id: I84716cc07f3cbd8c1b2825a5676d6693fed6fade
    BUG: 1075611
    Signed-off-by: Kaushal M <kaushal>
    Reviewed-on: http://review.gluster.org/7578
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>
Comment 56 Anand Avati 2014-05-07 04:47:03 UTC 
COMMIT: http://review.gluster.org/7462 committed in master by Kaushal M (kaushal) 
------
commit 451246a58dbbc1ec777f379a6b779be374379abd
Author: Krishnan Parthasarathi <kparthas>
Date:   Fri May 2 15:09:25 2014 +0530

    glusterd: port network failure log messages to gf_msg API
    
    Change-Id: I23df6d179e9d66a71721e9844a34c5b96586f90f
    BUG: 1075611
    Signed-off-by: Krishnan Parthasarathi <kparthas>
    Reviewed-on: http://review.gluster.org/7462
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>
Comment 57 Anand Avati 2014-05-07 04:48:10 UTC 
COMMIT: http://review.gluster.org/7652 committed in master by Kaushal M (kaushal) 
------
commit 199435aac3be170f6dadd4e88a576cec808ee419
Author: Atin Mukherjee <amukherj>
Date:   Sat May 3 12:52:44 2014 +0530

    glusterd : Port glusterd sync log messages to gf_msg API
    
    Change-Id: Ic3ed2c96d8fc3a15fedaa80517a2c79c0c858963
    BUG: 1075611
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/7652
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>
Comment 58 Anand Avati 2014-05-09 10:08:43 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#1) for review on master by N Balachandran (nbalacha)
Comment 59 Anand Avati 2014-05-09 10:30:38 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#2) for review on master by N Balachandran (nbalacha)
Comment 60 Anand Avati 2014-05-12 05:04:13 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#3) for review on master by N Balachandran (nbalacha)
Comment 61 Anand Avati 2014-05-16 09:43:32 UTC 
COMMIT: http://review.gluster.org/7681 committed in master by Vijay Bellur (vbellur) 
------
commit 07e8f0226d5263501d2b23ed008c59ed45a5a5bd
Author: Krutika Dhananjay <kdhananj>
Date:   Fri May 2 13:55:59 2014 +0530

    logging: Add extra logs to enable testing of log suppression
    
    Note:
    This patch may be reverted once the testing effort is complete,
    if desired.
    
    Change-Id: I840399c531a43049749073d4d59bc0c85f525be3
    BUG: 1075611
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/7681
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 62 Anand Avati 2014-05-16 10:17:33 UTC 
REVIEW: http://review.gluster.org/7784 (cluster/afr: move messages to new logging framework) posted (#1) for review on master by Ravishankar N (ravishankar)
Comment 63 Anand Avati 2014-05-16 12:36:08 UTC 
REVIEW: http://review.gluster.org/7784 (cluster/afr: move messages to new logging framework) posted (#2) for review on master by Ravishankar N (ravishankar)
Comment 64 Anand Avati 2014-05-17 03:46:10 UTC 
REVIEW: http://review.gluster.org/7784 (cluster/afr: move messages to new logging framework) posted (#3) for review on master by Ravishankar N (ravishankar)
Comment 65 Anand Avati 2014-05-17 06:04:01 UTC 
REVIEW: http://review.gluster.org/7784 (cluster/afr: move messages to new logging framework) posted (#4) for review on master by Ravishankar N (ravishankar)
Comment 66 Anand Avati 2014-05-17 08:46:24 UTC 
COMMIT: http://review.gluster.org/7784 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit f4a391e5a44950b0468af082255b9f5abf52b10b
Author: Ravishankar N <ravishankar>
Date:   Fri May 16 15:41:33 2014 +0530

    cluster/afr: move messages to new logging framework
    
    Change important (from a diagnostics point of view) log messages to use
    the gf_msg() framework.
    
    Change-Id: I0a58184bbb78989db149e67f07c140a21c781bc2
    BUG: 1075611
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/7784
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
Comment 67 Anand Avati 2014-05-21 11:18:11 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#4) for review on master by N Balachandran (nbalacha)
Comment 68 Anand Avati 2014-05-22 05:05:16 UTC 
REVIEW: http://review.gluster.org/7840 (cluster/afr: Add descriptions to message-ids.) posted (#1) for review on master by Ravishankar N (ravishankar)
Comment 69 Anand Avati 2014-05-22 10:48:13 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#5) for review on master by N Balachandran (nbalacha)
Comment 70 Anand Avati 2014-05-26 04:55:12 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#6) for review on master by N Balachandran (nbalacha)
Comment 71 Anand Avati 2014-05-26 06:19:22 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#7) for review on master by N Balachandran (nbalacha)
Comment 72 Anand Avati 2014-05-26 06:49:05 UTC 
REVIEW: http://review.gluster.org/7867 (glusterd : glusterd message-id documentation) posted (#1) for review on master by Atin Mukherjee (amukherj)
Comment 73 Anand Avati 2014-05-26 09:15:09 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#8) for review on master by N Balachandran (nbalacha)
Comment 74 Anand Avati 2014-05-27 08:42:37 UTC 
REVIEW: http://review.gluster.org/7727 (Cluster/DHT : Moving to new logging framework) posted (#9) for review on master by N Balachandran (nbalacha)
Comment 75 Anand Avati 2014-05-28 07:19:01 UTC 
REVIEW: http://review.gluster.org/7840 (cluster/afr: Add descriptions to message-ids.) posted (#3) for review on master by Ravishankar N (ravishankar)
Comment 76 Anand Avati 2014-05-28 08:47:11 UTC 
REVIEW: http://review.gluster.org/7867 (glusterd : glusterd message-id comments to support extracting the msg-id description through doxygen) posted (#2) for review on master by Atin Mukherjee (amukherj)
Comment 77 Anand Avati 2014-05-29 07:27:46 UTC 
REVIEW: http://review.gluster.org/7867 (glusterd : glusterd message-id comments to support extracting the msg-id description through doxygen) posted (#3) for review on master by Atin Mukherjee (amukherj)
Comment 78 Anand Avati 2014-05-30 06:12:54 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#10) for review on master by susant palai (spalai)
Comment 79 Anand Avati 2014-05-30 06:54:19 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#1) for review on master by N Balachandran (nbalacha)
Comment 80 Anand Avati 2014-05-30 07:13:05 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#2) for review on master by N Balachandran (nbalacha)
Comment 81 Anand Avati 2014-05-30 17:29:39 UTC 
COMMIT: http://review.gluster.org/7840 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 3230db8561ddfec2aa26fc106ec65b4a307b6db6
Author: Ravishankar N <ravishankar>
Date:   Thu May 22 10:25:47 2014 +0530

    cluster/afr: Add descriptions to message-ids.
    
    Change-Id: I7ec2821c96d4cbff78b4959d9b07019896cc9a2c
    BUG: 1075611
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/7840
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: N Balachandran <nbalacha>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
Comment 82 Anand Avati 2014-06-02 07:08:00 UTC 
REVIEW: http://review.gluster.org/7867 (glusterd : glusterd message-id comments to support extracting the msg-id description through doxygen) posted (#4) for review on master by Atin Mukherjee (amukherj)
Comment 83 Anand Avati 2014-06-02 07:30:13 UTC 
REVIEW: http://review.gluster.org/7867 (glusterd : glusterd message-id comments to support extracting the msg-id description through doxygen) posted (#5) for review on master by Atin Mukherjee (amukherj)
Comment 84 Anand Avati 2014-06-02 09:08:34 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#11) for review on master by susant palai (spalai)
Comment 85 Anand Avati 2014-06-03 05:41:15 UTC 
REVIEW: http://review.gluster.org/7867 (glusterd : glusterd message-id comments to support extracting the msg-id description through doxygen) posted (#6) for review on master by Atin Mukherjee (amukherj)
Comment 86 Anand Avati 2014-06-03 07:52:14 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#3) for review on master by N Balachandran (nbalacha)
Comment 87 Anand Avati 2014-06-03 07:55:38 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#4) for review on master by N Balachandran (nbalacha)
Comment 88 Anand Avati 2014-06-03 10:22:34 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#5) for review on master by N Balachandran (nbalacha)
Comment 89 Anand Avati 2014-06-04 04:50:12 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#6) for review on master by N Balachandran (nbalacha)
Comment 90 Anand Avati 2014-06-04 10:22:05 UTC 
REVIEW: http://review.gluster.org/7969 (Gluster Doxygen conf file for message ids: Added a doxygen conf file that will extract the documentation for the message ids defined for various components.) posted (#1) for review on master by N Balachandran (nbalacha)
Comment 91 Anand Avati 2014-06-04 11:58:06 UTC 
REVIEW: http://review.gluster.org/7867 (glusterd : glusterd message-id comments to support extracting the msg-id description through doxygen) posted (#7) for review on master by Atin Mukherjee (amukherj)
Comment 92 Anand Avati 2014-06-05 07:08:11 UTC 
REVIEW: http://review.gluster.org/7969 (Gluster msg-ids Doxygen conf file: Added a doxygen conf file that will extract the documentation for the message ids defined for various components.) posted (#2) for review on master by N Balachandran (nbalacha)
Comment 93 Anand Avati 2014-06-05 07:54:47 UTC 
REVIEW: http://review.gluster.org/7987 (Gluster msg-ids Doxygen: Added a doxygen conf file that will extract the documentation for the message ids defined for various components.) posted (#1) for review on master by N Balachandran (nbalacha)
Comment 94 Anand Avati 2014-06-06 13:27:51 UTC 
REVIEW: http://review.gluster.org/8005 (features/quota: port QUOTA messages to new logging framework) posted (#1) for review on master by susant palai (spalai)
Comment 95 Anand Avati 2014-06-07 04:19:12 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#12) for review on master by susant palai (spalai)
Comment 96 Anand Avati 2014-06-10 05:57:42 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#7) for review on master by N Balachandran (nbalacha)
Comment 97 Anand Avati 2014-06-10 06:11:03 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#8) for review on master by N Balachandran (nbalacha)
Comment 98 Anand Avati 2014-06-10 10:12:47 UTC 
COMMIT: http://review.gluster.org/7867 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit f95a0f99599c0e1825a36eb424b3fe386d6d6b23
Author: Atin Mukherjee <amukherj>
Date:   Mon May 26 12:12:36 2014 +0530

    glusterd : glusterd message-id comments to support extracting the msg-id
    description through doxygen
    
    Change-Id: Ic9660519ae505b78e976e092e7ac80ae63b12a7f
    BUG: 1075611
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/7867
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Pavithra Srinivasan <psriniva>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>
Comment 99 Anand Avati 2014-06-11 06:28:08 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#9) for review on master by N Balachandran (nbalacha)
Comment 100 Anand Avati 2014-06-12 10:49:06 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#10) for review on master by N Balachandran (nbalacha)
Comment 101 Anand Avati 2014-06-12 10:51:58 UTC 
REVIEW: http://review.gluster.org/7987 (Gluster msg-ids Doxygen: Added a doxygen conf file that will extract the documentation for the message ids defined for various components.) posted (#2) for review on master by N Balachandran (nbalacha)
Comment 102 Anand Avati 2014-06-16 04:48:08 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#11) for review on master by N Balachandran (nbalacha)
Comment 103 Anand Avati 2014-06-16 05:19:19 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#12) for review on master by N Balachandran (nbalacha)
Comment 104 Anand Avati 2014-06-16 09:35:55 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#13) for review on master by N Balachandran (nbalacha)
Comment 105 Anand Avati 2014-06-16 10:56:31 UTC 
REVIEW: http://review.gluster.org/7929 (Cluster/DHT: New logging framework) posted (#14) for review on master by N Balachandran (nbalacha)
Comment 106 Anand Avati 2014-06-16 13:26:14 UTC 
COMMIT: http://review.gluster.org/7929 committed in master by Vijay Bellur (vbellur) 
------
commit 7382b66de76101d625ed888ec7b7f82fd7da56d3
Author: Nithya Balachandran <nbalacha>
Date:   Fri May 30 11:26:40 2014 +0530

    Cluster/DHT: New logging framework
    
    Moved all relevant DHT gf_log calls to the new logging
    framework.
    
    Change-Id: I3af3cfe0416e332774a6c4ff6a091d006c400af2
    BUG: 1075611
    Signed-off-by: Nithya Balachandran <nbalacha>
    Reviewed-on: http://review.gluster.org/7929
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 107 Anand Avati 2014-06-18 05:38:25 UTC 
REVIEW: http://review.gluster.org/8096 (Cluster/DHT : Logging changes) posted (#1) for review on master by N Balachandran (nbalacha)
Comment 108 Anand Avati 2014-06-18 06:00:52 UTC 
REVIEW: http://review.gluster.org/8096 (Cluster/DHT : Logging changes) posted (#2) for review on master by N Balachandran (nbalacha)
Comment 109 Anand Avati 2014-06-19 06:00:31 UTC 
COMMIT: http://review.gluster.org/8096 committed in master by Vijay Bellur (vbellur) 
------
commit f844e5019de872e0c138daa6257d1f6cac5a4aff
Author: Nithya Balachandran <nbalacha>
Date:   Wed Jun 18 11:06:21 2014 +0530

    Cluster/DHT : Logging changes
    
    Removed trailing spaces from the code
    
    Change-Id: I427c9a01b514824f903e301863c2c29071db6483
    BUG: 1075611
    Signed-off-by: Nithya Balachandran <nbalacha>
    Reviewed-on: http://review.gluster.org/8096
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 110 Anand Avati 2014-06-23 07:17:52 UTC 
REVIEW: http://review.gluster.org/8149 (cluster/afr: change message description in afr-messages.h) posted (#1) for review on master by Ravishankar N (ravishankar)
Comment 111 Anand Avati 2014-06-23 12:14:08 UTC 
REVIEW: http://review.gluster.org/8149 (cluster/afr: change message description in afr-messages.h) posted (#2) for review on master by Ravishankar N (ravishankar)
Comment 112 Anand Avati 2014-06-24 08:32:05 UTC 
COMMIT: http://review.gluster.org/8149 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 10c04c617276dbd9af7ae04ae287fe6f75e2f2ae
Author: Ravishankar N <ravishankar>
Date:   Mon Jun 23 12:36:17 2014 +0530

    cluster/afr: change message description in afr-messages.h
    
    Changed the description of AFR_MSG_SUBVOL_UP to make it more meaningful.
    
    Change-Id: I30fa13c2e9a280a22d48e777d259d04a3b71deef
    BUG: 1075611
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/8149
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>
Comment 113 Anand Avati 2014-07-01 10:10:45 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#13) for review on master by susant palai (spalai)
Comment 114 Niels de Vos 2014-11-11 08:28:42 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users
Comment 115 Anand Avati 2015-05-25 11:36:51 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#14) for review on master by Susant Palai (spalai)
Comment 116 Anand Avati 2015-05-29 12:02:41 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#15) for review on master by Susant Palai (spalai)
Comment 117 Anand Avati 2015-05-30 10:40:40 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#16) for review on master by Niels de Vos (ndevos)
Comment 118 Anand Avati 2015-06-01 07:39:31 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#17) for review on master by Susant Palai (spalai)
Comment 119 Anand Avati 2015-06-12 07:17:10 UTC 
REVIEW: http://review.gluster.org/7574 (features/quota: port QUOTA messages to new logging framework) posted (#18) for review on master by Susant Palai (spalai)
Comment 120 Anand Avati 2015-06-15 04:29:16 UTC 
COMMIT: http://review.gluster.org/7574 committed in master by Raghavendra G (rgowdapp) 
------
commit 8720cef1ed642d7cb09e98c41458d19845f24711
Author: Susant Palai <spalai>
Date:   Mon May 25 16:52:10 2015 +0530

    features/quota: port QUOTA messages to new logging framework
    
    Change-Id: I5e3df8860ea35bce14a802391be9b22ad64f1ad4
    BUG: 1075611
    Signed-off-by: Susant Palai <spalai>
    Reviewed-on: http://review.gluster.org/7574
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>
Note You need to log in before you can comment on or make changes to this bug.