Spec URL: http://nb.fedorapeople.org/yubikey/libykneomgr.spec SRPM URL: http://nb.fedorapeople.org/yubikey/libykneomgr-0.0.2-1.fc20.src.rpm Description: Library and command line tool to manage YubiKey NEO Fedora Account System Username: nb
Updated to fix issues that fedora-review found Spec URL: http://nb.fedorapeople.org/yubikey/libykneomgr.spec SRPM URL: http://nb.fedorapeople.org/yubikey/libykneomgr-0.0.2-2.fc20.src.rpm
Spec file says LGPL but there are some other licenses involved here. GPL (v2 or later) ----------------- libykneomgr-0.0.2/build-aux/ltmain.sh GPL (v3 or later) ----------------- libykneomgr-0.0.2/build-aux/snippet/arg-nonnull.h libykneomgr-0.0.2/build-aux/snippet/c++defs.h libykneomgr-0.0.2/build-aux/snippet/warn-on-use.h LGPL ---- libykneomgr-0.0.2/gl/memchr.c LGPL (v2 or later) ------------------ libykneomgr-0.0.2/gl/alloca.in.h libykneomgr-0.0.2/gl/asnprintf.c libykneomgr-0.0.2/gl/errno.in.h libykneomgr-0.0.2/gl/float+.h libykneomgr-0.0.2/gl/printf-args.c libykneomgr-0.0.2/gl/printf-args.h libykneomgr-0.0.2/gl/printf-parse.c libykneomgr-0.0.2/gl/printf-parse.h libykneomgr-0.0.2/gl/size_max.h libykneomgr-0.0.2/gl/stddef.in.h libykneomgr-0.0.2/gl/stdint.in.h libykneomgr-0.0.2/gl/stdio.in.h libykneomgr-0.0.2/gl/string.in.h libykneomgr-0.0.2/gl/sys_types.in.h libykneomgr-0.0.2/gl/vasnprintf.c libykneomgr-0.0.2/gl/vasnprintf.h libykneomgr-0.0.2/gl/wchar.in.h libykneomgr-0.0.2/gl/xsize.h LGPL (v3 or later) ------------------ libykneomgr-0.0.2/gl/float.c libykneomgr-0.0.2/gl/float.in.h libykneomgr-0.0.2/gl/fpucw.h libykneomgr-0.0.2/gl/frexp.c libykneomgr-0.0.2/gl/frexpl.c libykneomgr-0.0.2/gl/fseterr.c libykneomgr-0.0.2/gl/fseterr.h libykneomgr-0.0.2/gl/isnan.c libykneomgr-0.0.2/gl/isnand-nolibm.h libykneomgr-0.0.2/gl/isnand.c libykneomgr-0.0.2/gl/isnanf-nolibm.h libykneomgr-0.0.2/gl/isnanf.c libykneomgr-0.0.2/gl/isnanl-nolibm.h libykneomgr-0.0.2/gl/isnanl.c libykneomgr-0.0.2/gl/itold.c libykneomgr-0.0.2/gl/math.in.h libykneomgr-0.0.2/gl/printf-frexp.c libykneomgr-0.0.2/gl/printf-frexp.h libykneomgr-0.0.2/gl/printf-frexpl.c libykneomgr-0.0.2/gl/printf-frexpl.h libykneomgr-0.0.2/gl/printf.c libykneomgr-0.0.2/gl/signbitd.c libykneomgr-0.0.2/gl/signbitf.c libykneomgr-0.0.2/gl/signbitl.c libykneomgr-0.0.2/gl/stdio-impl.h libykneomgr-0.0.2/gl/verify.h libykneomgr-0.0.2/gl/vfprintf.c libykneomgr-0.0.2/lib/backend_globalplatform.c libykneomgr-0.0.2/lib/backend_pcsc.c libykneomgr-0.0.2/lib/devs.c libykneomgr-0.0.2/lib/error.c libykneomgr-0.0.2/lib/global.c libykneomgr-0.0.2/lib/internal.h libykneomgr-0.0.2/lib/version.c libykneomgr-0.0.2/lib/ykneomgr/ykneomgr-types.h libykneomgr-0.0.2/lib/ykneomgr/ykneomgr-version.h libykneomgr-0.0.2/lib/ykneomgr/ykneomgr.h libykneomgr-0.0.2/src/ykneomgr.c libykneomgr-0.0.2/tests/basic.c Unknown or generated -------------------- libykneomgr-0.0.2/gl/math.c libykneomgr-0.0.2/gl/xsize.c libykneomgr-0.0.2/lib/des.c libykneomgr-0.0.2/lib/des.h libykneomgr-0.0.2/src/cmdline.c libykneomgr-0.0.2/src/cmdline.h
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Provides: bundled(gnulib) in place as required. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "LGPL (v3 or later)", "LGPL (v2 or later)". 6 files have unknown license. Detailed output of licensecheck in /tmp/1076260-libykneomgr/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gtk-doc, /usr/share /gtk-doc/html [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libykneomgr-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libykneomgr-0.0.2-2.fc20.x86_64.rpm libykneomgr-devel-0.0.2-2.fc20.x86_64.rpm libykneomgr-0.0.2-2.fc20.src.rpm libykneomgr-devel.x86_64: W: no-documentation libykneomgr.src:12: W: unversioned-explicit-provides bundled(gnulib) libykneomgr.src:46: W: macro-in-comment %{_libdir} libykneomgr.src:47: W: macro-in-comment %{_libdir} libykneomgr.src:55: W: macro-in-comment %{_libdir} libykneomgr.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint libykneomgr-devel libykneomgr libykneomgr-devel.x86_64: W: no-documentation libykneomgr.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libykneomgr.so.0.0.2 /lib64/libz.so.1 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- libykneomgr-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libykneomgr libykneomgr.so.0()(64bit) libykneomgr (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpcsclite.so.1()(64bit) libykneomgr.so.0()(64bit) libykneomgr.so.0(YKNEOMGR_0.0.0)(64bit) libz.so.1()(64bit) libzip.so.2()(64bit) rtld(GNU_HASH) Provides -------- libykneomgr-devel: libykneomgr-devel libykneomgr-devel(x86-64) pkgconfig(ykneomgr) libykneomgr: bundled(gnulib) libykneomgr libykneomgr(x86-64) libykneomgr.so.0()(64bit) libykneomgr.so.0(YKNEOMGR_0.0.0)(64bit) Source checksums ---------------- http://opensource.yubico.com/libykneomgr/releases/libykneomgr-0.0.2.tar.gz : CHECKSUM(SHA256) this package : 14be68c94edcf1307847dd74649eb276171e3a311a5e103241393e6ef80fa1da CHECKSUM(SHA256) upstream package : 14be68c94edcf1307847dd74649eb276171e3a311a5e103241393e6ef80fa1da Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1076260 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Sorry, meant to leave comments with the above review. Per our conversation on IRC, the license needs to be updated to GPLv2+ at least. I'd have to confirm with someone in the know if you have to include the LGPLvX in the SPEC as well. Also, need to fix the macro use in the SPEC file. Otherwise, didn't find any major problems with the package.
Updated to GPLv3+ which is compatible with all the licenses involved. LGPL is a more permissive license than GPL so any code licensed under LGPL may be combined with GPL and released as a whole under GPL. I added %{name} and %{version} to URL and Source0 and don't intend to use it any other places. I checked the packaging guidelines and the MUST for using directory macros is only for libdir and suggested for bindir, etc. It is not required to use %{name} and %{version}, etc. Same URLS for the SRPM and SPEC
%{_mandir}/man1/ykneomgr.1.gz --> %{_mandir}/man1/ykneomgr.1*
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Provides: bundled(gnulib) in place as required. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "LGPL (v3 or later)", "LGPL (v2 or later)". 6 files have unknown license. Detailed output of licensecheck in /tmp/1076260-libykneomgr/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gtk-doc, /usr/share /gtk-doc/html [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libykneomgr-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libykneomgr-0.0.2-2.fc20.x86_64.rpm libykneomgr-devel-0.0.2-2.fc20.x86_64.rpm libykneomgr-0.0.2-2.fc20.src.rpm libykneomgr-devel.x86_64: W: no-documentation libykneomgr.src:13: W: unversioned-explicit-provides bundled(gnulib) 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint libykneomgr-devel libykneomgr libykneomgr-devel.x86_64: W: no-documentation libykneomgr.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libykneomgr.so.0.0.2 /lib64/libz.so.1 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- libykneomgr-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libykneomgr libykneomgr.so.0()(64bit) libykneomgr (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libpcsclite.so.1()(64bit) libykneomgr.so.0()(64bit) libykneomgr.so.0(YKNEOMGR_0.0.0)(64bit) libz.so.1()(64bit) libzip.so.2()(64bit) rtld(GNU_HASH) Provides -------- libykneomgr-devel: libykneomgr-devel libykneomgr-devel(x86-64) pkgconfig(ykneomgr) libykneomgr: bundled(gnulib) libykneomgr libykneomgr(x86-64) libykneomgr.so.0()(64bit) libykneomgr.so.0(YKNEOMGR_0.0.0)(64bit) Source checksums ---------------- http://opensource.yubico.com/libykneomgr/releases/libykneomgr-0.0.2.tar.gz : CHECKSUM(SHA256) this package : 14be68c94edcf1307847dd74649eb276171e3a311a5e103241393e6ef80fa1da CHECKSUM(SHA256) upstream package : 14be68c94edcf1307847dd74649eb276171e3a311a5e103241393e6ef80fa1da
New Package SCM Request ======================= Package Name: libykneomgr Short Description: Yubico YubiKey NEO Manager C Library Owners: nb Branches: f19 f20 el6 InitialCC:
New Package SCM Request ======================= Package Name: libykneomgr Short Description: Yubico YubiKey NEO Manager C Library Owners: nb Branches: f19 f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
*** Bug 1081616 has been marked as a duplicate of this bug. ***
Version 0.1.2 is available; Issues: 1. Group: Development/Libraries Main package doesn't have group anymore, why leave it in -devel subpackage still? 2. Requires: %{name} = %{version}-%{release} Please! Be careful: Requires: %{name}%{?_isa} = %{version}-%{release} 3. Remove rm -rf $RPM_BUILD_ROOT
Sorry for the dupe. I think you filed this right after I started working on my version. libykneomgr-0.0.2 should not pass review due to license and bundled library issues. See https://github.com/Yubico/libykneomgr/issues/8. Please also fix the rm -rf thing and get rid of chrpath. See my version or the packaging guidelines for a better fix.
I'd also be happy to co-maintain this if you want a co-maintainer.
(In reply to Andy Lutomirski from comment #13) > Sorry for the dupe. I think you filed this right after I started working on > my version. > > libykneomgr-0.0.2 should not pass review due to license and bundled library > issues. See https://github.com/Yubico/libykneomgr/issues/8. Actually it should be an exception like md5, but since gnulib provides the same function we should adopt the fix. :) I'm thinking about that Fedora should encourage using gnulib for providing crypto functions.
That's why I wrote the fix :) Bumping to 0.1.2 should be sufficient. (Note that it's not just a bundling issue -- those files are missing a license.)
libykneomgr-0.1.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libykneomgr-0.1.2-1.fc20
libykneomgr-0.1.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libykneomgr-0.1.2-1.fc19
libykneomgr-0.1.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libykneomgr-0.1.2-1.el6
Andy, feel free to apply for commit acl in pkgdb. I will approve it. I have made all the changes mentioned in this bug.
libykneomgr-0.1.2-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
libykneomgr-0.1.2-1.fc19 has been pushed to the Fedora 19 stable repository.
libykneomgr-0.1.2-1.fc20 has been pushed to the Fedora 20 stable repository.
libykneomgr-0.1.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.