Bug 1076448 - Review Request: darkstat - Network traffic analyzer
Summary: Review Request: darkstat - Network traffic analyzer
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christopher Meng
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-14 11:15 UTC by Pavel Alexeev
Modified: 2014-05-09 11:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-05-09 11:22:53 UTC
Type: ---
Embargoed:
i: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Pavel Alexeev 2014-03-14 11:15:16 UTC
Spec URL: https://raw.github.com/Hubbitus/Fedora-packaging/bfd2a94b3565966103e7885c93326710abdd5fcf/SPECS/darkstat.spec
SRPM URL: http://hubbitus.info/rpm/Fedora20/darkstat/darkstat-3.0.718-1.fc20.src.rpm
Description: darkstat is a network traffic analyzer. It's basically a packet sniffer which runs as a background process on a cable/DSL router and gathers
all sorts of useless but interesting statistics.
Fedora Account System Username: hubbitus

Comment 1 Christopher Meng 2014-04-23 06:43:06 UTC
1. Systemd service file missing, please create one.

2. %doc %{_mandir}/man8/darkstat.8*

No %doc please.

3. %attr(755,-,-) %{_sbindir}/darkstat

Why attr()? Can you do that in %install?

4. It should have its own user and group.

5. Drop the group tag if you want.

Comment 2 Pavel Alexeev 2014-04-24 16:34:56 UTC
> Why attr()? Can you do that in %install?
Sure. But main script don't do that. And I think %attr created for that purpose, is not?

>5. Drop the group tag if you want.
Why?

Changes: https://github.com/Hubbitus/Fedora-packaging/commit/e499ca72c70181d06b5a630148d3018b3f2dca34
Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/e499ca72c70181d06b5a630148d3018b3f2dca34/SPECS/darkstat.spec
Srpm: http://hubbitus.info/rpm/Fedora20/darkstat/darkstat-3.0.718-2.fc20.src.rpm

Comment 3 Christopher Meng 2014-04-25 04:00:13 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 45 files have
     unknown license. Detailed output of licensecheck:

BSD (2 clause)
--------------
darkstat-3.0.718/tree.h

BSD (3 clause)
--------------
darkstat-3.0.718/bsd.c
darkstat-3.0.718/queue.h

Unknown or generated
--------------------
darkstat-3.0.718/acct.c
darkstat-3.0.718/acct.h
darkstat-3.0.718/addr.c
darkstat-3.0.718/addr.h
darkstat-3.0.718/bsd.h
darkstat-3.0.718/cap.c
darkstat-3.0.718/cap.h
darkstat-3.0.718/cdefs.h
darkstat-3.0.718/contrib/darkproxy.php
darkstat-3.0.718/conv.c
darkstat-3.0.718/conv.h
darkstat-3.0.718/darkstat.c
darkstat-3.0.718/daylog.c
darkstat-3.0.718/daylog.h
darkstat-3.0.718/db.c
darkstat-3.0.718/db.h
darkstat-3.0.718/decode.c
darkstat-3.0.718/decode.h
darkstat-3.0.718/dns.c
darkstat-3.0.718/dns.h
darkstat-3.0.718/err.c
darkstat-3.0.718/err.h
darkstat-3.0.718/graph_db.c
darkstat-3.0.718/graph_db.h
darkstat-3.0.718/graphjs.h
darkstat-3.0.718/hosts_db.c
darkstat-3.0.718/hosts_db.h
darkstat-3.0.718/hosts_sort.c
darkstat-3.0.718/html.c
darkstat-3.0.718/html.h
darkstat-3.0.718/http.c
darkstat-3.0.718/http.h
darkstat-3.0.718/localip.c
darkstat-3.0.718/localip.h
darkstat-3.0.718/ncache.c
darkstat-3.0.718/ncache.h
darkstat-3.0.718/now.c
darkstat-3.0.718/now.h
darkstat-3.0.718/opt.h
darkstat-3.0.718/pidfile.c
darkstat-3.0.718/pidfile.h
darkstat-3.0.718/static/c-ify.c
darkstat-3.0.718/str.c
darkstat-3.0.718/str.h
darkstat-3.0.718/stylecss.h

[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: darkstat-3.0.718-2.fc21.i686.rpm
          darkstat-3.0.718-2.fc21.src.rpm
darkstat.i686: E: missing-call-to-setgroups /usr/sbin/darkstat
darkstat.i686: E: missing-call-to-chdir-with-chroot /usr/sbin/darkstat
darkstat.i686: W: only-non-binary-in-usr-lib
darkstat.i686: W: non-standard-uid /etc/sysconfig/darkstat darkstat
darkstat.i686: E: non-readable /etc/sysconfig/darkstat 0600L
darkstat.i686: E: incorrect-fsf-address /usr/share/doc/darkstat/COPYING.GPL
darkstat.src: W: strange-permission darkstat.sysconfig 0600L
2 packages and 0 specfiles checked; 4 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint darkstat
darkstat.i686: E: missing-call-to-setgroups /usr/sbin/darkstat
darkstat.i686: E: missing-call-to-chdir-with-chroot /usr/sbin/darkstat
darkstat.i686: W: only-non-binary-in-usr-lib
darkstat.i686: W: non-standard-uid /etc/sysconfig/darkstat darkstat
darkstat.i686: E: non-readable /etc/sysconfig/darkstat 0600L
darkstat.i686: E: incorrect-fsf-address /usr/share/doc/darkstat/COPYING.GPL
1 packages and 0 specfiles checked; 4 errors, 2 warnings.
# echo 'rpmlint-done:'



Requires
--------
darkstat (rpmlib, GLIBC filtered):
    /bin/sh
    config(darkstat)
    libc.so.6
    libpcap.so.1
    libz.so.1
    rtld(GNU_HASH)
    systemd



Provides
--------
darkstat:
    config(darkstat)
    darkstat
    darkstat(x86-32)



Source checksums
----------------
http://unix4lyfe.org/darkstat/darkstat-3.0.718.tar.bz2 :
  CHECKSUM(SHA256) this package     : 682f3e53f4e89ea6ad08236b4225a5e0859428299765d8d995374cd7fa22adff
  CHECKSUM(SHA256) upstream package : 682f3e53f4e89ea6ad08236b4225a5e0859428299765d8d995374cd7fa22adff


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -rvn darkstat-3.0.718-2.fc20.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

--------------------------------------------
1. Pass --disable-silent-rules to %configure, current build log:

  CC     acct.o
  CC     addr.o
  CC     bsd.o
  CC     cap.o
  CC     conv.o
  CC     darkstat.o
  CC     daylog.o
  CC     db.o

[...]

2. darkstat.i686: E: missing-call-to-setgroups /usr/sbin/darkstat
darkstat.i686: E: missing-call-to-chdir-with-chroot /usr/sbin/darkstat
darkstat.i686: W: only-non-binary-in-usr-lib
darkstat.i686: W: non-standard-uid /etc/sysconfig/darkstat darkstat
darkstat.i686: E: non-readable /etc/sysconfig/darkstat 0600L
darkstat.i686: E: incorrect-fsf-address /usr/share/doc/darkstat/COPYING.GPL
darkstat.src: W: strange-permission darkstat.sysconfig 0600L

Fix all above.

3. Group tag is optional, so you can remove it. BUT it's controlled by you.

Comment 4 Pavel Alexeev 2014-04-25 08:01:52 UTC
Issue with missing-call-to-chdir-with-chroot mailed to author, I got answer from author about it will be investigated but no one about results. Is it stop issue?


incorrect-fsf-address issue addressed http://unix4lyfe.org/gitweb/darkstat/commitdiff/82f0e5a22556aaca177809233443dd670d19f577 but no releases was make still. Do you prefer packaging git master branch?

So, only issue to add --disable-silent-rules into %configure option left?

Comment 5 Christopher Meng 2014-04-25 08:27:03 UTC
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #4)
> Issue with missing-call-to-chdir-with-chroot mailed to author, I got answer
> from author about it will be investigated but no one about results. Is it
> stop issue?

No.

> incorrect-fsf-address issue addressed
> http://unix4lyfe.org/gitweb/darkstat/commitdiff/
> 82f0e5a22556aaca177809233443dd670d19f577 but no releases was make still. Do
> you prefer packaging git master branch?

No. I'm sure the upstream nitpick will release a new version soon.

> So, only issue to add --disable-silent-rules into %configure option left?

Yes.

nitpick:

$ rpmlint -I missing-call-to-chdir-with-chroot
missing-call-to-chdir-with-chroot:
This executable appears to call chroot without using chdir to change the
current directory. This is likely an error and permits an attacker to break
out of the chroot by using fchdir. While that's not always a security issue,
this has to be checked.

---------------------------------------------
PACKAGE APPROVED.

Comment 6 Pavel Alexeev 2014-04-25 13:24:45 UTC
For what --disable-silent-rules needed? I have not seen any differences at first glance.

Comment 7 Christopher Meng 2014-04-25 13:35:21 UTC
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #6)
> For what --disable-silent-rules needed? I have not seen any differences at
> first glance.

If you don't do that, the compiler/liker flags are hidden, we ca't know if they are built correctly.

Comment 8 Pavel Alexeev 2014-04-25 13:37:16 UTC
Christopher thank you very much for the review. And please say if you willing I review some of your packages. I've check several but not found any with working URLs.

New Package SCM Request
=======================
Package Name: darkstat
Short Description: Network traffic analyzer
Owners: hubbitus
Branches: f19 f21 f21 epel7
InitialCC:

Comment 9 Christopher Meng 2014-04-25 13:42:26 UTC
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #8)
> Christopher thank you very much for the review. And please say if you
> willing I review some of your packages. I've check several but not found any
> with working URLs.

They have been moved to misc.cicku.me but I haven't enabled the service so they can't be accessed now.

I will update these bugs when they are ready, don't worry.

Comment 10 Gwyn Ciesla 2014-04-25 14:22:42 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-04-25 15:35:37 UTC
darkstat-3.0.718-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/darkstat-3.0.718-3.fc19

Comment 12 Fedora Update System 2014-04-25 15:51:40 UTC
darkstat-3.0.718-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/darkstat-3.0.718-3.fc20

Comment 13 Fedora Update System 2014-05-06 03:30:38 UTC
darkstat-3.0.718-3.fc20 has been pushed to the Fedora 20 stable repository.

Comment 14 Fedora Update System 2014-05-06 03:38:55 UTC
darkstat-3.0.718-3.fc19 has been pushed to the Fedora 19 stable repository.


Note You need to log in before you can comment on or make changes to this bug.