Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1076503

Summary:	VIR_DOMAIN_XML_MIGRATABLE generates unmigratable XML
Product:	Red Hat Enterprise Linux 7	Reporter:	Jiri Denemark <jdenemar>
Component:	libvirt	Assignee:	Jiri Denemark <jdenemar>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	acathrow, dallan, dyuan, hannsj_uhl, jdenemar, mprivozn, mriedem, mzhan, sross, ydu, zpeng
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-1.1.1-28.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	994364	Environment:
Last Closed:	2014-06-13 10:42:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	994364
Bug Blocks:

Description Jiri Denemark 2014-03-14 13:15:10 UTC

+++ This bug was initially created as a clone of Bug #994364 +++

Description of problem:

When using `virsh dumpxml e35422fa-18e7-41eb-8478-d09daff1b43a --migratable > dump-migratable.xml` to generate an XML to be used for migration, the 'pci-root' is missing compared to a plain `virsh dumpxml` or a `virsh dumpxml ... --security-info`:

       <alias name='virtio-serial0'/>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
     </controller>
-    <controller type='pci' index='0' model='pci-root'>
-      <alias name='pci0'/>
-    </controller>
     <interface type='bridge'>
       <mac address='52:54:00:8c:20:df'/>
       <source bridge='vmbr0'/>

This results in the following error when trying to use that XML for migration:

~ # virsh migrate --live --p2p --tunnelled --persistent --undefinesource --change-protection --verbose --compressed e35422fa-18e7-41eb-8478-d09daff1b43a 'qemu+tcp://10.1.130.14/system' --xml /tmp/new.xml 
error: unsupported configuration: Target controller type ide does not match source pci

This issue can also be reproduced on RHEL-7 with libvirt-1.1.1-27.el7.

--- Additional comment from Jiri Denemark on 2013-10-04 07:27:19 UTC ---

Oops, I guess I know what it is. While the --migratable XML is supposed to be the same as what we sent normally during migration, the xmlin definition is not checked against the migratable XML. It's checked against normal XML and thus the ABI check fails.

--- Additional comment from Michal Privoznik on 2013-10-11 08:49:31 UTC ---

So I've just pushed the patch upstream:

commit 7d704812b9c50cd3804dd1e7f9e2ea3e75fdc847
Author:     Michal Privoznik <mprivozn>
AuthorDate: Thu Oct 10 10:53:56 2013 +0200
Commit:     Michal Privoznik <mprivozn>
CommitDate: Fri Oct 11 10:31:35 2013 +0200

    qemu: Introduce qemuDomainDefCheckABIStability
    
    https://bugzilla.redhat.com/show_bug.cgi?id=994364
    
    Whenever we check for ABI stability, we have new xml (e.g. provided by
    user, or obtained from snapshot, whatever) which we compare to old xml
    and see if ABI won't break. However, if the new xml was produced via
    virDomainGetXMLDesc(..., VIR_DOMAIN_XML_MIGRATABLE) it lacks some
    devices, e.g. 'pci-root' controller. Hence, the ABI stability check
    fails even though it is stable. Moreover, we can't simply fix
    virDomainDefCheckABIStability because removing the correct devices is
    task for the driver. For instance, qemu driver wants to remove the usb
    controller too, while LXC driver doesn't. That's why we need special
    qemu wrapper over virDomainDefCheckABIStability which removes the
    correct devices from domain XML, produces MIGRATABLE xml and calls the
    check ABI stability function.
    
    Signed-off-by: Michal Privoznik <mprivozn>

Comment 4 zhe peng 2014-03-19 09:42:29 UTC

I can reproduce this with libvirt-1.1.1-27.el7
verify with libvirt-1.1.1-28.el7

step:
1: prepare migrate env.
2: prepare a guest on source machine.
3: #virsh dumpxml test --migratable > test.xml
4: migrate guest
  # virsh migrate --live --p2p --tunnelled --persistent test qemu+ssh://10.66.6.169/system --xml test.xml --verbose
Migration: [100 %]
5: check guest on DST:
 #virsh dumpxml test
....
  <controller type='pci' index='0' model='pci-root'>
      <alias name='pci.0'/>
    </controller>
....

move to verified.

Comment 5 Ludek Smid 2014-06-13 10:42:07 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.

Comment 7 Matt Riedemann 2014-09-24 16:21:32 UTC

Any chance this will be backported to RHEL 6.5?