Bug 1076549 - numatop_linux_1.0.3 is available
Summary: numatop_linux_1.0.3 is available
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: numatop
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dridi Boukelmoune
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-14 14:22 UTC by Upstream Release Monitoring
Modified: 2014-08-25 15:13 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-08-25 15:00:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Upstream Release Monitoring 2014-03-14 14:22:00 UTC
Latest upstream release: 1.0.2
Current version/release in Fedora Rawhide: 1.0.1-5.fc21
URL: http://01.org/numatop

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at:
https://fedoraproject.org/wiki/Upstream_release_monitoring

Comment 1 Dridi Boukelmoune 2014-04-08 05:57:05 UTC
This version doesn't include the patches merged upstream [1,2] after numatop 1.0.1 and nothing has changed on github since they got merged.

I'll try to get in touch with upstream.

[1] https://github.com/01org/numatop/commit/f65d5ef
[2] https://github.com/01org/numatop/commit/5506e43

Comment 2 Zbigniew Jędrzejewski-Szmek 2014-04-24 23:47:23 UTC
(In reply to Dridi Boukelmoune from comment #1)
> I'll try to get in touch with upstream.
Any progress on that? I looked at the ML, and it seems completely dead.

Comment 3 Upstream Release Monitoring 2014-08-08 09:48:06 UTC
Latest upstream release: 1.0.3.tar_0.gz">numatop_linux_1.0.3
Current version/release in Fedora Rawhide: 1.0.2-3.fc21
URL: http://01.org/numatop

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at:
https://fedoraproject.org/wiki/Upstream_release_monitoring

Comment 4 Zbigniew Jędrzejewski-Szmek 2014-08-08 13:21:30 UTC
I requested commit ACLs to push this update.

Comment 5 Dridi Boukelmoune 2014-08-18 20:55:56 UTC
Hi,

I'm back from holidays (in case you didn't see it) and I'm catching up. I've seen your ACLs requests but I'd rather check what's in 1.0.3 first. That is because 1.0.2 was such a mess, and I still have pending questions that will probably never see answers from upstream :(

https://github.com/01org/numatop/issues/8#issuecomment-47621823

My main issue with numatop currently is the quality of source tarballs and repositories. So for this update I'd rather be careful and check before pushing anything.

Gimme a few days, I'm still a bit jet-lagged :)

Comment 6 Zbigniew Jędrzejewski-Szmek 2014-08-18 21:11:48 UTC
(In reply to Dridi Boukelmoune from comment #5)
> Hi,
> 
> I'm back from holidays (in case you didn't see it) and I'm catching up. I've
> seen your ACLs requests but I'd rather check what's in 1.0.3 first. That is
> because 1.0.2 was such a mess, and I still have pending questions that will
> probably never see answers from upstream :(
> 
> https://github.com/01org/numatop/issues/8#issuecomment-47621823
Your patches seem to have been committed. The tarball corresponds to https://github.com/01org/numatop/commit/444b0965cd9f598a0fb2c701c8b2ba90375a9a20.

> My main issue with numatop currently is the quality of source tarballs and
> repositories. So for this update I'd rather be careful and check before
> pushing anything.
They look kosher.
 
> Gimme a few days, I'm still a bit jet-lagged :)
NP.

Comment 7 Dridi Boukelmoune 2014-08-21 17:50:53 UTC
How do I download the tarball you've uploaded to the lookaside cache ? md5sum doesn't match with upstream's (once again inconsistent) archive, and I want to diff them (with github's current tree too).

My memory is blank right now, and "fedpkg sources" doesn't seem to download it (note to self, fedpkg(1) is broken).

Comment 8 Dridi Boukelmoune 2014-08-22 12:42:32 UTC
Upstream's tarball seems to match the latest commit on github (f1a317d), that's good news.

Comment 9 Dridi Boukelmoune 2014-08-22 15:41:02 UTC
I've finally figured why `fedpkg sources` didn't download the sources, and my brain seems to be fully functioning :)

I have the following diff between upstream's and your tarball; where did you get those sources from?

===
$ diff -ur upstream/ zbigniew/
Only in upstream/: kernel_patches
diff -ur upstream/README zbigniew/README
--- upstream/README	2014-08-08 03:30:15.000000000 +0200
+++ zbigniew/README	2014-08-07 07:27:36.000000000 +0200
@@ -21,12 +21,9 @@
 
 Kernel Requirement:
 ------------------
-Recommended kernel: 3.16
+Kernel: 3.13+
 
-For Haswell supporting, please also apply a perf patch on 3.16. The patch
-is numatop/kernel_patches/0001-perf-x86-Widen-Haswell-OFFCORE-mask.patch.
-
-The patch can also be found at following link:
+For Haswell supporting, please also apply the following perf patch in kernel.
 http://www.gossamer-threads.com/lists/linux/kernel/1964864
 
 Directories
@@ -39,8 +36,6 @@
         generate memory access with runtime latency value among CPUs.
         Note that this application is only used for numatop testing!
 
-kernel_patches: the required kernel patches.
-
 Note:
 -----
 numatop is supported on Intel Xeon processors: 5500-series, 6500/7500-series,
===

After a quick search I couldn't find their patch in our kernel (3.15.10-200) neither in the source tree nor in the src.rpm patches.

WDYT?

Comment 10 Zbigniew Jędrzejewski-Szmek 2014-08-22 17:26:51 UTC
The top six commits in the github repo are:

* f1a317da5a Add perf patch to support Haswell    <------- that's the tarball
* c79e07b988 Update README with patch info
* 444b0965cd Change README                        <------- I used this one
* d4192eb675 Add HSX support
* e0177ca3fd Add IVB-EX support
* 5506e43f57 Merge pull request #5 from Dridi/master

IMHO it doesn't matter which one we use, since they only differ in "documentation". It later one is probably better.

As for the patch, I'd simply wait. If Andi Kleen is working on it, I'm pretty sure it'll land in master rather quickly.

Comment 11 Dridi Boukelmoune 2014-08-23 07:41:12 UTC
In this case, I'd rather use upstream's tarball and submit the kernel patch to Fedora's kernel maintainers. This way numatop could immediately use the haswell-specific bits.

Comment 12 Zbigniew Jędrzejewski-Szmek 2014-08-25 15:00:26 UTC
(In reply to Dridi Boukelmoune from comment #11)
> In this case, I'd rather use upstream's tarball and submit the kernel patch
> to Fedora's kernel maintainers.
I uploaded the upstream tarball, but I'm not sure about the patch. There was a reply on the ML which raised an issue which wasn't resolved, so I think it is better to wait until upstream merges the patch.

Comment 13 Dridi Boukelmoune 2014-08-25 15:13:44 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
> I uploaded the upstream tarball, but I'm not sure about the patch. There was
> a reply on the ML which raised an issue which wasn't resolved, so I think it
> is better to wait until upstream merges the patch.

Sounds good, thank you for the update!


Note You need to log in before you can comment on or make changes to this bug.