Description of problem: When I was setting up the hosted engine I made a cut'n'paste error while copying the VM's MAC address - I added a space to it. The script printed out a warning: Invalid mac address specified: 00:16:3e:72:20:7f but it wasn't obvious what's wrong, if it was surrounded by single quotes it would be visible on first sight. Version-Release number of selected component (if applicable): ovirt-hosted-engine-setup-1.1.1-1.fc19.noarch How reproducible: 100% Steps to Reproduce: 1. input a mac address with trailing or starting space 2. 3. Actual results: Invalid mac address specified: 00:16:3e:72:20:7f Expected results: Invalid mac address specified: ' 00:16:3e:72:20:7f'
Cannot we also simply trim that input just to avoid it?
(In reply to Simone Tiraboschi from comment #1) > Cannot we also simply trim that input just to avoid it? Yes, I think so.
(In reply to Sandro Bonazzola from comment #2) > (In reply to Simone Tiraboschi from comment #1) > > Cannot we also simply trim that input just to avoid it? > > Yes, I think so. It's a good practice to enclose the variable value when printing it. Even though trimming would solve this specific issue enclosing the value in quotes might still be helpful.
This bug was fixed and is slated to be in the upcoming version. As we are focusing our testing at this phase on severe bugs, this bug was closed without going through its verification step. If you think this bug should be verified by QE, please set its severity to high and move it back to ON_QA