Bug 1077024 - Content Spec defined publican.cfg values should probably be omitted
Summary: Content Spec defined publican.cfg values should probably be omitted
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: PressGang CCMS
Classification: Community
Component: ImportTool
Version: 1.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.5
Assignee: Matthew Casperson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-17 03:07 UTC by Lee Newson
Modified: 2014-08-04 22:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-05-01 21:39:58 UTC
Embargoed:


Attachments (Terms of Use)
Image showing multiple notes being displayed (159.25 KB, image/png)
2014-04-02 03:28 UTC, Lee Newson
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1082932 0 unspecified NEW Content Specs should warn that certain publican.cfg parameters will be removed 2023-02-21 23:19:48 UTC

Internal Links: 1082932

Description Lee Newson 2014-03-17 03:07:40 UTC
Currently the import tool imports the publican.cfg as is, however it should probably remove these four values to avoid confusion:

xml_lang
brand
type
dtd_ver

The above values will always be removed from the regular publican.cfg and will be replaced by the values from "Brand", "Type", "Format" and the content spec target locale when building.

Comment 1 Matthew Casperson 2014-03-17 03:40:23 UTC
Fixed in 201403171339

The following are ignored:

xml_lang
brand
type
dtdver

Comment 2 Lee Newson 2014-04-01 06:41:14 UTC
The values are not removed and are just commented out. Since they will never be useful (except in custom configs, ie: beta-publican.cfg), they should be removed (probably with a note at the end of the import saying that they were removed and why).

Also we should probably include that warning during the validation process as well, so I'll create a bug for that in a second.

In the case that you don't want to remove them, then it would be better left as is and the above should take care of it.

Comment 3 Matthew Casperson 2014-04-02 00:29:51 UTC
Fixed in 201404021024

I'll leave the values commented out because things like different brands in secondary config files have no equivalent field in the content spec. This way the original source information is present and can be retrieved later on if needed.

A message is display when the import has finished notifying the user that some fields have been commented out.

Comment 4 Lee Newson 2014-04-02 02:27:53 UTC
Verified that a message is displayed when the import has been completed.

Comment 5 Matthew Casperson 2014-04-02 02:57:40 UTC
I've undone these changes. Now only the publican.cfg file will have redundant fields removed. Secondary config files have all fields added.

Comment 6 Lee Newson 2014-04-02 03:28:33 UTC
Created attachment 881600 [details]
Image showing multiple notes being displayed

I got this before when uploading a book, so I'm just logging it as a reference. Since I've only seen it once, I'm not going to set this back to ASSIGNED until I see it again.

Comment 7 Lee Newson 2014-04-02 05:12:16 UTC
The warning isn't shown when importing from a directory. Since this isn't actually supported yet I'm just making a note of it here.

Comment 8 Matthew Casperson 2014-04-02 05:17:26 UTC
All the warnings should have been removed. If you see any then it is a bug.

Comment 9 Lee Newson 2014-04-02 05:21:14 UTC
Right sorry I misunderstood your comment earlier. I thought you meant that you undid the changes for the additional files and left the root one as it was.

In that case marking this as VERIFIED.


Note You need to log in before you can comment on or make changes to this bug.