Bug 1077126 - Recent commit fixes two major bugs.
Summary: Recent commit fixes two major bugs.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: printrun
Version: 20
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-17 09:58 UTC by Neil Darlow
Modified: 2014-03-26 05:30 UTC (History)
1 user (show)

Fixed In Version: printrun-2014.01.26-2.fc20
Clone Of:
Environment:
Last Closed: 2014-03-21 09:34:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Neil Darlow 2014-03-17 09:58:49 UTC
Description of problem:
A recent commit https://github.com/kliment/Printrun/commit/36eff4ab1f33da4774d2a97403674b7500fbae5c fixes two very obvious bugs:
1) The "duration attribute" traceback when uploading a file to SD card.
2) The GCode viewer not working.
This is a single line of code moved from one file to another.

Version-Release number of selected component (if applicable):
2014.01.26-1.fc20

How reproducible:
Every time.

Steps to Reproduce:
1. Use pronterface and observe the above bugs. They are quite obvious.

Actual results:
Without the commit the bugs are evident.

Expected results:
With the commit applied neither of the above bugs are observed. Functionality is restored.

Additional info:
Commit tested on fedora-20.x86_64.

Comment 1 Miro Hrončok 2014-03-17 11:49:40 UTC
1) I don't have a SD card reader in my printer
2) GCode viewer works just fine for me in 2D and in 3D

printrun-2014.01.26-1.fc20.x86_64

I can use that patch, as I guess it cannot do any harm.

Is there any upstream issue related to this?

Comment 2 Neil Darlow 2014-03-17 13:11:00 UTC
#450, although for Windows, references the duration calculation error.

I think this was more of a Developer walking through the code and noticing the line of code that was moved in error.

Comment 3 Fedora Update System 2014-03-17 17:25:20 UTC
printrun-2014.01.26-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/printrun-2014.01.26-2.fc19

Comment 4 Fedora Update System 2014-03-17 17:26:26 UTC
printrun-2014.01.26-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/printrun-2014.01.26-2.fc20

Comment 5 Fedora Update System 2014-03-18 08:09:13 UTC
Package printrun-2014.01.26-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing printrun-2014.01.26-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-3992/printrun-2014.01.26-2.fc20
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2014-03-21 09:34:50 UTC
printrun-2014.01.26-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2014-03-26 05:30:50 UTC
printrun-2014.01.26-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.