Bug 1077392 (kfilemetadata) - Review Request: kfilemetadata - A library for extracting file metadata
Summary: Review Request: kfilemetadata - A library for extracting file metadata
Keywords:
Status: CLOSED RAWHIDE
Alias: kfilemetadata
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews baloo baloo-widgets
TreeView+ depends on / blocked
 
Reported: 2014-03-17 21:38 UTC by Rex Dieter
Modified: 2014-03-18 14:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-18 14:00:15 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2014-03-17 21:38:40 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kde/kfilemetadata.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kde/kfilemetadata-4.12.90-1.fc20.src.rpm
Description: A library for extracting file metadata
Fedora Account System Username: rdieter

Comment 1 Rex Dieter 2014-03-17 21:39:24 UTC
needed for kde-4.12.90

Comment 2 Kevin Kofler 2014-03-17 22:05:23 UTC
A -libs subpackage strikes me as not very useful for this package, which is a library. The plugins are best shipped together with the library; if a package needs the 32-bit library, it also needs the 32-bit plugins.

Comment 3 Rex Dieter 2014-03-18 01:31:59 UTC
OK, 

Spec URL: http://rdieter.fedorapeople.org/rpms/kde/kfilemetadata.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kde/kfilemetadata-4.12.90-2.fc20.src.rpm

%changelog
* Mon Mar 17 2014 Rex Dieter <rdieter> 4.12.90-2
- drop -libs subpkg

Comment 4 Jan Grulich 2014-03-18 09:18:12 UTC
I'm not able to build it using fedora-review, but the package looks ok to me.

[jgrulich@localhost downloads]$ rpmlint kfilemetadata-4.12.90-1.fc20.src.rpm 
kfilemetadata.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, metatarsal
kfilemetadata.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
kfilemetadata.src:44: W: macro-in-comment %{name}
kfilemetadata.src:44: W: macro-in-comment %{version}
kfilemetadata.src:44: W: macro-in-comment %{release}
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

Going throught review guidelines I see that the package meets all MUST and SHOULD criteria.

Comment 5 Rex Dieter 2014-03-18 12:30:44 UTC
New Package SCM Request
=======================
Package Name: kfilemetadata
Short Description: A library for extracting file metadata
Owners: rdieter,jgrulich,jreznik,kkofler,ltinkl,nucleo,rnovacek,than
Branches: f20
InitialCC:

Comment 6 Gwyn Ciesla 2014-03-18 12:56:39 UTC
Git done (by process-git-requests).

Comment 7 Rex Dieter 2014-03-18 14:00:15 UTC
imported


Note You need to log in before you can comment on or make changes to this bug.