Bug 1077917 - EFI System partition in /etc/fstab should have fspassno set to 2
Summary: EFI System partition in /etc/fstab should have fspassno set to 2
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-blivet
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: mulhern
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-18 20:06 UTC by Chris Murphy
Modified: 2015-06-23 15:57 UTC (History)
11 users (show)

Fixed In Version: python-blivet-0.39-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-23 15:57:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Chris Murphy 2014-03-18 20:06:18 UTC
Description of problem: The anaconda produced /etc/fstab contains an entry for the EFI System partition mounted at /boot/efi, and is incorrectly set to 0.


Version-Release number of selected component (if applicable):
anaconda-21.27-1

How reproducible:
Always

Steps to Reproduce:
1. Install to UEFI firmware based computer.


Actual results:
/etc/fstab entry for the EFI System Partition is
UUID=D281-9CE9    /boot/efi      vfat    umask=0077,shortname=winnt 0 0


Expected results:

Last column, fspassno, should be 1.


Additional info:
Tested with fspassno 1, and an ESP with dirty bit set. Systemd-fsck is executed and automatically repairs the volume, boot commences.

Comment 1 Chris Murphy 2014-03-18 22:05:22 UTC
Actually, per man 5 fstab it should be 2.

(And really we shouldn't be mounting the ESP persistently anyway, but that's a separate battle, in the meantime insofar as we are mounting it rw all the time, we should check and repair it at boot time.)

Comment 2 mulhern 2015-01-26 17:10:26 UTC
Evidently we should be setting EFIFS._check to True.

Comment 3 Chris Murphy 2015-03-01 20:21:34 UTC
http://www.freedesktop.org/software/systemd/man/systemd-fstab-generator.html
"The passno field is treated like a simple boolean, and the ordering information is discarded."

So on systemd systems, it doesn't matter if it's a 1 or 2, they're treated the same.

Comment 4 Jaroslav Reznik 2015-03-03 17:11:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22


Note You need to log in before you can comment on or make changes to this bug.