Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1078088

Summary: UserTask Assignments wrong cause process broken
Product: [Retired] JBoss BPMS Platform 6 Reporter: yuli wang <yulwang>
Component: jBPM DesignerAssignee: Tihomir Surdilovic <tsurdilo>
Status: CLOSED CURRENTRELEASE QA Contact: Sona Mala <smala>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0CC: kverlaen, mwinkler, rrajasek, xiabai
Target Milestone: ER2   
Target Release: 6.0.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 19:49:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
what changed none

Description yuli wang 2014-03-19 07:16:53 UTC
Description of problem:
As summary.

Version-Release number of selected component (if applicable):
https://maitai-bpms.app.qa.eng.nay.redhat.com based on BPMS6.0.0

How reproducible:
100%

Steps to Reproduce:
1 Create Process
2 Define Process Variable
2 Design User Task
3 Setting Property of User Task
4 Input some DataInput or DatapOutput parameters
5 Assign UserTask parameters to process variable

Actual Result:
When assign UserTask parameters to process variables in wrong direction (e.g. input parameter on left column and variable on right column), this process is broken, and you cannot open it again.

Expect Result:
the process can work well without exception.
Additional info:

Comment 2 Tihomir Surdilovic 2014-04-10 03:25:18 UTC
Updated the assignments editor significantly to reduce the risk of users being able to make mistakes on data input/output mappings. You can see a screenshot of the changes here : http://i.imgur.com/Gy0HAbG.png

Users now can add specific data input assignment or data output assignment. there is a new column which shows this type for each. the three dropdown menus for the from and to and type columns are dynamic now and show only what users should select. for example for a data input assignment the from dropdown only shows variable definitions and the to shows only data inputs and the type shows "is mapped to" only. which will allow users to now get confused and make mistakes during mapping .

fix in designer master and 6.0.x branches

Comment 3 Sona Mala 2014-04-16 11:09:20 UTC
I am sorry Tiho for a late reaction on your comment #2. This issue was assigned me few hours ago. 

This is a new editor, which does not work properly and which does not support User Experience. I think that logic of assignments is not same as logic in new assignment editor.

I will describe problems in separate bugzilla issues.

Comment 4 Tihomir Surdilovic 2014-04-17 13:49:17 UTC
after comments on BZ https://bugzilla.redhat.com/show_bug.cgi?id=1088345:

fixed added:

6.0.x: https://github.com/droolsjbpm/jbpm-designer/commit/6daa30616 - 6daa30616b2cf0337ae0d8e79824904371f5bed1


master: https://github.com/droolsjbpm/jbpm-designer/commit/3f67b03b27f0e5f1ad0bf31b2a15388967f768f4 - 3f67b03b27f0e5f1ad0bf31b2a15388967f768f4

sorry but this is NOT a new editor. please see the attached screenshot which shows changes:

1. Added two buttons instead of 1 (New Data Input Assignment + New Data Output Assignment instead of just "Add Assignment")
2. Added new column Assignment Type which shows clearly users what type of assignment this is
3. Dropdown data is dynamically populated depending on the assignment type which helps users not to make easy mistakes

That's really it :) This is not a new editor nor has it been significantly updated. It is just small update to existing editor which I think still brings a lot of value to the user and complements other changes we have made to designer such as ability to open the process even if some problems are detected in data input/output mappings (these changes help prevent that tobegin with).

Comment 5 Tihomir Surdilovic 2014-04-17 13:49:40 UTC
Created attachment 887193 [details]
what changed

Comment 6 Sona Mala 2014-05-13 10:40:05 UTC
It was verified for 6.0.2 ER2 BPMS

Data Assignments Editor allows create assignment inputVar->processVar.
   1. create assignment inputVar->inputVar
   2. confirm data assignments editor
   3. open DA editor again
   4. assignment inputVar->inputVar is interpreted as DataOutput and allows to change inputVar to processVar.
During reopening of process the alert is shown and the invalid assignment is removed. So process can be edited again.
























So process is opened as expected.