Description of problem: kexec-tools-2.0.4-23 contains automatic configuration of fence_kdump from Pacemaker configuration. Unfortunately, this support is tightly bound to Pacemaker and cannot be used for other clusters like oVirt. 1) Current status (kexec-tools-2.0.4-23) - when running 'kdumpctl restart' kdump detects if fence_kdump_send command is installed and if so, it tries to: a) Create /etc/fence_kdump_nodes file with list of hosts to send fence_kdump notification to. These hosts are also extracted from cluster configuration using 'pcs cluster' command b) If nodes was successfully extracted from 'pcs cluster' command, kdump tries to configure network to be able to reach all hosts c) Load /etc/sysconfig/fence_kdump file with command line parameters for fence_kdump_send if it exists. d) Install these two config files into kdump's kernel initramfs 2) Proposed status - when running 'kdumpctl restart' kdump detect if fence_kdump_send binary is installed and if so, it tries to: a) It tries to detect is cluster is configured ('pcs' command is available). If so, it execute same process as in 1) b) If cluster is not configured, it tries to detect if /etc/fence_kdump_nodes exists. If so, fence_kdump is marked as successfully configured and kdump continues with steps 1c) and 1d) It would be also nice if whole fence_kdump configuration will exist in the same directory: /etc/fence_kdump /etc/fence_kdump_nodes In this state fence_kdump configuration will comply to FHS. Even Pacemaker could you this generic configuration in future and kexec-tools won't need to parse fence_kdump configuration from Pacemaker configuration. Version-Release number of selected component (if applicable): kexec-tools-2.0.4-23
Created attachment 876252 [details] Patch 1/5
Created attachment 876253 [details] Patch 2/5
Created attachment 876254 [details] Patch 3/5
Created attachment 876255 [details] Patch 4/5
Created attachment 876256 [details] Patch 5/5
Solution proposed above wasn't accepted, so here's new proposal: - Add two new options to kdump.conf fence_kdump_nodes - List of hosts separated by space to send fence_kdump notification to (this option is mandatory to enable fence_kdump) fence_kdump_args - Command line arguments for fence_kdump_send (it can contain all valid arguments except hosts to send notification to) - Modify kdump behavior due to new options 1) If fence_kdump_nodes option is set and fence_kdump_send is found and executable -> configure network for kdump and execute fence_kdump_send with those nodes (and also with args specified in fence_kdump_args if not empty) 2) If fence_kdump_nodes is not set, try to configure fence_kdump using cluster settings (current behavior). This should stay in kexec-tools not to break compatibility and can be removed after Pacemaker will start using new options.
Created attachment 879449 [details] PATCH 1/6 Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE
Created attachment 879461 [details] Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE
Created attachment 879464 [details] PATCH 2/6 Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE
Created attachment 879465 [details] PATCH 3/6 Move fence_kdump nodes filtering into separate function
Created attachment 879466 [details] PATCH 4/6 Rename is_fence_kdump to is_pcs_fence_kdump
Created attachment 879467 [details] PATCH 5/6 Rename check_fence_kdump to check_pcs_fence_kdump
Created attachment 879468 [details] PATCH 6/6 Add fence_kdump support for generic clusters
Created attachment 881288 [details] [PATCH 1/6] Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE
Created attachment 881289 [details] [PATCH 2/6] Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE
Created attachment 881290 [details] [PATCH 3/6] Rename is_fence_kdump to is_pcs_fence_kdump
Created attachment 881291 [details] [PATCH 4/6] Rename kdump_check_fence_kdump to kdump_configure_fence_kdump
Created attachment 881292 [details] [PATCH 5/6] Rename check_fence_kdump to check_pcs_fence_kdump
Created attachment 881293 [details] [PATCH 6/6] Add fence_kdump support for generic clusters
Created attachment 882135 [details] [PATCH 1/7] Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE
Created attachment 882136 [details] [PATCH 2/7] Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE
Created attachment 882137 [details] [PATCH 3/7] Rename is_fence_kdump to is_pcs_fence_kdump
Created attachment 882138 [details] [PATCH 4/7] Rename kdump_check_fence_kdump to kdump_configure_fence_kdump
Created attachment 882140 [details] [PATCH 5/7] Rename check_fence_kdump to check_pcs_fence_kdump
Created attachment 882141 [details] [PATCH 6/7] Add get_option_value()
Created attachment 882142 [details] [PATCH 7/7] Add fence_kdump support for generic clusters