Bug 1078134 - [RFE] Support fence_kdump configuration for generic clusters
Summary: [RFE] Support fence_kdump configuration for generic clusters
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kexec-tools
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Baoquan He
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1079821
TreeView+ depends on / blocked
 
Reported: 2014-03-19 08:42 UTC by Martin Perina
Modified: 2014-04-04 07:12 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-04 07:12:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch 1/5 (1.82 KB, patch)
2014-03-19 09:01 UTC, Martin Perina
no flags Details | Diff
Patch 2/5 (2.07 KB, patch)
2014-03-19 09:02 UTC, Martin Perina
no flags Details | Diff
Patch 3/5 (1.54 KB, patch)
2014-03-19 09:02 UTC, Martin Perina
no flags Details | Diff
Patch 4/5 (1.78 KB, patch)
2014-03-19 09:03 UTC, Martin Perina
no flags Details | Diff
Patch 5/5 (3.22 KB, patch)
2014-03-19 09:03 UTC, Martin Perina
no flags Details | Diff
PATCH 1/6 Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE (2.21 KB, patch)
2014-03-27 12:53 UTC, Martin Perina
no flags Details | Diff
Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE (1.77 KB, patch)
2014-03-27 12:54 UTC, Martin Perina
no flags Details | Diff
PATCH 2/6 Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE (1.77 KB, patch)
2014-03-27 12:56 UTC, Martin Perina
no flags Details | Diff
PATCH 3/6 Move fence_kdump nodes filtering into separate function (1.81 KB, patch)
2014-03-27 12:57 UTC, Martin Perina
no flags Details | Diff
PATCH 4/6 Rename is_fence_kdump to is_pcs_fence_kdump (1.98 KB, patch)
2014-03-27 12:57 UTC, Martin Perina
no flags Details | Diff
PATCH 5/6 Rename check_fence_kdump to check_pcs_fence_kdump (1.37 KB, patch)
2014-03-27 12:58 UTC, Martin Perina
no flags Details | Diff
PATCH 6/6 Add fence_kdump support for generic clusters (10.78 KB, patch)
2014-03-27 12:59 UTC, Martin Perina
no flags Details | Diff
[PATCH 1/6] Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE (2.38 KB, patch)
2014-04-01 10:58 UTC, Martin Perina
no flags Details | Diff
[PATCH 2/6] Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE (1.94 KB, patch)
2014-04-01 11:00 UTC, Martin Perina
no flags Details | Diff
[PATCH 3/6] Rename is_fence_kdump to is_pcs_fence_kdump (2.13 KB, patch)
2014-04-01 11:01 UTC, Martin Perina
no flags Details | Diff
[PATCH 4/6] Rename kdump_check_fence_kdump to kdump_configure_fence_kdump (1.24 KB, patch)
2014-04-01 11:02 UTC, Martin Perina
no flags Details | Diff
[PATCH 5/6] Rename check_fence_kdump to check_pcs_fence_kdump (1.56 KB, patch)
2014-04-01 11:02 UTC, Martin Perina
no flags Details | Diff
[PATCH 6/6] Add fence_kdump support for generic clusters (11.41 KB, patch)
2014-04-01 11:03 UTC, Martin Perina
no flags Details | Diff
[PATCH 1/7] Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE (2.35 KB, patch)
2014-04-03 08:08 UTC, Martin Perina
no flags Details | Diff
[PATCH 2/7] Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE (1.91 KB, patch)
2014-04-03 08:09 UTC, Martin Perina
no flags Details | Diff
[PATCH 3/7] Rename is_fence_kdump to is_pcs_fence_kdump (2.09 KB, patch)
2014-04-03 08:10 UTC, Martin Perina
no flags Details | Diff
[PATCH 4/7] Rename kdump_check_fence_kdump to kdump_configure_fence_kdump (1.21 KB, patch)
2014-04-03 08:10 UTC, Martin Perina
no flags Details | Diff
[PATCH 5/7] Rename check_fence_kdump to check_pcs_fence_kdump (1.52 KB, patch)
2014-04-03 08:11 UTC, Martin Perina
no flags Details | Diff
[PATCH 6/7] Add get_option_value() (817 bytes, patch)
2014-04-03 08:12 UTC, Martin Perina
no flags Details | Diff
[PATCH 7/7] Add fence_kdump support for generic clusters (12.55 KB, patch)
2014-04-03 08:12 UTC, Martin Perina
no flags Details | Diff

Description Martin Perina 2014-03-19 08:42:57 UTC
Description of problem:

kexec-tools-2.0.4-23 contains automatic configuration of fence_kdump from Pacemaker configuration. Unfortunately, this support is tightly bound to Pacemaker and cannot be used for other clusters like oVirt.

1) Current status (kexec-tools-2.0.4-23)
     - when running 'kdumpctl restart' kdump detects if fence_kdump_send command is installed
       and if so, it tries to:

         a) Create /etc/fence_kdump_nodes file with list of hosts to send fence_kdump notification to. These hosts are also extracted from cluster configuration using 'pcs cluster' command
         b) If nodes was successfully extracted from 'pcs cluster' command, kdump tries to configure network to be able
            to reach all hosts
         c) Load /etc/sysconfig/fence_kdump file with command line parameters for fence_kdump_send if it exists.
         d) Install these two config files into kdump's kernel initramfs


2) Proposed status
     - when running 'kdumpctl restart' kdump detect if fence_kdump_send binary is installed
       and if so, it tries to:

         a) It tries to detect is cluster is configured ('pcs' command is available). If so, it execute same process as in 1)
         b) If cluster is not configured, it tries to detect if /etc/fence_kdump_nodes exists. If so, fence_kdump is marked as successfully
            configured and kdump continues with steps 1c) and 1d)

It would be also nice if whole fence_kdump configuration will exist in the same directory:

    /etc/fence_kdump
    /etc/fence_kdump_nodes

In this state fence_kdump configuration will comply to FHS.

Even Pacemaker could you this generic configuration in future and kexec-tools won't need to parse fence_kdump configuration from Pacemaker configuration.


Version-Release number of selected component (if applicable):

kexec-tools-2.0.4-23

Comment 1 Martin Perina 2014-03-19 09:01:27 UTC
Created attachment 876252 [details]
Patch 1/5

Comment 2 Martin Perina 2014-03-19 09:02:05 UTC
Created attachment 876253 [details]
Patch 2/5

Comment 3 Martin Perina 2014-03-19 09:02:38 UTC
Created attachment 876254 [details]
Patch 3/5

Comment 4 Martin Perina 2014-03-19 09:03:17 UTC
Created attachment 876255 [details]
Patch 4/5

Comment 5 Martin Perina 2014-03-19 09:03:50 UTC
Created attachment 876256 [details]
Patch 5/5

Comment 6 Martin Perina 2014-03-27 12:46:24 UTC
Solution proposed above wasn't accepted, so here's new proposal:

  - Add two new options to kdump.conf

      fence_kdump_nodes
          - List of hosts separated by space to send fence_kdump
            notification to (this option is mandatory to enable
            fence_kdump)

      fence_kdump_args
          - Command line arguments for fence_kdump_send (it can
            contain all valid arguments except hosts to send
            notification to)


  - Modify kdump behavior due to new options

      1) If fence_kdump_nodes option is set and fence_kdump_send
         is found and executable -> configure network for kdump
         and execute fence_kdump_send with those nodes (and also
         with args specified in fence_kdump_args if not empty)

      2) If fence_kdump_nodes is not set, try to configure fence_kdump
         using cluster settings (current behavior). This should stay
         in kexec-tools not to break compatibility and can be removed
         after Pacemaker will start using new options.

Comment 7 Martin Perina 2014-03-27 12:53:54 UTC
Created attachment 879449 [details]
PATCH 1/6 Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE

Comment 8 Martin Perina 2014-03-27 12:54:55 UTC
Created attachment 879461 [details]
Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE

Comment 9 Martin Perina 2014-03-27 12:56:17 UTC
Created attachment 879464 [details]
PATCH 2/6 Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE

Comment 10 Martin Perina 2014-03-27 12:57:06 UTC
Created attachment 879465 [details]
PATCH 3/6 Move fence_kdump nodes filtering into separate function

Comment 11 Martin Perina 2014-03-27 12:57:57 UTC
Created attachment 879466 [details]
PATCH 4/6 Rename is_fence_kdump to is_pcs_fence_kdump

Comment 12 Martin Perina 2014-03-27 12:58:51 UTC
Created attachment 879467 [details]
PATCH 5/6 Rename check_fence_kdump to check_pcs_fence_kdump

Comment 13 Martin Perina 2014-03-27 12:59:39 UTC
Created attachment 879468 [details]
PATCH 6/6 Add fence_kdump support for generic clusters

Comment 14 Martin Perina 2014-04-01 10:58:14 UTC
Created attachment 881288 [details]
[PATCH 1/6] Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE

Comment 15 Martin Perina 2014-04-01 11:00:23 UTC
Created attachment 881289 [details]
[PATCH 2/6] Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE

Comment 16 Martin Perina 2014-04-01 11:01:18 UTC
Created attachment 881290 [details]
[PATCH 3/6] Rename is_fence_kdump to is_pcs_fence_kdump

Comment 17 Martin Perina 2014-04-01 11:02:04 UTC
Created attachment 881291 [details]
[PATCH 4/6] Rename kdump_check_fence_kdump to kdump_configure_fence_kdump

Comment 18 Martin Perina 2014-04-01 11:02:50 UTC
Created attachment 881292 [details]
[PATCH 5/6] Rename check_fence_kdump to check_pcs_fence_kdump

Comment 19 Martin Perina 2014-04-01 11:03:37 UTC
Created attachment 881293 [details]
[PATCH 6/6] Add fence_kdump support for generic clusters

Comment 20 Martin Perina 2014-04-03 08:08:43 UTC
Created attachment 882135 [details]
[PATCH 1/7] Rename FENCE_KDUMP_CONFIG to FENCE_KDUMP_CONFIG_FILE

Comment 21 Martin Perina 2014-04-03 08:09:26 UTC
Created attachment 882136 [details]
[PATCH 2/7] Rename FENCE_KDUMP_NODES to FENCE_KDUMP_NODES_FILE

Comment 22 Martin Perina 2014-04-03 08:10:15 UTC
Created attachment 882137 [details]
[PATCH 3/7] Rename is_fence_kdump to is_pcs_fence_kdump

Comment 23 Martin Perina 2014-04-03 08:10:48 UTC
Created attachment 882138 [details]
[PATCH 4/7] Rename kdump_check_fence_kdump to  kdump_configure_fence_kdump

Comment 24 Martin Perina 2014-04-03 08:11:41 UTC
Created attachment 882140 [details]
[PATCH 5/7] Rename check_fence_kdump to check_pcs_fence_kdump

Comment 25 Martin Perina 2014-04-03 08:12:26 UTC
Created attachment 882141 [details]
[PATCH 6/7] Add get_option_value()

Comment 26 Martin Perina 2014-04-03 08:12:57 UTC
Created attachment 882142 [details]
[PATCH 7/7] Add fence_kdump support for generic clusters


Note You need to log in before you can comment on or make changes to this bug.