Bug 1078365 - New xlators are linked as versioned .so files, creating <xlator>.so.0.0.0
Summary: New xlators are linked as versioned .so files, creating <xlator>.so.0.0.0
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: glusterfs-3.5.1
TreeView+ depends on / blocked
 
Reported: 2014-03-19 16:37 UTC by Niels de Vos
Modified: 2014-06-24 11:03 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.5.1beta
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-24 11:03:48 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2014-03-19 16:37:04 UTC
Description of problem:

xlators are handled like plugins and are not provided for linking against to other applications. The xlators are loaded on-demand by a matching version of the glusterfs(d) binaries.

Version-Release number of selected component (if applicable):
current 3.5 in beta

How reproducible:
100%

Steps to Reproduce:
1. Download the rpms from
   http://download.gluster.org/pub/gluster/glusterfs/qa-releases/3.5.0qa3/RHEL/epel-6.5/x86_64
2. rpm -qlp *.rpm | grep -E 'xlator/.+.so.0'
   /usr/lib64/glusterfs/3.5.0qa3/xlator/encryption/crypt.so.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/encryption/crypt.so.0.0.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/cdc.so.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/cdc.so.0.0.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/changelog.so.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/changelog.so.0.0.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/prot_client.so.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/prot_client.so.0.0.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/prot_dht.so.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/prot_dht.so.0.0.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/prot_server.so.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/features/prot_server.so.0.0.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/performance/readdir-ahead.so.0
   /usr/lib64/glusterfs/3.5.0qa3/xlator/performance/readdir-ahead.so.0.0.0


Actual results:
New xlators are listed, these should not be versioned.

Expected results:
No xlator should be a versioned .so file.

Comment 1 Anand Avati 2014-03-19 17:16:38 UTC
REVIEW: http://review.gluster.org/7299 (build: do not create versioned <xlator>.so files) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-03-19 17:26:01 UTC
REVIEW: http://review.gluster.org/7301 (build: do not create versioned <xlator>.so files) posted (#1) for review on release-3.5 by Niels de Vos (ndevos)

Comment 3 Anand Avati 2014-03-19 17:30:21 UTC
REVIEW: http://review.gluster.org/7299 (build: do not create versioned <xlator>.so files) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 4 Anand Avati 2014-03-19 17:30:36 UTC
REVIEW: http://review.gluster.org/7301 (build: do not create versioned <xlator>.so files) posted (#2) for review on release-3.5 by Niels de Vos (ndevos)

Comment 5 Anand Avati 2014-03-22 00:28:21 UTC
COMMIT: http://review.gluster.org/7299 committed in master by Anand Avati (avati) 
------
commit eb87c96f49b3dd2c7460e58c54ce909c706cd475
Author: Niels de Vos <ndevos>
Date:   Wed Mar 19 18:03:54 2014 +0100

    build: do not create versioned <xlator>.so files
    
    There has been a misspelled option in the Makefile.am files. The option
    is called -avoid-version, and not -avoidversion.
    
    It is not trivial to provide a test-case for this. One way would be to
    check generated RPMs with a command like this (output should be empty):
    
      $ rpm -qlp *.rpm | grep -E '/xlator/.+.so.0'
    
    Change-Id: I2a6cc557eada4d098b73af5a254f8c75707543da
    BUG: 1078365
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/7299
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Tested-by: Gluster Build System <jenkins.com>

Comment 6 Anand Avati 2014-05-05 13:35:46 UTC
COMMIT: http://review.gluster.org/7301 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit f863a9b69ecc9513b74cb07cb199f0c0ff38104e
Author: Niels de Vos <ndevos>
Date:   Wed Mar 19 18:03:54 2014 +0100

    build: do not create versioned <xlator>.so files
    
    There has been a misspelled option in the Makefile.am files. The option
    is called -avoid-version, and not -avoidversion.
    
    It is not trivial to provide a test-case for this. One way would be to
    check generated RPMs with a command like this (output should be empty):
    
      $ rpm -qlp *.rpm | grep -E '/xlator/.+.so.0'
    
    Change-Id: Ie1519455c9f9366feee0d3cafcc384b9eff57776
    Reviewed-on-master: http://review.gluster.org/7299
    BUG: 1078365
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/7301
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 7 Niels de Vos 2014-05-25 09:07:24 UTC
The first (and last?) Beta for GlusterFS 3.5.1 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.1beta release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-May/040377.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 8 Niels de Vos 2014-06-24 11:03:48 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.1, please reopen this bug report.

glusterfs-3.5.1 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-June/040723.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.