Hello wrt app name - sorry, copy/paste issue; it's all the same app wrt DISABLE_OPENSHIFT_MANAGED_SERVER - that is the point. It is not implemented. I guess it's acceptable for a beta but we need to be consistent with eap and other layered products. After all DV cart is using eap under the hood. And users will need to configure server in a similar way to EAP. That's why I'm suggesting that DV cart built process is adjusted in the future to inherit what we already have in jbosseap cart.
https://github.com/jboss-datavirtualization/openshift-cartridge-datavirtualization/pull/2
I've been testing the pull request but unable to get it to work. For DV, the default behavior should be to persist the configuration changes between restarts. So to make this happen using the pull request changes, I added this to the install script - disableManaged=true echo "$disableManaged" > $OPENSHIFT_DV_DIR/env/DISABLE_OPENSHIFT_MANAGED_SERVER Is that correct? My test scenario is to start the cartridge, add a datasource, then stop and start it. When I restart it reverts to the original standalone.
commited the change after retesting ok with the corrected env var DISABLE_OPENSHIFT_MANAGED_SERVER_CONFIG
Is this going to work in latest devenv or a special URL needs to be used with the change?
should work with any devenv, Mark merged the changes into the repo location that is used by the dv cart definition in the devenv.
I tested this change but I see a problem. steps: 1. create a DV app 2. set DISABLE_OPENSHIFT_MANAGED_SERVER_CONFIG=true 3. change jboss config with jboss-cli (e.g. add a sys property) 4. git push something in app repo 5. config is NOT overwritten (this is the expected and desired behavior) 6. set DISABLE_OPENSHIFT_MANAGED_SERVER_CONFIG=false 7. git push something in app repo 8. config is NOT overwritten (======= this is a bug =======) 9. unset DISABLE_OPENSHIFT_MANAGED_SERVER_CONFIG 10. ssh to gear 11. variable *is* set and value is `true` (is this intentional?) Above I describe what is current behavior and the bug I see according to comment 6. I don't agree though that the behavior should differ from jbossas and jbosseap cartridges. I also think jbossas and jbosseap need better user-friendly handling of configuration file but for the time being consistency between our cartridges will provide better user experience than every cartridge having its own quirks. So I'm again suggesting to have conf file overwritten from repo by default. And if DISABLE_OPENSHIFT_MANAGED_SERVER_CONFIG=true, then don't ever touch the config. Regards.
For DV we do not want the configuration to be overwritten - that's why the DISABLE_OPENSHIFT_MANAGED_SERVER_CONFIG is 'true' on install. Data Virtualization users deploy the instance and connect to the admin port, manage datasources, add VDBS etc, all of which are changing the standalone.xml. We cannot have the standalone.xml being overwritten as default behavior because all of these changes would be lost. However, I agree that we should keep this optional - if the user wants a different behavior then it should be possible. So yes, the scenario you pointed out above is an issue.
made a correction to the install script to properly set DISABLE_OPENSHIFT_MANAGED_SERVER_CONFIG
I see it working now, thank you.