Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1078860

Summary: engine-cleanup after manual db remove exits with a non-helpful message
Product: [Retired] oVirt Reporter: Yedidyah Bar David <didi>
Component: ovirt-engine-reportsAssignee: Yedidyah Bar David <didi>
Status: CLOSED DUPLICATE QA Contact: Pavel Stehlik <pstehlik>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.5CC: acathrow, didi, gklein, iheim, pstehlik, sbonazzo, yeylon, ylavi
Target Milestone: ---   
Target Release: 3.4.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1015037 Environment:
Last Closed: 2014-04-22 07:44:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1015037    
Bug Blocks:    

Description Yedidyah Bar David 2014-03-20 12:43:33 UTC
[ ERROR ] Failed to execute stage 'Misc configuration': 'NoneType' object is not iterable

2014-03-20 14:21:33 DEBUG otopi.context context._executeMethod:152 method exception
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/otopi/context.py", line 142, in _executeMethod
    method['method']()
  File "/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/ovirt-engine-reports/db/pgpass.py", line 54, in _misc
    dbenvkeys=oreportscons.Const.REPORTS_DB_ENV_KEYS,
  File "/usr/share/ovirt-engine/setup/ovirt_engine_setup/database.py", line 414, in createPgPass
    ':\\',
  File "/usr/lib/python2.7/site-packages/ovirt_engine/util.py", line 46, in escape
    for c in s:
TypeError: 'NoneType' object is not iterable


+++ This bug was initially created as a clone of Bug #1015037 +++

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. engine-setup
2. service ovirt-engine stop
3. 'drop database engine' in psql
4. engine-cleanup

Actual results:

engine-cleanup emits:
[ ERROR ] Failed to execute stage 'Setup validation': 'NoneType' object is not iterable


Expected results:

A proper error message

Additional info:

--- Additional comment from Sandro Bonazzola on 2013-10-21 16:17:34 IST ---

Included in 3.3.1 beta

--- Additional comment from sefi litmanovich on 2013-10-30 18:25:03 IST ---

Verified on rhevm 3.3 is20.

error message:
[WARNING] Cannot connect to database using existing credentials: engine@localhost:5432

--- Additional comment from Sandro Bonazzola on 2013-11-25 13:46:39 IST ---

oVirt 3.3.1 has been released

Comment 1 Sandro Bonazzola 2014-04-17 13:01:07 UTC
Didi, the patch referenced is already merged and should already be in 3.4.0.
Shouldn't this be in closed current release?

Comment 2 Yedidyah Bar David 2014-04-22 07:36:12 UTC
(In reply to Sandro Bonazzola from comment #1)
> Didi, the patch referenced is already merged and should already be in 3.4.0.
> Shouldn't this be in closed current release?

I can't remember anymore where/how, but I was notified that in 3.4 with the reports plugin, the expected message is not output and instead some other message appears. Still did not try to reproduce.

Comment 3 Yedidyah Bar David 2014-04-22 07:44:35 UTC
(In reply to Yedidyah Bar David from comment #2)
> (In reply to Sandro Bonazzola from comment #1)
> > Didi, the patch referenced is already merged and should already be in 3.4.0.
> > Shouldn't this be in closed current release?
> 
> I can't remember anymore where/how

It was bug #1071875.

> , but I was notified that in 3.4 with the
> reports plugin, the expected message is not output and instead some other
> message appears. Still did not try to reproduce.

*** This bug has been marked as a duplicate of bug 1071875 ***