Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1078908

Summary: Parameterize "debug" in apply-updates.bat
Product: [JBoss] JBoss Operations Network Reporter: Mike Foley <mfoley>
Component: ConfigurationAssignee: Simeon Pinder <spinder>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: unspecified    
Version: JON 3.2.1CC: ahovsepy, spinder
Target Milestone: DR03   
Target Release: JON 3.2.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-08 17:43:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
debug_on
none
debug_on_logs none

Description Mike Foley 2014-03-20 14:14:16 UTC 
Description of problem:  apply-updates.bat includes developer comments for incomplete work.  Debug mode is hard-coded, and could be parameterized


Version-Release number of selected component (if applicable):
JON 3.2.1 aka JON 3.2 CP

How reproducible:
100%

Steps to Reproduce:
1. visual inspection of apply-updates.bat 
2.
3.

Actual results:
line #28 of apply-updates.bat = rem TODO: REMOVE DEBUG!!!

Expected results:
1) code shipped to customers does not include TODO
2) debug can be done thru a commandline parameter 

Additional info:
Comment 1 Simeon Pinder 2014-04-01 17:17:53 UTC 
After discussions with GSS, it was decided to not pass these values in as parameter, but instead to have the scripts check for the presence of DEBUG environment variables for activation.  This means that script is i)not made more complicated by additional params on windows and batch.  TODO comment was removed. Bash/batch check for presence of variables instead now. See commit: 10831982a410 for more details. Moving to MODIFIED.
Comment 2 Simeon Pinder 2014-04-01 20:43:56 UTC 
Moving to ON_QA as available for test in newest cumulative patch build from here:
http://jon01.mw.lab.eng.bos.redhat.com:8042/dist/release/jon/3.2.1.GA/4-01-2014/
I moved the earlier build to 3-18-2014.
Comment 3 Armine Hovsepyan 2014-04-03 12:31:34 UTC 
Created attachment 882248 [details]
debug_on
Comment 4 Armine Hovsepyan 2014-04-03 15:48:46 UTC 
Created attachment 882365 [details]
debug_on_logs
Comment 5 Armine Hovsepyan 2014-04-03 16:37:56 UTC 
DEBUG var with true values is detected - no debug log visible (logs in patch.log)
when DEBUG DEBUG is N/A - .bat does nothing, while in .sh it sets/exports it as empty.

new BZ for logging inconsistency - #1084128
Comment 6 Mike Foley 2014-05-08 17:43:43 UTC 
JON 3.2.1 released week of 5/5/2014