Bug 1079210 - virt-sparsify --in-place cannot sparsify as much as it should
Summary: virt-sparsify --in-place cannot sparsify as much as it should
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-21 08:43 UTC by Richard W.M. Jones
Modified: 2014-04-08 10:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-04-08 10:21:19 UTC
Embargoed:


Attachments (Terms of Use)
Comment (123.17 KB, text/plain)
2014-03-21 08:43 UTC, Richard W.M. Jones
no flags Details

Description Richard W.M. Jones 2014-03-21 08:43:57 UTC
Created attachment 915873 [details]
Comment

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).

Comment 1 Richard W.M. Jones 2014-03-21 10:44:27 UTC
Note to self: I cannot reproduce this on my own 32 bit Rawhide VM.

Comment 2 Richard W.M. Jones 2014-03-26 20:49:47 UTC
Also happens -- though less often -- on x86-64.  I asked on
linux-fsdevel:

http://marc.info/?l=linux-fsdevel&m=139586683225825&w=2

Comment 3 Richard W.M. Jones 2014-03-26 20:50:38 UTC
Example failure on x86-64:

Sparsify in-place operation completed with no errors.
test virt-sparsify: 336296 K -> 18856 K
test virt-sparsify --in-place: size_after (18856) too large

Comment 4 Richard W.M. Jones 2014-04-08 10:21:19 UTC
I suspect what is happening here is that the journal is
not getting trimmed.  As there are two filesystems, one of
which is 400 MB in size, at least 20 MB or so could potentially
be used by the journal.

I have changed the test so it measures the reduction in size
of the image instead of the final size:

https://github.com/libguestfs/libguestfs/commit/595bd5022a251a396050c247003ac60328a7facf


Note You need to log in before you can comment on or make changes to this bug.