Created attachment 877525 [details] comparison of .old directory vs. changed file hashes Description of problem: unexplained differences in file hash versus .old directory Reviewed results and found differences, also reviewed .old file and marked expected changes as *(EXPECTED)* in the file. I am not sure if those new files and/or updated files that i was not able to find in .old directory are expected or unexpected changes. Version-Release number of selected component (if applicable): JON 3.2.1 aka JON 3.2 CP1 Actual results: Unexplained or not understood changes in file hashes vs. what is in .old directory Expected results: Files changed in .old directory ... matches changed file hashes. Additional info: This is from Armine's testing. The resolution of this should be documented on this BZ. Some file hash changes are understood or explained: pom.properties .ear manifest file But others I do not understand and are unexplained and represent a difference from expectations which I interpret as a potential defect which needs to be logged as a BZ.
It has been brought up in QE test case discussion that all files should show up in the .old, not just replaced.
The removed-list.txt was update to add all of the overlaid files as well so that both overlaid and files that need to be removed will go through the 'backup' process. This is fixed with commit: 13f0eeac0bfbf0c05 to jon.git. If there are still files that are inexplicably in place we should discuss further since the diff content has changes since this BZ was filed. Moving to MODIFIED.
Moving to ON_QA as available for test in newest cumulative patch build from here: http://jon01.mw.lab.eng.bos.redhat.com:8042/dist/release/jon/3.2.1.GA/4-01-2014/ I moved the earlier build to 3-18-2014.
Created attachment 882809 [details] checksum-results2
re-assigning back to Simeon. checksum_results2 attached Please get also comment #5 from Filip
Moving to ON_QA as available for test with the following(or later) cumulative patch build: http://jon01.mw.lab.eng.bos.redhat.com:8042/dist/release/jon/3.2.1.GA/4-14-2014/ -Cumulative patch/update builds are applicable to 3.2.0.GA and later JON Server releases. -Cumulative patch builds should be tested with the 3.2.0.GA plugin pack contents until a newer plugin pack release is available.
Following file was changed after the patch (4-14-2014) was applied but was NOT stored in .old directory: before patch: 5c803d894f868c0bbe0df54a2388e0a9 /home/hudson/jon-server-3.2.0.GA/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-server.jar/org/rhq/enterprise/server/search/RHQLParser.class after patch: c3809de179f8eb1e188f17f6898dd871 /home/hudson/jon-server-3.2.0.GA-update-01/jon-server-updates/modules/org/rhq/server-startup/main/deployments/rhq.ear/rhq-server.jar/org/rhq/enterprise/server/search/RHQLParser.class
The same issue, as Filip mentiones in Comment 10, applies for Windows environment (using patch from 4-14-2014): The file %jon-installaltion-root%\modules\org\rhq\server-startup\main\deployments\rhq.ear\rhq-server.jar\org\rhq\enterprise\server\search\RHQLParser.class is modified but not backed-up before patch: 5c803d894f868c0bbe0df54a2388e0a9 RHQLParser.class after patch: c3809de179f8eb1e188f17f6898dd871 RHQLParser.class
Yes. The issue is that the removed-list.txt is missing the line to indicate that file needed to be backed up. This would manifest on all platforms as you've detected. It's a one line fix to add it to the removed-list.txt file. This is fixed with commit: 48652054165fd00 to jon.git and will be in the next build. Moving to MODIFIED.
Setting to ON_QA for verification in CR02 build: http://jon01.mw.lab.eng.bos.redhat.com:8042/dist/release/jon/3.2.1.GA/4-22-2014/
Verified on Version : 3.2.0.GA Update 01 Build Number : 4865205:029a879
JON 3.2.1 released week of 5/5/2014