Spec URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-menus/1/cinnamon-menus.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-menus/1/cinnamon-menus-2.1-0.1.gitc740513.fc20.src.rpm Description: cinnamon-menus is an implementation of the draft "Desktop Menu Specification" from freedesktop.org. This package also contains the Cinnamon menu layout configuration files, .directory files and assorted menu related utility programs, Python bindings, and a simple menu editor. Fedora Account System Username: leigh123linux
1. missing isa tag in -devel subpackage Requires: %{name} = %{version}-%{release} 2. [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). 3. Is BuildRequires: pkgconfig really needed? Rest looks good.
APPROVED! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/girepository-1.0, /usr/share/gir-1.0 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cinnamon-menus-2.1-0.1.gitc740513.fc21.x86_64.rpm cinnamon-menus-devel-2.1-0.1.gitc740513.fc21.x86_64.rpm cinnamon-menus-2.1-0.1.gitc740513.fc21.src.rpm cinnamon-menus.x86_64: W: spelling-error %description -l en_US freedesktop -> free desktop, free-desktop, desktop cinnamon-menus-devel.x86_64: W: no-documentation cinnamon-menus.src: W: spelling-error %description -l en_US freedesktop -> free desktop, free-desktop, desktop 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint cinnamon-menus cinnamon-menus-devel cinnamon-menus.x86_64: W: spelling-error %description -l en_US freedesktop -> free desktop, free-desktop, desktop cinnamon-menus-devel.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- cinnamon-menus (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) rtld(GNU_HASH) cinnamon-menus-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cinnamon-menus(x86-64) libcinnamon-menu-3.so.0()(64bit) pkgconfig(gio-unix-2.0) Provides -------- cinnamon-menus: cinnamon-menus cinnamon-menus(x86-64) libcinnamon-menu-3.so.0()(64bit) cinnamon-menus-devel: cinnamon-menus-devel cinnamon-menus-devel(x86-64) pkgconfig(libcinnamon-menu-3.0) Source checksums ---------------- http://leigh123linux.fedorapeople.org/pub/cinnamon-menus/source/cinnamon-menus-2.1.gitc740513.tar.gz : CHECKSUM(SHA256) this package : d2646a671f5a9a8a0e7e6485b7ea1526570cbcc9de969c72e1537974571d6f15 CHECKSUM(SHA256) upstream package : d2646a671f5a9a8a0e7e6485b7ea1526570cbcc9de969c72e1537974571d6f15 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1079661 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
New Package SCM Request ======================= Package Name: cinnamon-menus Short Description: A menu system for the Cinnamon project Owners: leigh123linux Branches: f19 f20 epel7 InitialCC:
Git done (by process-git-requests).