Spec URL: http://nierlein.com/fedora/perl-LWP-Protocol-connect.spec
SRPM URL: http://nierlein.com/fedora/perl-LWP-Protocol-connect-6.06-1.fc21.src.rpm
LWP::Protocol::connect Provides HTTP/CONNECT proxy support for LWP::UserAgent.
Fedora Account System Username: sni
Successful koji build:
This is my first review request, so i am asking hereby for a sponsor.
This perl module is required to proceed in #1069988
Related review requests: #1079718, #1079732, #1079733, #1079745, #1079749, #1079751
Since this isn't going to old EPELs (judging by the other reviews), you may remove the line 35.
Line 40 is also generally unneeded.
Package the CHANGES and README files in %doc.
You don't need to BR perl(Test::Exception) as you don't run the author tests.
You should BR perl.
You may use the usually preferred DESTDIR in place of PERL_INSTALL_ROOT. EE::MM knows this.
"Provides" in your description should begin with a lowercase "p".
Spec file has been updated, new Spec and Source RPM have been place here:
new source rpm: http://nierlein.com/fedora/2014-04-06/perl-LWP-Protocol-connect-6.06-1.fc21.src.rpm
Ok, this looks good. Approving.
I've also sponsored you for the Packager group. Welcome to Fedora :)
Thats good news. Thank you very much.
You may now submit an SCM request here.
Please, add `perl-sig' to InitialCC when requesting branches for perl packages.
New Package SCM Request
Package Name: perl-LWP-Protocol-connect
Short Description: Provides HTTP/CONNECT proxy support for LWP::UserAgent
Git done (by process-git-requests).
Have you built the package, Sven?
Not yet, sorry, i was busy and on vacation. I will take care soon.
alright, sorry for the delay. Everything should be in place now.
Ok, looks good.
You can now close the review with CLOSED/RAWHIDE; also, please, put the package NEVR in the `Fixed in' field, too.
Thanks for your work.