Bug 1079816 - quiescent period is not obeyed for consecutive power commands
Summary: quiescent period is not obeyed for consecutive power commands
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: lab controller
Version: 0.16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 0.16.1
Assignee: Dan Callaghan
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks: 1079603
TreeView+ depends on / blocked
 
Reported: 2014-03-24 04:55 UTC by Dan Callaghan
Modified: 2018-02-06 00:41 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-03-26 23:54:22 UTC
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2014-03-24 04:55:21 UTC
Description of problem:
Power quiescent period does not take effect when multiple queued commands are handled consecutively.

Version-Release number of selected component (if applicable):
0.16.0

How reproducible:
easily

Steps to Reproduce:
1. Queue several power commands in quick succession, so that they run consecutively
2. Watch provision.log to see the commands being handled

Actual results:
beaker-provision claims to delay each command for 5 seconds but actually each delay starts at the same time:

Mar 24 14:26:20 bkr.labcontroller.provision DEBUG Entering quiescent period, delaying 5 seconds for command 60148
Mar 24 14:26:20 bkr.labcontroller.provision DEBUG Entering quiescent period, delaying 5 seconds for command 60147
Mar 24 14:26:20 bkr.labcontroller.provision DEBUG Entering quiescent period, delaying 5 seconds for command 60146
Mar 24 14:26:25 bkr.labcontroller.provision DEBUG Handling command {... 'id': 60146}
Mar 24 14:26:26 bkr.labcontroller.provision DEBUG Launching power script ...
Mar 24 14:26:26 bkr.labcontroller.provision DEBUG Waiting on power script pid 25579
Mar 24 14:26:32 bkr.labcontroller.provision DEBUG Finished handling command 60146
Mar 24 14:26:32 bkr.labcontroller.provision DEBUG Handling command {... 'id': 60147}
Mar 24 14:26:32 bkr.labcontroller.provision DEBUG Launching power script ...
Mar 24 14:26:32 bkr.labcontroller.provision DEBUG Waiting on power script pid 25583
Mar 24 14:26:36 bkr.labcontroller.provision DEBUG Finished handling command 60147
Mar 24 14:26:36 bkr.labcontroller.provision DEBUG Handling command {... 'id': 60148}
Mar 24 14:26:38 bkr.labcontroller.provision DEBUG Launching power script ...
Mar 24 14:26:38 bkr.labcontroller.provision DEBUG Waiting on power script pid 25588
Mar 24 14:26:40 bkr.labcontroller.provision DEBUG Polling for queued commands
Mar 24 14:26:42 bkr.labcontroller.provision DEBUG Finished handling command 60148
Mar 24 14:26:42 bkr.labcontroller.provision DEBUG Handling command {... 'id': 60149}
Mar 24 14:26:43 bkr.labcontroller.provision DEBUG Launching power script ...
Mar 24 14:26:43 bkr.labcontroller.provision DEBUG Waiting on power script pid 25592
Mar 24 14:26:48 bkr.labcontroller.provision DEBUG Finished handling command 60149

(The 4 seconds between Launching and Finished is the time taken to actually run the power script, not any delay.)

Expected results:
beaker-provision should actually delay 5 seconds between finishing handling one command and starting the next one.

Comment 2 Dan Callaghan 2014-03-24 07:06:51 UTC
On Gerrit: http://gerrit.beaker-project.org/2494

Comment 3 matt jia 2014-03-24 23:30:59 UTC
The link in the comment 2 is not right .Here it is .

http://gerrit.beaker-project.org/#/c/2949/

Cheers,Matt Jia

Comment 6 Dan Callaghan 2014-03-26 23:54:22 UTC
Beaker 0.16.1 has been released.


Note You need to log in before you can comment on or make changes to this bug.