Spec URL: http://mizdebsk.fedorapeople.org/review/eclipse-m2e-sourcelookup/eclipse-m2e-sourcelookup.spec SRPM URL: http://mizdebsk.fedorapeople.org/review/eclipse-m2e-sourcelookup/eclipse-m2e-sourcelookup-1.1.0.201401182304-1.fc21.src.rpm Description: Allows Eclipse Java debugger lookup sources of Java classes dynamically loaded by Maven, such as Maven plugins. Supports multiple versions of the same class loaded by the Maven VM. Sources are looked up among Eclipse workspace projects or resolved from Maven repositories as necessary. Fedora Account System Username: mizdebsk
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6667330
MANUAL review, cause: Caused by: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from org.eclipse.m2e.maven.runtime 1.5.0.20140316-0047 to bundle org.eclipse.m2e.maven.runtime.slf4j.simple 0.0.0.; No solution found because the problem is unsatisfiable.] Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/gil/1079960-eclipse-m2e-sourcelookup/review- eclipse-m2e-sourcelookup/licensecheck.txt [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. FIXME [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. FIXME [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: eclipse-m2e-sourcelookup-1.1.0.201401182304-1.fc21.noarch.rpm eclipse-m2e-sourcelookup-1.1.0.201401182304-1.fc21.src.rpm eclipse-m2e-sourcelookup.noarch: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up eclipse-m2e-sourcelookup.noarch: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace eclipse-m2e-sourcelookup.src: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up eclipse-m2e-sourcelookup.src: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint eclipse-m2e-sourcelookup eclipse-m2e-sourcelookup.noarch: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up eclipse-m2e-sourcelookup.noarch: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- eclipse-m2e-sourcelookup (rpmlib, GLIBC filtered): osgi(com.ifedorenko.m2e.binaryproject) osgi(com.ifedorenko.m2e.sourcelookup) osgi(org.eclipse.core.expressions) osgi(org.eclipse.core.resources) osgi(org.eclipse.core.runtime) osgi(org.eclipse.debug.core) osgi(org.eclipse.debug.ui) osgi(org.eclipse.equinox.common) osgi(org.eclipse.equinox.registry) osgi(org.eclipse.jdt.core) osgi(org.eclipse.jdt.debug) osgi(org.eclipse.jdt.debug.ui) osgi(org.eclipse.jdt.launching) osgi(org.eclipse.jface) osgi(org.eclipse.m2e.core) osgi(org.eclipse.m2e.core.ui) osgi(org.eclipse.m2e.jdt) osgi(org.eclipse.m2e.maven.runtime) osgi(org.eclipse.ui) osgi(org.eclipse.ui.ide) osgi(slf4j.api) Provides -------- eclipse-m2e-sourcelookup: eclipse-m2e-sourcelookup osgi(com.ifedorenko.m2e.binaryproject) osgi(com.ifedorenko.m2e.binaryproject.ui) osgi(com.ifedorenko.m2e.sourcelookup) osgi(com.ifedorenko.m2e.sourcelookup.launch) osgi(com.ifedorenko.m2e.sourcelookup.pde) osgi(com.ifedorenko.m2e.sourcelookup.ui) Source checksums ---------------- https://github.com/ifedorenko/com.ifedorenko.m2e.sourcelookup/archive/1.1.0.201401182304.tar.gz#/eclipse-m2e-sourcelookup-1.1.0.201401182304.tar.gz : CHECKSUM(SHA256) this package : 8d33760a4c381cfe2e5fd2cf9d1eb6271fa9a28a1945079a7ad9828654fa9eaf CHECKSUM(SHA256) upstream package : 8d33760a4c381cfe2e5fd2cf9d1eb6271fa9a28a1945079a7ad9828654fa9eaf http://www.eclipse.org/legal/epl-v10.html : CHECKSUM(SHA256) this package : a40741b59364cc49449255e9b9bfe1fcfe6a2e7ab4d37ca89db3bacbfb14e9d2 CHECKSUM(SHA256) upstream package : a40741b59364cc49449255e9b9bfe1fcfe6a2e7ab4d37ca89db3bacbfb14e9d2 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -vpn eclipse-m2e-sourcelookup -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Please, fix missing license, before import [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream.
Thank you for the review. I have submitted a request for upstream to include license text [1], but for now we need to keep a separate copy of the license. [1] https://github.com/ifedorenko/com.ifedorenko.m2e.sourcelookup/pull/5
New Package SCM Request ======================= Package Name: Review Request: eclipse-m2e-sourcelookup Short Description: M2E Sources Lookup Owners: mizdebsk mizdebsk sochotni msrb Branches: f20 InitialCC: java-sig
Git done (by process-git-requests). Fixed up name in Request.
Built in rawhide. http://koji.fedoraproject.org/koji/taskinfo?taskID=6667928 Closing.