Spec URL: http://nierlein.com/fedora/perl-Catalyst-View-GD.spec SRPM URL: http://nierlein.com/fedora/perl-Catalyst-View-GD-0.01-1.fc21.src.rpm Description: Catalyst::View::GD is a Catalyst View for GD images Fedora Account System Username: sni Successful koji build: not yet, build requires perl-Test-Image-GD from #1079749 This is one of my first review requests, so i am asking hereby for a sponsor. This perl module is required to proceed in #1069988 Related review requests: #1079718, #1079732, #1079733, #1079745, #1079749, #1079751, #1079753
I'll review your package submissions and possibly sponsor you, too :)
I updated the spec file according to the comments of the other related bugs and uploaded a new spec file and source rpm here: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-View-GD.spec http://nierlein.com/fedora/2014-04-06/perl-Catalyst-View-GD-0.01-1.fc21.noarch.rpm
new source rpm: http://nierlein.com/fedora/2014-04-06/perl-Catalyst-View-GD-0.01-1.fc21.src.rpm
new spec file: http://nierlein.com/fedora/2014-04-21/perl-Catalyst-View-GD.spec i only changed the release number.
BRs, Requires and Url updated according to cpanspec. new files are here: http://nierlein.com/fedora/2014-05-20/perl-Catalyst-View-GD.spec http://nierlein.com/fedora/2014-05-20/perl-Catalyst-View-GD-0.01-3.fc21.src.rpm
Ok, you're missing some buildtime dependencies... Those are required by the test suite itself: perl(base) perl(Catalyst) perl(Catalyst::Test) perl(FindBin) perl(File::Spec) perl(lib) perl(strict) perl(warnings) And in addition to that, those are required by the tested code: perl(Catalyst::Exception) perl(Catalyst::View) perl(NEXT) perl(Scalar::Util) And you should remove Catalyst::Runtime. This module isn't directly used anywhere. Require the specific modules from the suite which I listed above instead. This prevents future FTBFS breakage if the modules move to a different bundle. Also, drop the Module::Build dependency. You're using Makefile.PL which doesn't need it. And finally drop the explicit GD runtime dependency (line 19). This is automatically discovered and added by rpmbuild. The rest of the spec looks good and the license is fine too.
Not sure if i understood you correctly, but here are the new files: http://nierlein.com/fedora/2014-05-24/perl-Catalyst-View-GD.spec http://nierlein.com/fedora/2014-05-24/perl-Catalyst-View-GD-0.01-4.fc21.src.rpm
Apologies for ignoring this for so long. I've reviewed your changes and I see you've done everything I asked. I'm approving the package.
I am not using this modules anymore, so i will close this request. Thanks anyway.