Hide Forgot
Spec URL: http://nierlein.com/fedora/perl-Excel-Template-Plus.spec SRPM URL: http://nierlein.com/fedora/perl-Excel-Template-Plus-0.05-1.fc21.src.rpm Description: Excel::Template::Plus is an extension to the Excel::Template module. Fedora Account System Username: sni Successful koji build: not yet, build requires perl-Excel-Template from #1079745 This is one of my first review requests, so i am asking hereby for a sponsor. This perl module is required to proceed in #1069988 Related review requests: #1079718, #1079732, #1079733, #1079745, #1079749, #1079751, #1079753, #1080201
updated spec file according to comments from the related bugs and uploaded new files: http://nierlein.com/fedora/2014-04-06/perl-Excel-Template-Plus.spec http://nierlein.com/fedora/2014-04-06/perl-Excel-Template-Plus-0.05-1.fc21.src.rpm
new spec file: http://nierlein.com/fedora/2014-04-21/perl-Excel-Template-Plus.spec i only changed the release number.
I added the missing perl compat requires and updated BRs and requires according to cpanspec. I also change the source url to the generic cpan url. New files are here: http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus.spec http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus-0.05-3.fc21.noarch.rpm
(In reply to Sven Nierlein from comment #3) > I added the missing perl compat requires and updated BRs and requires > according to cpanspec. I also change the source url to the generic cpan url. > > New files are here: > http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus.spec > http://nierlein.com/fedora/2014-05-20/perl-Excel-Template-Plus-0.05-3.fc21. > noarch.rpm Hi Sven, Thats an RPM not an SRPM that you've uploaded.
sorry my bad, spec and source rpm is here: http://www.nierlein.com/fedora/2014-10-13/perl-Excel-Template-Plus-0.05-3.fc22.src.rpm http://www.nierlein.com/fedora/2014-10-13/perl-Excel-Template-Plus.spec
Builds successfully at http://koji.fedoraproject.org/koji/taskinfo?taskID=7857678 License is correct You need to add all the perl modules that are used during the build, test and install cycles. In this case, all the perl modules when running "perl Makefile.PL && make && make test && make install" Therefore, add the following BRs BR: perl(Exporter) # in lib/Test/Excel/Template/Plus.pm at line 15 BR: perl(File::Spec::Functions) # in t/001_basic.t at line 7 BR: perl(Test::Pod) >= 1.14 # in t/pod.t at line 8 BR: perl(Test::Pod::Coverage) >= 1.04 # in t/pod_coverage.t at line 8 BR: perl(Moose::Util::TypeConstraints) # in lib/Excel/Template/Plus/TT.pm at line 4 BR: perl(strict) # in t/000_load.t at line 3 BR: perl(Test::Builder) # in lib/Test/Excel/Template/Plus.pm at line 8 BR: perl(warnings) # in t/000_load.t at line 4 Remove the following BRs BR: perl(Module::Build) # you are using Makefile.PL, there is no need for Module::Build. BR: perl(File::Spec) # there is no reference to File::Spec, only File::Spec::Functions, therefore, include File::Spec::Functions explicitly, rpm will make the connection to install File::Spec BR: perl(Test::More) # there are two separate instances in BuildRequires. Remove one Remove the following RunTime requires Requires: perl(Excel::Template) Requires: perl(IO::String) Requires: perl(Spreadsheet::ParseExcel) Requires: perl(Template) Requires: perl(Test::Deep) as these are automatically detected Add the following lines just before the %description line %global __requires_exclude %{?__requires_exclude:__requires_exclude|}^perl\\(Moose\\)$ %global __requires_exclude %__requires_exclude|^perl\\(MooseX::Param\\)$ as your explicitly versioned run time requires make the generic requires unnecessary.
thanks for your detailed remarks. I will take care of them after my vacation, so don't expect any update soon.
finally... sorry for the delay. Here are the updated specs and source rpm file: http://nierlein.com/fedora/2014-12-19/perl-Excel-Template-Plus.spec http://nierlein.com/fedora/2014-12-19/perl-Excel-Template-Plus-0.05-4.fc22.src.rpm
Builds fine at http://koji.fedoraproject.org/koji/taskinfo?taskID=8441644 rpmlint is ok (spelling warnings may be ignored) Package APPROVED!
New Package SCM Request ======================= Package Name: perl-Excel-Template-Plus Short Description: An extension to the Excel::Template module Owners: sni Branches: f21 InitialCC: perl-sig
Git done (by process-git-requests).
build and upload completed