Bug 1080351 - [api][rfe] public api for callback when executing the rpm transaction
Summary: [api][rfe] public api for callback when executing the rpm transaction
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: dnf
Version: 20
Hardware: Unspecified
OS: Unspecified
low
unspecified
Target Milestone: ---
Assignee: Packaging Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1066869
TreeView+ depends on / blocked
 
Reported: 2014-03-25 08:43 UTC by Tim Lauridsen
Modified: 2015-06-29 19:41 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-06-29 19:41:12 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
test implementation of rpm callback (2.13 KB, text/x-python)
2014-03-25 13:03 UTC, Tim Lauridsen
no flags Details

Description Tim Lauridsen 2014-03-25 08:43:46 UTC
Description of problem:

If an API user is executing a big transaction like updating many packages
it is useful to give some feedback to the user, what is going on.

dnf.Base.do_transaction has an non public api parameter display, there takes a subclass based on dnf.yum.rpmtrans.TransactionDisplay.

I most cases a only the TransactionDisplay.event is need for soling the need for
giving the user feedback.

So adding a simple TransactionDisplay subclass to dnf.callback ex. RPMProgress with an progress method the user could overload with a subclass cauld be a way to go and then make this class and do_transaction(display=...) public api
cauld be a way to go.

I can take a shot of making it, but need to know if it is a way to go or some other approch is better.

Version-Release number of selected component (if applicable):
0.4.19

Comment 1 Ales Kozumplik 2014-03-25 11:43:12 UTC
This touches a lot of the old Yum code that we do not want to expose and will probably need massive refactoring. The resulting API for this will have to be aligned with other dnf.callback interfaces, not expose anything from dnf.yum* and follow the 'less is more' principle. Also it needs to be extensible for more types of progress operations later.

Generally it is low priority now.

Comment 2 Tim Lauridsen 2014-03-25 13:03:56 UTC
Created attachment 878458 [details]
test implementation of rpm callback

Comment 3 Tim Lauridsen 2014-03-25 13:07:02 UTC
My idea was to something like this, and when the old yum code is refactored, then the RPMProgress class is changed to match but the user get the same interface.

Comment 4 Tim Lauridsen 2014-03-25 13:12:12 UTC
Example:

import dnf
import dnf.callback
        
class MyRPMCallback(dnf.callback.RPMProgress):

    def progress(self, name, to_do, fraction):
        print("%s : %s : %f" %  (name, to_do, fraction))
        

base = dnf.Base()
base.install("somthing")
base.resolve()
base.do_transaction(display=MyRPMCallback())

Comment 5 Fedora End Of Life 2015-05-29 11:21:37 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Fedora End Of Life 2015-06-29 19:41:12 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.