Bug 1080501
| Summary: | use of tls with libvirt.so can leave zombie processes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Chris Pelland <cpelland> | ||||||||
| Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||||
| Severity: | urgent | Docs Contact: | |||||||||
| Priority: | urgent | ||||||||||
| Version: | 6.2 | CC: | acathrow, bili, cpelland, dyuan, eblake, jdenemar, jherrman, mjenner, mprivozn, mzhan, pm-eus, ydu, zhwang | ||||||||
| Target Milestone: | rc | Keywords: | Upstream, ZStream | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | libvirt-0.10.2-29.el6_5.6 | Doc Type: | Bug Fix | ||||||||
| Doc Text: |
A previous update introduced an error where a SIG_SETMASK argument was incorrectly replaced by a SIG_BLOCK argument after the poll() system call. Consequently, the SIGCHLD signal could be permanently blocked, which caused signal masks not to return to their original values and defunct processes to be generated. With this update, the original signal masks are restored as intended, and poll() now functions correctly.
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-04-07 07:26:16 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1078589 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Pelland
2014-03-25 14:39:03 UTC
Hi Michal I didn't reproduce this bug with this link in the downstream, https://www.redhat.com/archives/libvir-list/2014-March/msg00858.html can you give me some suggestion? so that i can verify this bug sufficiently. thanks, the following was my current verify steps, please help check it. pkginfo(the server and client was same) libvirt-0.10.2-18.el6 steps 1.configure the tls env you can see the attachment for more details 2.Download the perl script from the following link https://www.redhat.com/archives/libvir-list/2014-March/msg00858.html 3.Run the script, I didn't met any info and warning during my testing, even, didn't see it in the libvirt log # perl test-chldhandle-bug.pl init... pid=19347 while... fork 1 end... pid=19348 receive chld fork 2 end... pid=19349 receive chld connection open fork 3 end... pid=19350 fork 4 end... pid=19351 go next... while... fork 1 end... pid=19352 fork 2 end... pid=19353 connection open fork 3 end... pid=19362 fork 4 end... pid=19364 go next... while... Created attachment 878947 [details]
The configuration of tls
Created attachment 878948 [details]
The perl script which used to reporduce
(In reply to zhenfeng wang from comment #6) > Hi Michal > I didn't reproduce this bug with this link in the downstream, > https://www.redhat.com/archives/libvir-list/2014-March/msg00858.html > > can you give me some suggestion? so that i can verify this bug > sufficiently. thanks, the following was my current verify steps, please help > check it. > > pkginfo(the server and client was same) > libvirt-0.10.2-18.el6 > > steps > 1.configure the tls env > you can see the attachment for more details > > 2.Download the perl script from the following link > https://www.redhat.com/archives/libvir-list/2014-March/msg00858.html > > 3.Run the script, I didn't met any info and warning during my testing, even, > didn't see it in the libvirt log > > # perl test-chldhandle-bug.pl > init... pid=19347 > while... > fork 1 > end... pid=19348 > receive chld > fork 2 > end... pid=19349 > receive chld > connection open > fork 3 > end... pid=19350 > fork 4 > end... pid=19351 > go next... > while... > fork 1 > end... pid=19352 > fork 2 > end... pid=19353 > connection open > fork 3 > end... pid=19362 > fork 4 > end... pid=19364 > go next... > while... In fact you did reproduce this bug. Noticed these 'receive chld' messages? They can be seen only twice. If you take a look at the script, at the first run, prior to opening a libvirt connection, the script forks two times and the parent receives SIGCHLD immediately. The signal handler prints the message. However, as the script goes on, it opens the libvirt connection (and the bug reproduces itself) so from now on, you can see no handler message. This means, the signal is ignored. Indeed, if you let the script run for a while (say a minute), and run ps in another terminal, you can see something like this: 1184 tty2 S+ 0:00 \_ perl test-chldhandle-bug-fixed.pl 1188 tty2 Z+ 0:00 \_ [perl] <defunct> 1189 tty2 Z+ 0:00 \_ [perl] <defunct> 1190 tty2 Z+ 0:00 \_ [perl] <defunct> 1191 tty2 Z+ 0:00 \_ [perl] <defunct> 1192 tty2 Z+ 0:00 \_ [perl] <defunct> 1193 tty2 Z+ 0:00 \_ [perl] <defunct> 1194 tty2 Z+ 0:00 \_ [perl] <defunct> 1195 tty2 Z+ 0:00 \_ [perl] <defunct> 1196 tty2 Z+ 0:00 \_ [perl] <defunct> 1197 tty2 Z+ 0:00 \_ [perl] <defunct> So there are some zombies. (In reply to zhenfeng wang from comment #8) > Created attachment 878948 [details] > The perl script which used to reporduce please ignore this script, since there was some issues about this script itself, and i'll attach the new script in the attachment, please use the new script to test. Created attachment 879426 [details]
The new perl script which used to reporduce
Thanks for Michal's quick response, I can get the expect result with the latest libvirt packet and the new perl script. The verify steps as follows pkginfo (the server and client was same) libvirt-0.10.2-29.el6_5.7.x86_64 steps 1.excute step 1~2 as comment 6 description 2.Run the new script in comment11, could see the "receive chld" messages every time, also didn't find other zombie processes in another terminal # perl libvirt-perl.pl init... pid=24570 while... fork 1 end... pid=24571 receive chld fork 2 end... pid=24572 receive chld connection open fork 3 end... pid=24578 receive chld fork 4 end... pid=24579 receive chld go next... while... fork 1 end... pid=24580 receive chld fork 2 end... pid=24581 receive chld connection open fork 3 end... pid=24587 receive chld fork 4 end... pid=24588 receive chld go next... # ps afx|grep perl 24674 pts/4 S+ 0:00 | \_ grep perl 24657 pts/1 S+ 0:00 | \_ perl libvirt-perl.pl According to the uppper descriptions and comment 9, mark this bug verified Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0375.html |