Spec URL: http://petersen.fedorapeople.org/reviews/ghc-transformers.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-transformers-0.3.0.0-33.fc20.src.rpm Description: A portable library of functor and monad transformers, inspired by the paper "Functional Programming with Overloading and Higher-Order Polymorphism", by Mark P Jones, in "Advanced School of Functional Programming", 1995 (<http://web.cecs.pdx.edu/~mpj/pubs/springschool.html>). This package contains: * the monad transformer class (in "Control.Monad.Trans.Class") * concrete functor and monad transformers, each with associated operations and functions to lift operations associated with other transformers. It can be used on its own in portable Haskell code, or with the monad classes in the 'mtl' or 'monads-tf' packages, which automatically lift operations introduced by monad transformers through other transformers.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6674318
This review is to move transformers out of haskell-platform. ghc-7.8 potentially includes the transformers library so I thought maybe we could avoid this one, but I think it is needed anyway for ghc-7.6.3 in EPEL7 so we better have it after all I think... Original package review is bug 630270. transformers is needed by mtl and has over 1000 reverse deps (consumers) in Hackage!! http://packdeps.haskellers.com/reverse/transformers
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package do not use a name that already exist Note: A package already exist with this name, please check https://admin.fedoraproject.org/pkgdb/acls/name/ghc-transformers See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1413120 bytes in 86 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [-]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 25 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- transformers-0.3.0.0/Control/Applicative/Backwards.hs transformers-0.3.0.0/Control/Applicative/Lift.hs transformers-0.3.0.0/Control/Monad/IO/Class.hs transformers-0.3.0.0/Control/Monad/Trans/Class.hs transformers-0.3.0.0/Control/Monad/Trans/Cont.hs transformers-0.3.0.0/Control/Monad/Trans/Error.hs transformers-0.3.0.0/Control/Monad/Trans/Identity.hs transformers-0.3.0.0/Control/Monad/Trans/List.hs transformers-0.3.0.0/Control/Monad/Trans/Maybe.hs transformers-0.3.0.0/Control/Monad/Trans/RWS.hs transformers-0.3.0.0/Control/Monad/Trans/RWS/Lazy.hs transformers-0.3.0.0/Control/Monad/Trans/RWS/Strict.hs transformers-0.3.0.0/Control/Monad/Trans/Reader.hs transformers-0.3.0.0/Control/Monad/Trans/State.hs transformers-0.3.0.0/Control/Monad/Trans/State/Lazy.hs transformers-0.3.0.0/Control/Monad/Trans/State/Strict.hs transformers-0.3.0.0/Control/Monad/Trans/Writer.hs transformers-0.3.0.0/Control/Monad/Trans/Writer/Lazy.hs transformers-0.3.0.0/Control/Monad/Trans/Writer/Strict.hs transformers-0.3.0.0/Data/Functor/Compose.hs transformers-0.3.0.0/Data/Functor/Constant.hs transformers-0.3.0.0/Data/Functor/Identity.hs transformers-0.3.0.0/Data/Functor/Product.hs transformers-0.3.0.0/Data/Functor/Reverse.hs transformers-0.3.0.0/Setup.hs [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Haskell: [x]: This should never happen ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1495040 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: ghc-transformers-0.3.0.0-33.fc21.i686.rpm ghc-transformers-devel-0.3.0.0-33.fc21.i686.rpm ghc-transformers-0.3.0.0-33.fc21.src.rpm ghc-transformers.i686: W: spelling-error Summary(en_US) functor -> function ghc-transformers.i686: W: spelling-error Summary(en_US) monad -> nomad, gonad, Mona ghc-transformers.i686: W: spelling-error %description -l en_US functor -> function ghc-transformers.i686: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-transformers.i686: W: spelling-error %description -l en_US http -> HTTP ghc-transformers.i686: W: spelling-error %description -l en_US cecs -> ceca, secs, pecs ghc-transformers.i686: W: spelling-error %description -l en_US pdx -> pd, pix, pox ghc-transformers.i686: W: spelling-error %description -l en_US edu -> ed, educ, due ghc-transformers.i686: W: spelling-error %description -l en_US mpj -> mph, mp, mpg ghc-transformers.i686: W: spelling-error %description -l en_US springschool -> spring school, spring-school, schooling ghc-transformers.i686: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml ghc-transformers.i686: W: spelling-error %description -l en_US Monad -> Mona, Gonad, Mon ad ghc-transformers.i686: W: spelling-error %description -l en_US mtl -> mt, ml, mil ghc-transformers.i686: W: spelling-error %description -l en_US monads -> nomads, gonads ghc-transformers.i686: W: spelling-error %description -l en_US tf -> ft, t, f ghc-transformers.src: W: spelling-error Summary(en_US) functor -> function ghc-transformers.src: W: spelling-error Summary(en_US) monad -> nomad, gonad, Mona ghc-transformers.src: W: spelling-error %description -l en_US functor -> function ghc-transformers.src: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-transformers.src: W: spelling-error %description -l en_US http -> HTTP ghc-transformers.src: W: spelling-error %description -l en_US cecs -> ceca, secs, pecs ghc-transformers.src: W: spelling-error %description -l en_US pdx -> pd, pix, pox ghc-transformers.src: W: spelling-error %description -l en_US edu -> ed, educ, due ghc-transformers.src: W: spelling-error %description -l en_US mpj -> mph, mp, mpg ghc-transformers.src: W: spelling-error %description -l en_US springschool -> spring school, spring-school, schooling ghc-transformers.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml ghc-transformers.src: W: spelling-error %description -l en_US Monad -> Mona, Gonad, Mon ad ghc-transformers.src: W: spelling-error %description -l en_US mtl -> mt, ml, mil ghc-transformers.src: W: spelling-error %description -l en_US monads -> nomads, gonads ghc-transformers.src: W: spelling-error %description -l en_US tf -> ft, t, f ghc-transformers.src: W: strange-permission transformers-0.3.0.0.tar.gz 0444L 3 packages and 0 specfiles checked; 0 errors, 31 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ghc-transformers-devel ghc-transformers ghc-transformers.i686: W: spelling-error Summary(en_US) functor -> function ghc-transformers.i686: W: spelling-error Summary(en_US) monad -> nomad, gonad, Mona ghc-transformers.i686: W: spelling-error %description -l en_US functor -> function ghc-transformers.i686: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-transformers.i686: W: spelling-error %description -l en_US http -> HTTP ghc-transformers.i686: W: spelling-error %description -l en_US cecs -> ceca, secs, pecs ghc-transformers.i686: W: spelling-error %description -l en_US pdx -> pd, pix, pox ghc-transformers.i686: W: spelling-error %description -l en_US edu -> ed, educ, due ghc-transformers.i686: W: spelling-error %description -l en_US mpj -> mph, mp, mpg ghc-transformers.i686: W: spelling-error %description -l en_US springschool -> spring school, spring-school, schooling ghc-transformers.i686: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml ghc-transformers.i686: W: spelling-error %description -l en_US Monad -> Mona, Gonad, Mon ad ghc-transformers.i686: W: spelling-error %description -l en_US mtl -> mt, ml, mil ghc-transformers.i686: W: spelling-error %description -l en_US monads -> nomads, gonads ghc-transformers.i686: W: spelling-error %description -l en_US tf -> ft, t, f 2 packages and 0 specfiles checked; 0 errors, 15 warnings. # echo 'rpmlint-done:' Requires -------- ghc-transformers-devel (rpmlib, GLIBC filtered): /bin/sh ghc(transformers-0.3.0.0-d21f52e90b1d5cc3abf0aef9ee2c016d) ghc-compiler ghc-devel(base-4.6.0.1-ced5f3d8c90960e9f372129163296e44) ghc-transformers(x86-32) ghc-transformers (rpmlib, GLIBC filtered): ghc(base-4.6.0.1-ced5f3d8c90960e9f372129163296e44) libHSbase-4.6.0.1-ghc7.6.3.so libHSghc-prim-0.3.0.0-ghc7.6.3.so libHSinteger-gmp-0.5.0.0-ghc7.6.3.so libc.so.6 libgmp.so.10 rtld(GNU_HASH) Provides -------- ghc-transformers-devel: ghc-devel(transformers-0.3.0.0-d21f52e90b1d5cc3abf0aef9ee2c016d) ghc-transformers-devel ghc-transformers-devel(x86-32) ghc-transformers-static ghc-transformers: ghc(transformers-0.3.0.0-d21f52e90b1d5cc3abf0aef9ee2c016d) ghc-transformers ghc-transformers(x86-32) libHStransformers-0.3.0.0-ghc7.6.3.so Unversioned so-files -------------------- ghc-transformers: /usr/lib/ghc-7.6.3/transformers-0.3.0.0/libHStransformers-0.3.0.0-ghc7.6.3.so Source checksums ---------------- http://hackage.haskell.org/package/transformers-0.3.0.0/transformers-0.3.0.0.tar.gz : CHECKSUM(SHA256) this package : e5aa0c1ec97ad98c389e78f59aca25ab028980a7068a3e585e39564662739591 CHECKSUM(SHA256) upstream package : e5aa0c1ec97ad98c389e78f59aca25ab028980a7068a3e585e39564662739591 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn ghc-transformers-0.3.0.0-33.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Haskell, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ----------------------------------------- PACKAGE APPROVED.
Thank you very much for doing the review so soon. :) Package Change Request ====================== Package Name: ghc-transformers New Branches: f20 f19 epel7 Owners: petersen InitialCC: haskell-sig
Git done (by process-git-requests).
Thank you again This is now built for f21 rawhide and will be backported later to F20 and EPEL7.
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, haskell-platform-2013.2.0.0-33.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-async-2.0.1.4-30.fc20,ghc-html-1.0.1.2-28.fc20,ghc-HTTP-4000.2.8-32.fc20,ghc-HUnit-1.2.5.2-31.fc20,ghc-network-2.4.1.2-31.fc20,ghc-parsec-3.1.3-30.fc20,ghc-QuickCheck-2.6-32.fc20,ghc-regex-base-0.93.2-28.fc20,ghc-regex-posix-0.95.2-29.fc20,ghc-transformers-0.3.0.0-33.fc20,haskell-platform-2013.2.0.0-33.fc20
ghc-async-2.0.1.4-30.fc20, ghc-html-1.0.1.2-28.fc20, ghc-HTTP-4000.2.8-32.fc20, ghc-HUnit-1.2.5.2-31.fc20, ghc-network-2.4.1.2-31.fc20, ghc-parsec-3.1.3-30.fc20, ghc-QuickCheck-2.6-32.fc20, ghc-regex-base-0.93.2-28.fc20, ghc-regex-posix-0.95.2-29.fc20, ghc-transformers-0.3.0.0-33.fc20, alex-3.0.5-36.fc20, cabal-install-1.16.0.2-34.fc20, ghc-parallel-3.2.0.3-34.fc20, ghc-regex-compat-0.95.1-34.fc20, ghc-syb-0.4.0-35.fc20, happy-1.18.10-34.fc20, haskell-platform-2013.2.0.0-36.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.