Bug 1080790 - Remove usages of vdsm logging conf from vdsm-tool
Summary: Remove usages of vdsm logging conf from vdsm-tool
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: vdsm
Version: 3.5
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 3.5.0
Assignee: Dima Kuznetsov
QA Contact: Gil Klein
URL:
Whiteboard: infra
: 1080580 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-26 07:30 UTC by Yaniv Bronhaim
Modified: 2016-02-10 19:34 UTC (History)
13 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-10-12 14:17:42 UTC
oVirt Team: Infra
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 27193 0 None None None Never

Description Yaniv Bronhaim 2014-03-26 07:30:20 UTC
Description of problem:

vdsm-tool usually runs with root privileges (as admin tool). if a verb can access or uses vdsm logging config file it can lead to ownership changes on vdsm log files.

We need to separate all usages of logging between vdsm logging config to vdsm-tool logging.

currently the only use-case relevant for this case is in too/upgrade.py. this should be fixed and the hack of changing the ownership on pre-task (http://gerrit.ovirt.org/#/c/25912/) should be remove.

shouldn't be any correlation between vdsm.logging.conf to vdsm-tool.


Actual results:
vdsm.log ownership becomes root:root

Comment 1 Alon Bar-Lev 2014-03-26 10:59:22 UTC
command-line tools should not log into /var/log

command-line tools should have optional log parameter for these who want to log.

Comment 2 Douglas Schilling Landgraf 2014-03-29 14:27:05 UTC
*** Bug 1080580 has been marked as a duplicate of this bug. ***

Comment 3 Gil Klein 2014-10-12 14:17:42 UTC
This bug was fixed and is slated to be in the upcoming version. As we
are focusing our testing at this phase on severe bugs, this bug was
closed without going through its verification step. If you think this
bug should be verified by QE, please set its severity to high and move
it back to ON_QA


Note You need to log in before you can comment on or make changes to this bug.