RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1081242 - pcs should abort if required parameter is not present while creating a resource
Summary: pcs should abort if required parameter is not present while creating a resource
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pcs
Version: 7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Tomas Jelinek
QA Contact: Miroslav Lisik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-26 20:42 UTC by Jaroslav Kortus
Modified: 2015-03-05 09:19 UTC (History)
6 users (show)

Fixed In Version: pcs-0.9.129-1.el7
Doc Type: Bug Fix
Doc Text:
Cause: User creates resource without specifying mandatory parameters. Consequence: Pcs prints a warning and creates misconfigured resource that cannot be started by the cluster. Fix: Do not create resource with missing mandatory parameters unless --force is specified. Result: Pcs prints a warning and exits without creating the misconfigured resource.
Clone Of:
Environment:
Last Closed: 2015-03-05 09:19:10 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
proposed fix (17.42 KB, patch)
2014-09-19 11:17 UTC, Tomas Jelinek 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:0415 0 normal SHIPPED_LIVE pcs bug fix and enhancement update 2015-03-05 14:16:41 UTC

Description Jaroslav Kortus 2014-03-26 20:42:49 UTC 
Description of problem:
pcs allows you to create a resource with missing mandatory parameter.
For instance create a Filesystem resource without requried "directory" parameter:
# pcs resource create fs ocf:heartbeat:Filesystem device=/dev/light_cluster/fslvm-001 fstype=ext4
Warning: missing required option(s): 'directory' for resource type: ocf:heartbeat:Filesystem

Even though warning is issued, the misconfigured resource is configured in pacemaker (and failing immediately).

pcs should reject the command (exit non-zero and do not push the resource to pacemaker) unless --force is specified on the command line.

Version-Release number of selected component (if applicable):
pcs-0.9.115-32.el7.x86_64

How reproducible:
always

Steps to Reproduce:
1. create a resource with missing mandatory parameter (derived from pcs resource describe <resource>)
2.
3.

Actual results:
warning issued, resource created

Expected results:
warning issued, resource not created, allow --force if you are sure

Additional info:
Comment 2 Chris Feist 2014-08-18 22:36:41 UTC 
Before we fix this, we're going to want to fix the issue of some resources (especially fence agents that require the 'port' parameter even though pcmk_host_map, etc. is specified).

As soon as that's fixed this can be fixed as well.
Comment 5 Tomas Jelinek 2014-09-19 11:17:45 UTC 
Created attachment 939229 [details]
proposed fix
Comment 6 Tomas Jelinek 2014-09-22 11:45:53 UTC 
Before Fix:
[root@rh70-node1 ~]# rpm -q pcs
pcs-0.9.115-32.el7.x86_64
[root@rh70-node1:~]# pcs status resources
[root@rh70-node1:~]# pcs resource create fs ocf:heartbeat:Filesystem device=/dev/light_cluster/fslvm-001 fstype=ext4
Warning: missing required option(s): 'directory' for resource type: ocf:heartbeat:Filesystem
[root@rh70-node1:~]# echo $?
0
[root@rh70-node1:~]# pcs status resources
 fs     (ocf::heartbeat:Filesystem):    Stopped

After Fix:
[root@rh70-node1:~]# rpm -q pcs
pcs-0.9.129-1.el7.x86_64
[root@rh70-node1:~]# pcs status resources
[root@rh70-node1:~]# pcs resource create fs ocf:heartbeat:Filesystem device=/dev/light_cluster/fslvm-001 fstype=ext4
Error: missing required option(s): 'directory' for resource type: ocf:heartbeat:Filesystem (use --force to override)
[root@rh70-node1:~]# echo $?
1
[root@rh70-node1:~]# pcs status resources
[root@rh70-node1:~]# pcs resource create fs ocf:heartbeat:Filesystem device=/dev/light_cluster/fslvm-001 fstype=ext4 --force
[root@rh70-node1:~]# echo $?
0
[root@rh70-node1:~]# pcs status resources
 fs     (ocf::heartbeat:Filesystem):    Stopped
Comment 8 Miroslav Lisik 2015-01-15 17:37:46 UTC 
Marking Verified in version pcs-0.9.137-10.el7.x86_64.

The pcs aborts when required parameter is not present while creating a
resource.

[root@virt-017 ~]# pcs resource create bind_fs ocf:heartbeat:Filesystem device=/etc fstype=none options=bind
Error: missing required option(s): 'directory' for resource type: ocf:heartbeat:Filesystem (use --force to override)
[root@virt-017 ~]# echo $?
1
[root@virt-017 ~]# pcs status resources | grep bind_fs
[root@virt-017 ~]# pcs resource create bind_fs ocf:heartbeat:Filesystem device=/etc fstype=none options=bind --force
[root@virt-017 ~]# pcs status resources | grep bind_fs
 bind_fs        (ocf::heartbeat:Filesystem):    FAILED

Correctly failed as expected.
Comment 10 errata-xmlrpc 2015-03-05 09:19:10 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0415.html
Note You need to log in before you can comment on or make changes to this bug.