Bug 1081323 - beaker-wizard: Make vim modeline optional
Summary: beaker-wizard: Make vim modeline optional
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Beaker
Classification: Retired
Component: wizard
Version: 0.16
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: beaker-dev-list
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-03-27 02:56 UTC by Amit Saha
Modified: 2020-11-19 21:53 UTC (History)
4 users (show)

Fixed In Version:
Clone Of: 1077555
Environment:
Last Closed: 2020-11-19 21:48:56 UTC
Embargoed:


Attachments (Terms of Use)

Description Amit Saha 2014-03-27 02:56:12 UTC
beaker-wizard should ask the test creator if preconfigured Vim headers should be added or not.

+++ This bug was initially created as a clone of Bug #1077555 +++

Description of problem:
Beaker-wizard's generated runtest.sh template contains this:
  # vim: dict=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
this setting overwrite my dictionary settings. We should use dict+=/path/to/dict

Version-Release number of selected component (if applicable):
  beaker-client-0.16.0-1.fc19.noarch

How reproducible:
  always

Steps to Reproduce:
1. Define some dictionary in ~/.vimrc
2. Open runtest.sh generated by beaker-wizard
3. :set dictionary

Actual results:
  dictionary=/usr/share/beakerlib/dictionary.vim

Expected results:
 dictionary=/home/bblaskov/mydict,/usr/share/beakerlib/dictionary.vim

Additional info:
  Fix is really easy. Just change variable 'VimDictionary' on line 384 in file '/usr/lib/python2.7/site-packages/bkr/client/wizard.py'.
    VimDictionary = "# vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k"

--- Additional comment from HSS Product Manager on 2014-03-18 05:19:17 EDT ---

Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

--- Additional comment from Amit Saha on 2014-03-18 20:50:05 EDT ---


--- Additional comment from Raymond Mancy on 2014-03-24 22:41:52 EDT ---

(In reply to Dan Callaghan from comment #5)
> I'm on the fence about this. On the one hand, beaker-wizard is generating a
> skeleton for you -- that means, it's making some suggestions and if you
> don't like what it produced you just edit it as you please. 

The good thing about this skeleton generator, is that it asks you a lot of questions as well. It does not assume what your name is, it asks you to provide useful information to it.

Why not have it ask the question "Do you want to include vim headers?"
This way, we aren't throwing away useful tidbits, nor are we putting 'junk' into some peoples test files. Would that work?

--- Additional comment from Branislav Blaškovič on 2014-03-25 05:21:34 EDT ---

(In reply to Raymond Mancy from comment #10)
> Why not have it ask the question "Do you want to include vim headers?"

If you do it like this, please include some argument to have it implicit, for example:
  beaker-wizard --vim -b 123456

Thank you

Comment 1 Dan Callaghan 2014-03-27 03:17:10 UTC
Another idea is to check $EDITOR.


Note You need to log in before you can comment on or make changes to this bug.