Bug 1081704

Reassigning to Summer Long, who is responsible for all Compute content.

Upstream doc bugs: 
https://bugs.launchpad.net/openstack-manuals/+bug/1287406
https://review.openstack.org/#/c/66678/
https://review.openstack.org/#/c/67264/

https://bugs.launchpad.net/openstack-manuals/+bug/1287450
https://review.openstack.org/#/c/75943/

You can now set a virtual hardware watchdog device for libvirt by:
--Setting the image through '--property hw_watchdog_action=i6300esb'
Where action is one of:
'reset' — default, forcefully reset the guest
'shutdown' — gracefully shutdown the guest
'poweroff' — forcefully power off the guest
'pause' — pause the guest
'none' — do nothing
'dump' — automatically dump core of the guest

From Fedora: Note that the 'shutdown' action requires that the guest is responsive to ACPI signals. In the sort of situations where the watchdog has expired, guests are usually unable to respond to ACPI signals. Therefore using 'shutdown' is not recommended. In addition, the directory to save dump files can be configured by auto_dump_path in file /etc/libvirt/qemu.conf.

--flavor extra_specs
API= {'hw_watchdog_action': 'none'}
Patch for nova accessing flavor extra_specs: https://review.openstack.org/#/c/10768/

property overrides extra_specs

Submitted patch for both 1287450/1287406 upstream doc bugs:
https://review.openstack.org/87163

Russell, I've asked you for the upstream tech review. thanks, Summer

Solly Ross implemented this upstream, so I think he'd be best to do the upstream doc review.  Solly, can you take a look?

Solly, thanks for this. Have done a rework, but could you confirm that 'disabled' is an watchdog action that can be explicitly set by the user (and not just used as the code's default)?
thanks, Summer

disabled is, in fact, a valid setting from the user.  This allows a user to use image properties to disable the watchdog for a particular image when it has been enabled at the flavor level.

Merged upstream. Ready for QE when we branch.

Bruce, could you do the peer review?

1) Reviewed section "Flavors" in Cloud Admin Guide: Looks OK.


2) Reviewed CLI Ref Guide:
2.1) In "Image Service property keys" table, entry for hw_watchdog_action is included.



3) Reviewed section "Manage Flavors" in Admin User Guide:

3.1) Section 2.7 (dashboard) covers: Overview, Create flavors, Update flavors, Delete flavors.

3.2) Section 3.8 (CLI) covers: Overview, Create flavors, Delete flavors is present. There is no update flavors in CLI section as there is in dashboard section, was it meant to be included?

3.3) The note in Admin User Guide that refers to CAG (re flavors can also determine on which compute host a flavor can be used to launch an instance.) is present.

NEEDINFO Summer

Just thought you could check the question in 3.2 in comment 14, not sure if there was meant to be an "Update" part in CLI section.

The rest looks fine, can go VERIFIED if you are OK with it.
Thx

That's correct; can't update basics through the CLI (only extra specs). BUT my  patch for the Admin Guide isn't actually showing up in the downstream version. https://review.openstack.org/#/c/87163/7/doc/user-guide-admin/section_cli_nova_manage_flavors.xml

vs

http://documentation-devel.engineering.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux_OpenStack_Platform/5/html/Administration_User_Guide/dashboard_manage_flavors.html

This change was made back in April. Deepti's doing a check of the Admin Gd structure to ensure that something didn't go wrong with the conversion.

Deepti's done the check and looks like it's ok. Moving to verified.